From: Lance Yang <lance.yang@linux.dev>
To: David Hildenbrand <david@redhat.com>
Cc: Liam.Howlett@oracle.com, baohua@kernel.org,
baolin.wang@linux.alibaba.com, dev.jain@arm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
lorenzo.stoakes@oracle.com, npache@redhat.com,
ryan.roberts@arm.com, usamaarif642@gmail.com, ziy@nvidia.com,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/1] mm: skip mlocked THPs that are underused early in deferred_split_scan()
Date: Mon, 8 Sep 2025 17:27:51 +0800 [thread overview]
Message-ID: <bae1831b-decf-46bd-a264-1cf3ccaa64a2@linux.dev> (raw)
In-Reply-To: <73c8a52c-37c5-45f4-b76e-f15267412242@redhat.com>
On 2025/9/8 17:12, David Hildenbrand wrote:
> On 08.09.25 11:07, Lance Yang wrote:
>> From: Lance Yang <lance.yang@linux.dev>
>>
>> When we stumble over a fully-mapped mlocked THP in the deferred shrinker,
>> it does not make sense to try to detect whether it is underused, because
>> try_to_map_unused_to_zeropage(), called while splitting the folio,
>> will not
>> actually replace any zeroed pages by the shared zeropage.
>>
>> Splitting the folio in that case does not make any sense, so let's not
>> even
>> scan to check if the folio is underused.
>>
>> Suggested-by: David Hildenbrand <david@redhat.com>
>
> Feel free to drop that, I only tweaked you description :)
Well, I'd actually prefer to keep it. Thanks for setting me straight on
try_to_map_unused_to_zeropage() ;p
>
> Acked-by: David Hildenbrand <david@redhat.com>
Cheers,
Lance
next prev parent reply other threads:[~2025-09-08 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 9:07 Lance Yang
2025-09-08 9:12 ` David Hildenbrand
2025-09-08 9:27 ` Lance Yang [this message]
2025-09-08 10:38 ` Kiryl Shutsemau
2025-09-08 11:32 ` David Hildenbrand
2025-09-08 11:44 ` Kiryl Shutsemau
2025-09-08 12:04 ` David Hildenbrand
2025-09-08 12:45 ` Kiryl Shutsemau
2025-09-08 13:00 ` Lance Yang
2025-09-08 11:32 ` Lance Yang
2025-09-08 14:28 ` Usama Arif
2025-09-08 16:18 ` Lorenzo Stoakes
2025-09-09 6:23 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bae1831b-decf-46bd-a264-1cf3ccaa64a2@linux.dev \
--to=lance.yang@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=usamaarif642@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox