From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1665C0729B for ; Wed, 16 Aug 2023 18:59:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272778D0050; Wed, 16 Aug 2023 14:59:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2226C8D0001; Wed, 16 Aug 2023 14:59:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C4878D0050; Wed, 16 Aug 2023 14:59:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F1ADE8D0001 for ; Wed, 16 Aug 2023 14:59:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82D97C0A31 for ; Wed, 16 Aug 2023 18:59:42 +0000 (UTC) X-FDA: 81130881804.18.78A2741 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 08192C0016 for ; Wed, 16 Aug 2023 18:59:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=escqNOSW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692212380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dv0WkZdGSj5KsM+cXSukrTh8TZi7xGS5tVs/0ZiXInY=; b=pCYaB1D5T5JAY+FJBJrUluXkk8Dos/O0lRX5ZShIKTd+/hcaXkvcVBhkQmM2GqAQZuUNrr ok3OmV+VHQkuyDs8oGsYZpqUjwXNgs+LxxAsNfXd5lN3dXMlYjjSPB+eS2mwKk58z6ATqT wjQqsRDqyUhjjvfGh0qiW62AgkQEu64= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=escqNOSW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692212380; a=rsa-sha256; cv=none; b=sx4xEKI2u9r5tZj0O+BxljTkHinkpLaM96T4UlyT4U6FRQ3ozVNlBcyGR/MmUgrgequxva uf63wCmo+swNSfywA0TEiYTYHCr00TTJ9zjBIMuA/dd5f1yvXSs5JdhGV5x6cYkqQMgyrR z8hhXbmA5V4dTkz3qg2Qx3T535ytE6Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692212379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dv0WkZdGSj5KsM+cXSukrTh8TZi7xGS5tVs/0ZiXInY=; b=escqNOSWTBg/6PAo4Hv5Fm+/A0yhYgOyxfwjsa2Xm103RNEsRo93WxwU61DKlyFyy9E1Hc dp2/gXwAcofkejQfUyK7psPq89WzLyyape1up0NTYNFykaP6vIggF45MJcvoGn9JTgGtmS +1SGrXyYbRA3m3OwMVbQ8OstrILF6+M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-16e-7xqNNLSecE-XerRO1g-1; Wed, 16 Aug 2023 14:59:35 -0400 X-MC-Unique: 16e-7xqNNLSecE-XerRO1g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fe11910e46so905125e9.0 for ; Wed, 16 Aug 2023 11:59:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692212374; x=1692817174; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dv0WkZdGSj5KsM+cXSukrTh8TZi7xGS5tVs/0ZiXInY=; b=Z8dsZz+Qt+wpFKnTBO1STXfVikYytrgIK6i4BaevZOn0zB8Ij1RiO7ohpKiivcYQg6 X8atHh9o2W1taqp+x2JWOMYgzopffkBKHfTeD4gcGNw14nei1dHxnDdO9TcK7h8Ua/w/ ykWXVD2f1Du2NoDfGyiiRWNcbURE4fJTaemROB4qKRqkXWgcCl5IJtinpUV5yvAkx0eS s/E54lA2SUhCIF/wyertnCSZ4cd3ePCnPu9NtJcLxm9bA712ZxayHZC0mS9O5fvS0Cn8 eqUyDp6Go+WS2x3xwJKoRzUKuY6iE2Z3x/abepbuBD3dyu0em58+8OcxnOdXZ8Vp4xxa z/aw== X-Gm-Message-State: AOJu0YxVDB+7gAx2qdsG9LeGO+y2vHFuFqBbu+AoyXdRZhiBe+i+9+7+ kgCAt0f8AsMb3C/C7I8alAZ6QMP6ThImEdz1EoUvKDxxBI4Ev6mcUf1cxEHoKJ91Lzr2WMedD+d hD24gyCZjfxg= X-Received: by 2002:a05:600c:3786:b0:3fe:4341:a5aa with SMTP id o6-20020a05600c378600b003fe4341a5aamr457532wmr.8.1692212374649; Wed, 16 Aug 2023 11:59:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpnglTRT7OhpMAuTy8hzXwoGAmboX/W4UQGNuXFaJjoCXzX4JEbGOKalvJ+rx8scq0V6dPAQ== X-Received: by 2002:a05:600c:3786:b0:3fe:4341:a5aa with SMTP id o6-20020a05600c378600b003fe4341a5aamr457508wmr.8.1692212374256; Wed, 16 Aug 2023 11:59:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:8b00:5520:fa3c:c527:592f? (p200300cbc74b8b005520fa3cc527592f.dip0.t-ipconnect.de. [2003:cb:c74b:8b00:5520:fa3c:c527:592f]) by smtp.gmail.com with ESMTPSA id v17-20020a1cf711000000b003fe23b10fdfsm249678wmh.36.2023.08.16.11.59.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 11:59:33 -0700 (PDT) Message-ID: Date: Wed, 16 Aug 2023 20:59:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio To: Peter Xu Cc: linux-kernel@vger.kernel.org, Matthew Wilcox , linux-mm@kvack.org, Hugh Dickins , "Kirill A . Shutemov" , Randy Dunlap , Mike Kravetz , Yu Zhao , Ryan Roberts , Andrew Morton , Yang Shi References: <20230815212547.431693-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 08192C0016 X-Stat-Signature: ah3djrdntaqjpa19w57ci8r73h7ycsnc X-HE-Tag: 1692212379-466729 X-HE-Meta: U2FsdGVkX1+lRXNUj/Z9n19Y4NcPi4jb7NdETUtmULJhhn4Yp+xMY4Is9x/ffLVFrgZJZ6Rdic2iXS67xYWeymSvIUQ2uRTZvYu0CBGulZnzlghTPtVDk/hPTrjSIcpDT+jWSS5O+r/H42TJ/sc+RR1PAg1KzETNCBZJYUbL/i26f3hs+82ZOiAiIVpMI9KmIdwvzL6sp4LtUOkAfr00pw5AzJc3Wx1mPmb7haKNBaAEfgIsC35Dh2uQLQdIVULgm5J/NG2sDFMF1cP4JUAtxa8pOXVeyvFLe+s+N9SiTeyfpDxiZGf20qeBMPsw3hjzGVKSrvi91FAglRu36lFm2K3RmY/BfgXW55pnL9jcChI264HBMTzcz61yvsXJ2Em4rtwLvHX50NcP0XGU9AW01vE+S7xy651Syzt5WmAbTyTwvlCnaRFa7dmIFK4lXGmmQsCsNHT661/XBQnvh4wRI9cHjyRWtgpYdOhe1mGtYM7ZnxEPy2a/rOdTBXvm9i/NfUpwLqEiiq59wMUijGZOnBAGu+aRffH5ivhLv/ELQFKcGD7+7Ad/149gmfIu8s5QaEpAIm+2/jFdEP6cUdCl5cTOAhaM7BhlxT6u1F1NsbcffxiPHZ8IMysLLljAx8DqHZWtkkFJMkgdYknfnrowpCJ7YjiJHdkIKSK5RGx4JMchy3sYl49NL0ooLfa7Mks9Hh2YKRMAOTIi2FQDKLvRtngLQ1W3ltvsXXbKf6+QIeliGrR/uDYJTyEVodf4/oI/uW2RiL1guHLpdfmehaaN69oJlV7IppPt97ZYQO6/UDrRJU74+ILm6dSvelyftjBZkJlsus+fH3NO59uqd2MOTH8vXBqJ5IllXtgn7oV6GC9RWKH+UxKd3RJm4idKDPzyzY3eY0FJWDiSzPOYqczg5k/sbkIqwr5E1Xt2LkdIaOUT/8ymX0dAltEb1GQ+i+1bCJ+/w8qZLe7avcFqdvO bwhRN8yl aXzthM3OIbnK4sVzk9fOkjuHH3V52SO/k6dp6EAcd6Un4XMKs3wWGPQEG3WIbJuyh3QTvDAzhNLQYxnJd8X+tfuUaCUOMFuY/v+aNiBtjQEN1qdr3o9/kW2pOQSSa4bLERWSSJcSGfQuQfEqC+45uyoRBh64EFk8I82wW900j8aCP9HotCWNflU8x3JMsBDRIcc+JDv+k+BLXrI0/YFhE44Jec/efg8V5HnQQ5WWuy4BRoR7z6HLCon+nCpUgLn7TQA0huJ3Y8ng/I09gAv8aGe3D2TSv3pIhLQEYeU9fK07b5GMje5p1MOlReV0G9l1xMsXeU613/lK0dhQCBkG1vnVHTIu089qs5aQjBeItIontx7FsVTW6XfJu5SLp3E8DPRvx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> do { >> xas_lock_irq(&xas); >> @@ -113,7 +114,6 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t entry, >> if (shadowp) >> *shadowp = old; >> } >> - set_page_private(folio_page(folio, i), entry.val + i); >> xas_store(&xas, folio); >> xas_next(&xas); >> } >> @@ -154,9 +154,9 @@ void __delete_from_swap_cache(struct folio *folio, >> for (i = 0; i < nr; i++) { >> void *entry = xas_store(&xas, shadow); >> VM_BUG_ON_PAGE(entry != folio, entry); >> - set_page_private(folio_page(folio, i), 0); >> xas_next(&xas); >> } >> + folio->private = 0; > > I'd rather remove all direct reference to "private" for swap alongside, if > this would be the last spot (perhaps folio_set_swap_entry()). Good idea, thanks! -- Cheers, David / dhildenb