From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>,
Randy Dunlap <rdunlap@infradead.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Yu Zhao <yuzhao@google.com>, Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH RFC v3] mm: Proper document tail pages fields for folio
Date: Wed, 16 Aug 2023 20:59:32 +0200 [thread overview]
Message-ID: <bade83ec-1617-1efa-6146-fa179a796174@redhat.com> (raw)
In-Reply-To: <ZNz/DtyWS1ol8xAY@x1n>
>> do {
>> xas_lock_irq(&xas);
>> @@ -113,7 +114,6 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t entry,
>> if (shadowp)
>> *shadowp = old;
>> }
>> - set_page_private(folio_page(folio, i), entry.val + i);
>> xas_store(&xas, folio);
>> xas_next(&xas);
>> }
>> @@ -154,9 +154,9 @@ void __delete_from_swap_cache(struct folio *folio,
>> for (i = 0; i < nr; i++) {
>> void *entry = xas_store(&xas, shadow);
>> VM_BUG_ON_PAGE(entry != folio, entry);
>> - set_page_private(folio_page(folio, i), 0);
>> xas_next(&xas);
>> }
>> + folio->private = 0;
>
> I'd rather remove all direct reference to "private" for swap alongside, if
> this would be the last spot (perhaps folio_set_swap_entry()).
Good idea, thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-08-16 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 21:25 Peter Xu
2023-08-16 13:33 ` David Hildenbrand
2023-08-16 16:53 ` Peter Xu
2023-08-16 18:59 ` David Hildenbrand [this message]
2023-08-16 18:41 ` Matthew Wilcox
2023-08-16 18:51 ` David Hildenbrand
2023-08-16 22:05 ` Matthew Wilcox
2023-08-18 14:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bade83ec-1617-1efa-6146-fa179a796174@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=rdunlap@infradead.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox