From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56E4C0219E for ; Wed, 12 Feb 2025 03:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34EB66B009D; Tue, 11 Feb 2025 22:24:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEF96B009E; Tue, 11 Feb 2025 22:24:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C73B6B009F; Tue, 11 Feb 2025 22:24:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F27656B009D for ; Tue, 11 Feb 2025 22:24:51 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 70A9B4C1C8 for ; Wed, 12 Feb 2025 03:24:51 +0000 (UTC) X-FDA: 83109850782.19.6CE994C Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id EE5F740007 for ; Wed, 12 Feb 2025 03:24:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739330689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GrqzNbeex6lepkpycEyAFvKlVsI43TygFYZx56tkzx4=; b=bouiNBaPAfU0Ip7cSWv9vvl6LQLjLSHsA922qWzXlRRrLgaA9pE2IHQOGGWc4pEvx+lIlp gUsBnEeztDq8ZwyPG4GU8Ux74CyTnrpe5ebntmy0rASkkimLXwgY1E0eByco05nHXcSbAB 0NjaAJP897JBIAAYsUmHddNTAE2aLEg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739330689; a=rsa-sha256; cv=none; b=Sc3otlVc+wbVnpVs0nZCAhr7gupO2mV8Ht+6JuI6uyyNeb37cFnRE+w/m90VKSNoexL3oj FpS5hE56/Qp3Whf2xNwlUmmshbxGMxo3GLuwi+cLbunLjHK7LBo6z+dNyXM0vIA8PSWsDv v0sJep8UfUK/VRV+4vgQZ46kt55wdB8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of chenridong@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=chenridong@huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Yt3ZZ5T2Zz4f3jqL for ; Wed, 12 Feb 2025 11:24:22 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id CAD771A120C for ; Wed, 12 Feb 2025 11:24:38 +0800 (CST) Received: from [10.67.109.79] (unknown [10.67.109.79]) by APP2 (Coremail) with SMTP id Syh0CgDX4GNzFKxnNpxXDg--.64293S2; Wed, 12 Feb 2025 11:24:36 +0800 (CST) Message-ID: Date: Wed, 12 Feb 2025 11:24:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/oom_kill: revert watchdog reset in global OOM process To: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, mkoutny@suse.com, paulmck@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com References: <20250212025707.67009-1-chenridong@huaweicloud.com> Content-Language: en-US From: Chen Ridong In-Reply-To: <20250212025707.67009-1-chenridong@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgDX4GNzFKxnNpxXDg--.64293S2 X-Coremail-Antispam: 1UD129KBjvJXoW7urWxuryrWryrKF1xCr1UGFg_yoW8Aryxpa yDu3WUKws8ta45Z3W7ZrWI9F17J3yrZr48tF9rt34rZwsxtrn2krWIkrnIqr95AFZI9a4Y vFnIgrn7JrZ0qw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWr XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1 7KsUUUUUU== X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ X-Rspam-User: X-Rspamd-Queue-Id: EE5F740007 X-Rspamd-Server: rspam07 X-Stat-Signature: g389st77xrdo4uxwqoss6no36sk5kmck X-HE-Tag: 1739330686-598984 X-HE-Meta: U2FsdGVkX19GJ6AveF8OpFdxg5bMi/4L4whmn45rD7Cya82dbIlE6V54AcxyBZqBm+IQgV7DtPsQyXi+mYgmmhIIOx7vok6C5QiDfyv4pUbrKaX3sS5gKeeFTDxUvHcuwRSbidyMGOXk9MWvZZ74u2mAbvuHOk4qnptAu6VtYbbYE8OprRZoQS6sPsnoV1ebRaP4XemBnyuN1JkSgm1R/fmty8u5wOYu0ROTZxYmGCEagNlLc8OmQKsvFQOz1qT4ZtykBIgy/uE+K1JbWnB5Z2NYkR3D9+fUFnEnLUL1ICjd7+LasMQS2xgy32sTsujktSEC+583v6lpqu6IQ5Zf9/dS1VInqtxYcfN1xMBitm1tXON2L3jtZgUa5Oi8rL43Xt7h+FM8xeaDgYgL+EnirBHcckO2PphezeU+1z5+x7bkqk0wlMZUz7BpLZPlLQfCk9/Q1teDiwMObh3PcJxQKEueCc7utxC4GzidoUXNy1/247nc6Tyg77VWEVilpL9H5i4g4/e/GMzLNrFlQUIS4wJIZlCC8fmP5zateo0cPoca2e4IUIBeBJOPnts0b870FQ1DeK4LTD26uJNv2PGimpQCc263P71sHgsS/GitNjz9CeELOod+iwoMKwY7r9x5BP8uilz8lyzozFKB+jRMj2b2syJbxvM9W7ckQcbDr37yUhjZwyPEZq2kqjwNLnVt5ortjq5RKPiXxDC+CFgqqdLeVMxiKALxw9/Kbi8eRpj8UHUBHKJTZb5pQfPFlB/vFD4rjbJCkv69C/ZdAUDA4VbXElgVy5k9WaH4krIlrxlltX7mhtnZV+lPgMo89ql/h24rq4922u9C78AOONWUSEAcDJWL41vY7X7eol+WCha5myrtBKf4frWuPfPKp/axUt2GLpOni2E1gd4NeuZg1Xj/eh69hlo2E2A7sh6in0jXWim5XcbeMAyL8zvSuA4uzUvIaXtToHKtAylmr5c G2N3aCtW nsmIENdEy1i9mxyhWIImTsJ9xf/n45q6p2AiS80+t4nq1/M/6n0d7ioKfYQCSuOG6xPvqz7xougBCJWk2TsAnBgw/CQS75cLptniSZsB3S6TzyVBZnhYigos1p0Nb/0BFTAs0CZ9uoKB9yfkDoXwRR8X8F7fgmIJWDmWtHps07ikd0grMPFyfdTI2bH/PnRIvYJt5VYW+SfN0VKEdbKbRFkRNV2SkM4eT3Zx1qpYuDZ2evn2FbXPSswi4uNx2ddvKz0G97+Y1MyPbmX0cEYtBorKxyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/12 10:57, Chen Ridong wrote: > From: Chen Ridong > > Unlike memcg OOM, which is relatively common, global OOM events are rare > and typically indicate that the entire system is under severe memory > pressure. The commit ade81479c7dd ("memcg: fix soft lockup in the OOM > process") added the touch_softlockup_watchdog in the global OOM handler to > suppess the soft lockup issues. However, while this change can suppress > soft lockup warnings, it does not address RCU stalls, which can still be > detected and may cause unnecessary disturbances. Simply remove the > modification from the global OOM handler. > > Fixes: ade81479c7dd ("memcg: fix soft lockup in the OOM process") > Signed-off-by: Chen Ridong > --- > mm/oom_kill.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 25923cfec9c6..2d8b27604ef8 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -44,7 +44,6 @@ > #include > #include > #include > -#include > > #include > #include "internal.h" > @@ -431,15 +430,10 @@ static void dump_tasks(struct oom_control *oc) > mem_cgroup_scan_tasks(oc->memcg, dump_task, oc); > else { > struct task_struct *p; > - int i = 0; > > rcu_read_lock(); > - for_each_process(p) { > - /* Avoid potential softlockup warning */ > - if ((++i & 1023) == 0) > - touch_softlockup_watchdog(); > + for_each_process(p) > dump_task(p, oc); > - } > rcu_read_unlock(); > } > } Add discussion link: https://lore.kernel.org/cgroups/0d9ea655-5c1a-4ba9-9eeb-b45d74cc68d0@huaweicloud.com/