From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412A1C27C75 for ; Fri, 14 Jun 2024 00:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C07E16B009E; Thu, 13 Jun 2024 20:44:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB7136B009F; Thu, 13 Jun 2024 20:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7EAD6B00A0; Thu, 13 Jun 2024 20:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 884B56B009E for ; Thu, 13 Jun 2024 20:44:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1C05C80128 for ; Fri, 14 Jun 2024 00:44:52 +0000 (UTC) X-FDA: 82227649224.22.5D55E0A Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf05.hostedemail.com (Postfix) with ESMTP id 12B79100008 for ; Fri, 14 Jun 2024 00:44:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Dg14c3Ld; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718325888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kloQcFjYAvJ98yJJXSAgNR+FbPv4lnwNM8DOebShWTY=; b=eJX64IEjlrKs4+0imWxpi1bH+8H8pYWo5rzUYKcFHMJbawsWQ7oFIyoHaDAjB7vlSIsvUV eTte5b+dsPSTxOfvC7wO1cWx3JiAbmptKtfzGx9CoBI028L9T+/8t7NWpwKOzEpOOYTg8y /dy91bodjU5Cj9O900hkWG75hsJCzGA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718325888; a=rsa-sha256; cv=none; b=IUDp4yZgiXVf8UEY+nnJXGm6paReCcVSlEH4vScE+lHp9Ph405SwAXRfmC+7J9Q4K2z6bN acgfAV1hnqAjaFhUSHHGOWs6oiqJWziB4bZJ7G+rz2skwDZJAf6UC9JkwTDKNzjiF9zV/U C1nfLnKDRGcdMdkVD5VmWiqaClkRY+g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Dg14c3Ld; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718325886; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=kloQcFjYAvJ98yJJXSAgNR+FbPv4lnwNM8DOebShWTY=; b=Dg14c3LdtoKitB1ipANE0OzPIYJs7WxkNbfKZ361q/ay0ItfBQsWKTMDrba2i+wz0rD/ll33coF0PVpmqQstfml+zDuN/Lc1ZOG4sdD/b9nkfevPE/Ew5h4h19kzaMctdb4/8kPGg20mME1Gugt0Lf5ynewgQuui2S7T31f9QG8= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W8PHSfz_1718325884; Received: from 30.97.56.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8PHSfz_1718325884) by smtp.aliyun-inc.com; Fri, 14 Jun 2024 08:44:45 +0800 Message-ID: Date: Fri, 14 Jun 2024 08:44:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio To: Shakeel Butt Cc: akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <3c11000dd6c1df83015a8321a859e9775ebbc23e.1718266112.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 12B79100008 X-Stat-Signature: f93whaz6cniqza8rxedd65wagy9sy7kf X-Rspam-User: X-HE-Tag: 1718325888-717419 X-HE-Meta: U2FsdGVkX1+/W+7ejOvEeyxClx1bxCzRPSxKJphuBkmtCn4diwa2jKZxzxRqvyevwWV84+gEY8l8rvZvcWMhyhmuinzGP6pOp0CGdXGa+s+r7IKsTOzImMQ5ev1lZ1Z1Pyyapj0sCOPulAPH/hHSUIv05x+0xD1OFYzvEKmoHXm4M6LjldkB4lxK4cp5HGkmemHx4yVs9JgZSWhxrELl+5aE1ZLQXk63DemxHO+aOWRccsmGT8LfQiPeaxSKvaRcmDSMIAcI4bHl/UawOIPQ/yQeEcAKGMlUcuBMd+Ix9D55jryD2oyu7UHHH4MLArlMTuCFUdMqeWcbxqzik0rmDcCzU93ymz14VBAThwdS0uh+cI+V9jC5FGOEmx7DucMbDFFEu8f9QdJ7lpNUr7bfXvtngOQfVoGimo7V8Cn9DSS4UitD8abtwLo+l9KMQ3o21F0ferqhd4lzbjXDuAUJTR8PhPTUcoP3i1PYbxAYdgSnwa+/A57IMX+wYmk1mV5cwhNRtVObbeUw0axPMLM8xJjLVq1iCYUvy/FaoasO1iW7h9U2vcLayrrKY6EGPHSNif6LJEqBkvO7OHSdytzsjE+I7QqY99dIOQgn7Zzo10/sn3pjdAhlr5c2uHvEy++JggD9tSwg/9xaYdbrHGn0JTnIb9AIEmliNpAglNkr0RBP9Tnz1g2vGXcPfMf2plM39jNOkEufEK9EvDrObmopNts9j3YExUBamtr5zNwCHV6WEOMVv5WUyUwH30NRJ2VJfnSK5K5Tb34984603qSKJMSil2S+f/we2A63l9BJIaxd9t739W8XpdMlcad1lNMGh26yVrWPs7V1ldCzjZ1DNAEk8vtoy49+Do1pRJmewflAXmU2/7AOqnLDX/xHeJz/pDu1QzbXvJa0f0rjpQ4YXMwUGSju4mJfLjptQdZOqRo6bAq41Jk8mLSWo5Fb5sKzxR8cXJoTVLI8up2IbgA LjR7mu8S y1JMK4ImYpiSmW+ip6JR4F1e3wPlI0clpRj6+rXOtvQhg10XlE8jZ2npGjQbxWuqLjy1GSg3EQpcZi7/Wirvmc/O9MYOSE6UVtDbsot0KojvTGPrPJ1i+xc7n7x13CS2LpRhdi6VqBFX2f1NYnHK8NO2kCuj2w2ZdEA/qrl1oYaE5njfdwg3y6QsFK1DL9QT5h+3fstKrA4yDjYtzLwcZ8EutB7Nahc+1aWlPIzYIMcBZ8V7rxLi1FTqwDQl+i+DuFbonyTrLb1mA2HyeddVrrC1T+t8okYqFlicfz2z7BChlydKk6G4L0iNqFud9bIhyOwI0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/14 06:20, Shakeel Butt wrote: > On Thu, Jun 13, 2024 at 04:21:19PM GMT, Baolin Wang wrote: >> When testing shmem swapin, I encountered the warning below on my machine. >> The reason is that replacing an old shmem folio with a new one causes >> mem_cgroup_migrate() to clear the old folio's memcg data. As a result, >> the old folio cannot get the correct memcg's lruvec needed to remove itself >> from the LRU list when it is being freed. This could lead to possible serious >> problems, such as LRU list crashes due to holding the wrong LRU lock, and >> incorrect LRU statistics. >> >> To fix this issue, we can fallback to use the mem_cgroup_replace_folio() >> to replace the old shmem folio. >> >> [ 5241.100311] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x5d9960 >> [ 5241.100317] head: order:4 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 >> [ 5241.100319] flags: 0x17fffe0000040068(uptodate|lru|head|swapbacked|node=0|zone=2|lastcpupid=0x3ffff) >> [ 5241.100323] raw: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 >> [ 5241.100325] raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100326] head: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 >> [ 5241.100327] head: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100328] head: 17fffe0000000204 fffffdffd6665801 ffffffffffffffff 0000000000000000 >> [ 5241.100329] head: 0000000a00000010 0000000000000000 00000000ffffffff 0000000000000000 >> [ 5241.100330] page dumped because: VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled()) >> [ 5241.100338] ------------[ cut here ]------------ >> [ 5241.100339] WARNING: CPU: 19 PID: 78402 at include/linux/memcontrol.h:775 folio_lruvec_lock_irqsave+0x140/0x150 >> [...] >> [ 5241.100374] pc : folio_lruvec_lock_irqsave+0x140/0x150 >> [ 5241.100375] lr : folio_lruvec_lock_irqsave+0x138/0x150 >> [ 5241.100376] sp : ffff80008b38b930 >> [...] >> [ 5241.100398] Call trace: >> [ 5241.100399] folio_lruvec_lock_irqsave+0x140/0x150 >> [ 5241.100401] __page_cache_release+0x90/0x300 >> [ 5241.100404] __folio_put+0x50/0x108 >> [ 5241.100406] shmem_replace_folio+0x1b4/0x240 >> [ 5241.100409] shmem_swapin_folio+0x314/0x528 >> [ 5241.100411] shmem_get_folio_gfp+0x3b4/0x930 >> [ 5241.100412] shmem_fault+0x74/0x160 >> [ 5241.100414] __do_fault+0x40/0x218 >> [ 5241.100417] do_shared_fault+0x34/0x1b0 >> [ 5241.100419] do_fault+0x40/0x168 >> [ 5241.100420] handle_pte_fault+0x80/0x228 >> [ 5241.100422] __handle_mm_fault+0x1c4/0x440 >> [ 5241.100424] handle_mm_fault+0x60/0x1f0 >> [ 5241.100426] do_page_fault+0x120/0x488 >> [ 5241.100429] do_translation_fault+0x4c/0x68 >> [ 5241.100431] do_mem_abort+0x48/0xa0 >> [ 5241.100434] el0_da+0x38/0xc0 >> [ 5241.100436] el0t_64_sync_handler+0x68/0xc0 >> [ 5241.100437] el0t_64_sync+0x14c/0x150 >> [ 5241.100439] ---[ end trace 0000000000000000 ]--- >> >> Fixes: 85ce2c517ade ("memcontrol: only transfer the memcg data for migration") >> Signed-off-by: Baolin Wang > > Reviewed-by: Shakeel Butt Thanks for reviewing. > One request: please add VM_BUG_ON_FOLIO(folio_test_lru(folio), folio) in > mem_cgroup_migrate(). Good suggestion. I will create a separate patch to do this.