linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>,
	akpm@linux-foundation.org, Oscar Salvador <osalvador@suse.de>,
	mhocko@kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mm@kvack.org, "Rafael J . Wysocki" <rafael@kernel.org>,
	nathanl@linux.ibm.com, cheloha@linux.ibm.com,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mm: replace memmap_context by memplug_context
Date: Tue, 15 Sep 2020 09:04:10 +0200	[thread overview]
Message-ID: <bac8037f-70f6-e7e5-7982-cbfcfef45e01@linux.ibm.com> (raw)
In-Reply-To: <d6ade681-2fb1-a1df-5673-bceacd1dfc55@redhat.com>

Le 14/09/2020 à 19:10, David Hildenbrand a écrit :
> On 14.09.20 18:50, Laurent Dufour wrote:
>> The memmap_context is used to detect whether a memory operation is due to a
>> hot-add operation or happening at boot time.
>>
>> Make it general to the hotplug operation and rename it at memplug_context.
>>
>> There is no functional change introduced by this patch
>>
>> Suggested-by: David Hildenbrand <david@redhat.com>
>> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
>> ---
>>   arch/ia64/mm/init.c    |  6 +++---
>>   include/linux/mm.h     |  2 +-
>>   include/linux/mmzone.h | 11 ++++++++---
>>   mm/memory_hotplug.c    |  2 +-
>>   mm/page_alloc.c        | 10 +++++-----
>>   5 files changed, 18 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c
>> index 0b3fb4c7af29..b5054b5e77c8 100644
>> --- a/arch/ia64/mm/init.c
>> +++ b/arch/ia64/mm/init.c
>> @@ -538,7 +538,7 @@ virtual_memmap_init(u64 start, u64 end, void *arg)
>>   	if (map_start < map_end)
>>   		memmap_init_zone((unsigned long)(map_end - map_start),
>>   				 args->nid, args->zone, page_to_pfn(map_start),
>> -				 MEMMAP_EARLY, NULL);
>> +				 MEMPLUG_EARLY, NULL);
> 
> I am pretty sure that won't compile (MEMINIT_EARLY).
> 
> (same at other places)

Ouch I can't understand what I did at sending time, I did check compile on ia64 
w and w/o memory hotplug.

Sorry for the noise.




  reply	other threads:[~2020-09-15  7:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 16:50 [PATCH v2 0/3] mm: fix memory to node bad links in sysfs Laurent Dufour
2020-09-14 16:50 ` [PATCH v2 1/3] mm: replace memmap_context by memplug_context Laurent Dufour
2020-09-14 17:10   ` David Hildenbrand
2020-09-15  7:04     ` Laurent Dufour [this message]
2020-09-14 16:50 ` [PATCH v2 2/3] mm: don't rely on system state to detect hot-plug operations Laurent Dufour
2020-09-14 17:15   ` David Hildenbrand
2020-09-15  7:06     ` Laurent Dufour
2020-09-14 16:50 ` [PATCH v2 3/3] mm: don't panic when links can't be created in sysfs Laurent Dufour
2020-09-15  7:23   ` David Hildenbrand
2020-09-15  7:24     ` Laurent Dufour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bac8037f-70f6-e7e5-7982-cbfcfef45e01@linux.ibm.com \
    --to=ldufour@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cheloha@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=nathanl@linux.ibm.com \
    --cc=osalvador@suse.de \
    --cc=rafael@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox