From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC5DC54EBC for ; Tue, 10 Jan 2023 10:05:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C03108E0002; Tue, 10 Jan 2023 05:05:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8BC98E0001; Tue, 10 Jan 2023 05:05:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A05F38E0002; Tue, 10 Jan 2023 05:05:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8BCC78E0001 for ; Tue, 10 Jan 2023 05:05:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 612DF80DAC for ; Tue, 10 Jan 2023 10:05:46 +0000 (UTC) X-FDA: 80338457892.27.BE2ED7B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 62EDE1A0010 for ; Tue, 10 Jan 2023 10:05:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GSrgvO9o; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673345143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pQos0rL6v0IJhlQcBZMrcxW60aPh1eJ2JqufvK5QrGs=; b=R7BEd1K+k7X6RvjV8GgMF3ltyWon+/I99PxJ4GleubxryQNsUD9gQFAjf2x1BclqxLotFt YF7bpErnOroNXBQoopUEWID+zf+5l4dVi6HrNUGIYARpHDXNmEgGdGMiegDMzcKi5dA8uH nlym7MGiU9T627Y85IzjJwtQefXAmj0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GSrgvO9o; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673345143; a=rsa-sha256; cv=none; b=YStU5aVp7yqTNw85HUMpmKYIjLDe/QbAe53BsTNdD5+0+LXqwQZpaLeW5gcFsZUJ9mUYA4 iZQXubiLAGr3mlYWkFMIz3kfyFscLGHSamlT2EUsnP8Mm/C3J/u5O/0Ze97jUvo2jwCEcr gsNiFZtByqKvpJMWWp+P0QzLtzeUf/I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673345142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQos0rL6v0IJhlQcBZMrcxW60aPh1eJ2JqufvK5QrGs=; b=GSrgvO9ofcKnCj6ymkM+QUYyL8oyM1HdezXXINbjkj7WlTxMn9u1LezadMen15GQMHQoYl Qsj2wQLtI5usO8YrUDDf0G8ignQ68/tBNsxza5loLSBOuw556SDh9JbG9yJ/+7TTRDxVF1 99PxFUCvqqj8nW31gcuBrTxwOp8UYIc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-137-O0ngAmozN86VaZ3ghZuLHg-1; Tue, 10 Jan 2023 05:05:41 -0500 X-MC-Unique: O0ngAmozN86VaZ3ghZuLHg-1 Received: by mail-wm1-f70.google.com with SMTP id fm25-20020a05600c0c1900b003d9702a11e5so6125007wmb.0 for ; Tue, 10 Jan 2023 02:05:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pQos0rL6v0IJhlQcBZMrcxW60aPh1eJ2JqufvK5QrGs=; b=SVRPUuXNk5C67b8MqZgn5KMSwZST8sdRXp4L9DCG7NYoq49Lql1/PlF95uE12NyOtk EDAs3P9Z88ixeFBq/8TkU5m1PIIBnl4Za7Iyg3TkIoiEld1mWMljrs/sT9LW45Fv/VUR djWLC+Zsht9t4bbvQOf8oObhsYlzCly1pWdcr+Kkz6t9p3PsFG0ngQ4ngUrOot3G0Nrg OkrnP8Tx6ivafbol92sAikIr7zU0M4FLYSny1TAjUnxu2gMMOFCdnRE4iIlY04N/yeOO 8ZvXVaeQCzcd0HTbXAleqhIv/3M8TF7kNT11k4V91UDcj+hKBgLNVtxzh7QKAPv9TAKQ F1yw== X-Gm-Message-State: AFqh2koy54TCDYWFKTfq2Y8DFNrnKZSSqNwBRNfT9aVhM4dtb6uSQ+jO yr2WFcII5bcxzlP2BLvc0LOg+umabSFmSSd2D2mGtwlE1l4lwPWFmAL32Lcefy9ahViJWx/u6pE UzAhNiPbQHvQ= X-Received: by 2002:a05:600c:3d8a:b0:3d3:4406:8a37 with SMTP id bi10-20020a05600c3d8a00b003d344068a37mr48796534wmb.41.1673345140647; Tue, 10 Jan 2023 02:05:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXsFgWkzbQ2X01cVjAwNnoWvoKKf9DNAG5yZ3Ygp1x3LFRmRcYVTqXVI6DFXgV0rPJV/rKWJYA== X-Received: by 2002:a05:600c:3d8a:b0:3d3:4406:8a37 with SMTP id bi10-20020a05600c3d8a00b003d344068a37mr48796515wmb.41.1673345140308; Tue, 10 Jan 2023 02:05:40 -0800 (PST) Received: from ?IPV6:2003:cb:c708:4200:65d9:4d0d:bb61:14c8? (p200300cbc708420065d94d0dbb6114c8.dip0.t-ipconnect.de. [2003:cb:c708:4200:65d9:4d0d:bb61:14c8]) by smtp.gmail.com with ESMTPSA id bg42-20020a05600c3caa00b003b4cba4ef71sm21771935wmb.41.2023.01.10.02.05.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 02:05:39 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 11:05:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Mirsad Goran Todorovac , linux-mm@kvack.org Cc: Andrew Morton , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <0f117203-3227-cd16-61c2-2dd3de75ecc7@alu.unizg.hr> <0ee389dc-5e47-5b7e-4db5-637eb2b3fbc9@redhat.com> <0e692e52-0a4f-3892-ed25-f3fa12892b6f@alu.unizg.hr> From: David Hildenbrand Organization: Red Hat Subject: =?UTF-8?Q?Re=3a_PROBLEM=3a_selftest/vm/cow=2ec_failed_to_compile_?= =?UTF-8?B?KOKAmE1BRFZfUEFHRU9VVOKAmSB1bmRlY2xhcmVkKQ==?= In-Reply-To: <0e692e52-0a4f-3892-ed25-f3fa12892b6f@alu.unizg.hr> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 62EDE1A0010 X-Stat-Signature: pd7iurnf9o3cazm85si1eyg9fu7sggen X-HE-Tag: 1673345143-572656 X-HE-Meta: U2FsdGVkX1/a1PU8/5GXiM47RCiKBN/E8A38dt+MiU4YO48F6+GUA4HQ8vpcP8muDVhjs4FdnRSTxm2d3pc5ZiOsFu7kZ73GVl5U8k88N+89VgXkRz86Qb59zl+qksh3I249GiWFh6/nOsebq86Scc2c92E0rBjtTTEbhrfQYkcq6WpeyNrN8gDRiPVYdpBNBnsgQvczpTHPCgl7v2oKnhJ/v6l4mAkZzyCrHef0nMQfGWWCu7eyC19OSaufLMj6LpbAJAKdfwbVM2qma4zAohNA5qrBu6AZpQrSQmNcKK4oFTKudFdqA+qXyZYc8rl9vOQAzgPVz/80swDJFf5qFgOdTXPd8vnURzrXKo2/wBuKZ7se+R0WXFGnIMIfb/thiFl8bHuJA9iPnO/v+1Fd1mnzxEk58LTfccP3VK/6wE+vEFQqX1+0gdlMQwk0H937GYhRzoKFqODmZKe6Q23GlK1SBlvyZBpGnIGyMeiZMnn2+XH02Y6hR4QS8yDN7TySZ1/NSX1M6qInuG4YiiYiQp2r2W03AeQMhlcp+C9yQiDyiwfiz7OHvUAa81uDvQJfBKbY/pHOZ0vvLhl0WkPZYaep48UYKYwHMKbs2xcsxSjdo+16/gNrRiy9ZTNX0Z5UfE9eixiLZ0CNTpkmGKBRF4vY4iei1ghq83MXzx8vQak3OlDCOwkg95H+VJq0jQONCuo1I8kWcfLQ1f6C2RQhb9dyG/RT5F1wGY7wq3JDuTsIK57dhmaAI8Mxyx0dMbvjIt4NKKJ5VGPh1Eths80BQLS/dRwFGvHnPCevGx6MkypmwJGf6S8smxtPmpOmv8bXncYngAOplC8bZz6IsBngDuCH7JOBqpTWDD5ecNaqmIrWb/hYlzMpYwHicL82WTRuICo+GjPkDbmY0Wv2R1qd6EiyrePywz3RdGnFObBbaXa3uRvfErByO8yhKLWWBsY1exWjy9tk1dUhRR/a67X S7342QC/ 6NGy8jwnfCc+pIJmveYyo97vbhGTBVsz7EFlR+tR8T9iPPBF5xPFSC8sEYWzz4NxPn3OFfI0ySk0AfSq2ggjjkER2Me0ZOXF9Wd8NzNhYJJ4UHjOeijS77oFIu16IxQn8tB5aO2tIogOi0peQQTvmRHRbvhlkcvW/WRIl/gUMWtlsekGabaLLglT9DP5tU3+dVTi6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.01.23 22:41, Mirsad Goran Todorovac wrote: > On 1/9/2023 5:42 PM, David Hildenbrand wrote: > > Hi, thank you for your reply. > >>> I hope this is enough information for you to debug the issue. >>> >>> I am standing by for any additional diagnostics needed. >> >> Won't userfaultfd.c fail in a similar way? >> >> Anyhow, khugepaged.c jas >> >> #ifndef MADV_PAGEOUT >> #define MADV_PAGEOUT 21 >> #endif >> >> So most probably we should do the same. > > Actually, David, it turned out that userfaultfd.c compiled > out-of-the-box, and side-by-side comparison showed that it also included > "/home/marvin/linux/kernel/linux_torvalds/usr/include/asm-generic/mman-common.h" > > The only remaining difference was including , which fixed > the issue w/o #ifdef ... #endif > > Hope this helps. > > Please find the following diff. > > Regards, > Mirsad > > ------------------------------------------------------------------------------ > diff --git a/tools/testing/selftests/vm/cow.c > b/tools/testing/selftests/vm/cow.c > index 26f6ea3079e2..dd8cf12c6776 100644 > --- a/tools/testing/selftests/vm/cow.c > +++ b/tools/testing/selftests/vm/cow.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > I already sent a different fix [1]. I suspect when including linux/mman.h, it would still be problematic with older kernel headers that lack MADV_PAGEOUT (< v5.4). But yeah, I saw that userfaultfd.c was fixed that way: commit b773827e361952b3f53ac6fa4c4e39ccd632102e Author: Chengming Zhou Date: Fri Mar 4 20:29:04 2022 -0800 kselftest/vm: fix tests build with old libc The error message when I build vm tests on debian10 (GLIBC 2.28): userfaultfd.c: In function `userfaultfd_pagemap_test': userfaultfd.c:1393:37: error: `MADV_PAGEOUT' undeclared (first use in this function); did you mean `MADV_RANDOM'? if (madvise(area_dst, test_pgsize, MADV_PAGEOUT)) ^~~~~~~~~~~~ MADV_RANDOM This patch includes these newer definitions from UAPI linux/mman.h, is useful to fix tests build on systems without these definitions in glibc sys/mman.h. [1] https://lkml.kernel.org/r/20230109171255.488749-1-david@redhat.com -- Thanks, David / dhildenb