From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A242C32771 for ; Mon, 26 Sep 2022 08:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80B998E0032; Mon, 26 Sep 2022 04:47:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BA448E0007; Mon, 26 Sep 2022 04:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65B158E0032; Mon, 26 Sep 2022 04:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 53A6A8E0007 for ; Mon, 26 Sep 2022 04:47:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2203E1405B9 for ; Mon, 26 Sep 2022 08:47:37 +0000 (UTC) X-FDA: 79953608154.01.3CEED7A Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf21.hostedemail.com (Postfix) with ESMTP id 950C91C000E for ; Mon, 26 Sep 2022 08:47:36 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id v1so5589630plo.9 for ; Mon, 26 Sep 2022 01:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=zx7C8hUC8uJlj/LCHHs+NE++TUFzrNQZEMGrjupRGvk=; b=cJO0Q8RYU1eD67h2oj6HcH/iziJoZ6USpaIH1IiQarytU6idHx8j/Omw8bQrsm5er4 5LWNuQ4Fiqi6ndRYsjqBT6JDrSW/nEcID5oRXSuD9OGqpbrB6RqfiDnF6ocf5XBNlbRT 0ah+BisXy/oF+XVBCUdMfh68Acus18622T4d29MAgJ8fMVYAGpDWqIcl8xLo4FG3ZqQX /oaWtzcOuvIfljt6cTUsAdaQt6rfCMIdDCOcCmYhc4ytYm89EB1JnqPsRVDt+XcLLqwp ILBRTWUu+7QO/NyXOQ/bQmd4jpJB1TjisGWrJpYl1P4PLAR9tRMdfXN+CCJCly7aL/M7 G8gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=zx7C8hUC8uJlj/LCHHs+NE++TUFzrNQZEMGrjupRGvk=; b=O3Ha2x0KxAa4ezQ4LnpHK3Umm7BW/Gpuh3dBLJh/VEvs9bmp20SMjyHT+JBhlbM/z5 kk2TxamxRuoywuMsHVBnZatPAW393WNCqnt4xC17fkHvnudktN5kPTMRqzVWyQCDUdob owd6VORqLSPIcGOImHkIi4V9EdS0h9gw/9Sv4TgdeRP4bFXYIao86n2Fvit5r9fTXPcx 3O+HRaIqXbfzZmgF8/OkXUBuvNpznCu/raw6DkZWFWtagUzOKQq4cQhhALYdeuO/UEe9 sSdUiAz1eYkhbyuwa8ucO3p/VWaqRIMp9Jv+Cbm8bf4zlKEhvC7+PzW/lefUgGDAU4YC ybLQ== X-Gm-Message-State: ACrzQf1o+TFhrwOhdylzcSxnSZnX6ajm0cIJO4ZnEjomXJnnVqzEan+2 QJz81OO51zAyFRfNdFUwIyZN3A== X-Google-Smtp-Source: AMsMyM7q6yEkCdIIC7b0tutmfQi6J1GkVgDmKCmJjgiElePNYFll1wJn3zl4t0bPWSzziqcFHM9tJA== X-Received: by 2002:a17:903:230b:b0:177:e667:7862 with SMTP id d11-20020a170903230b00b00177e6677862mr21151572plh.154.1664182055627; Mon, 26 Sep 2022 01:47:35 -0700 (PDT) Received: from [10.255.6.155] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id a8-20020a170902900800b00178acc7ef16sm10665577plp.253.2022.09.26.01.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:47:34 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 16:47:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] mm: fix misuse of update_mmu_cache() in do_anonymous_page() Content-Language: en-US To: David Hildenbrand , Muchun Song Cc: Andrew Morton , Linux MM , linux-kernel@vger.kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn References: <20220924053239.91661-1-zhengqi.arch@bytedance.com> <3A09E40A-E2C5-4C6F-8550-DD0E17B7DAB9@linux.dev> <48590f80-fc58-bf67-5acf-082880a607b2@redhat.com> <1a69af58-b9d2-6319-9db7-f92428b87612@redhat.com> From: Qi Zheng In-Reply-To: <1a69af58-b9d2-6319-9db7-f92428b87612@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=cJO0Q8RY; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664182056; a=rsa-sha256; cv=none; b=F932BWrMZlz4HsHtcoK3cpYjkgbL37gGFiISimzffzf6eMlJMzEiCYEBg3lbTZ8QeWcaDg 3HBUSvkANoT0Gqha3jikD8/3o77zJYe0c0BegzV1XDR6u6ZRuLyk184r4DN3sa+HOYG+Zj 7JijVZP6HW8s1q1mo6z9sIWPTWV2Y4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664182056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zx7C8hUC8uJlj/LCHHs+NE++TUFzrNQZEMGrjupRGvk=; b=6zQl8KcMYJyoEcoA4QWcIrK681jg8sNZYT4zyHeaTYgQkeY8FIHb736+VGXJ8Pz/gJcPtV JAw8FN9SP6ViYyTaidUWq2VO8s00o2HatlUUrg8TwVNGTirLUM0u81eATm7UwOx6YnfcgO POxNgfqOZnZWDPr/ZPTQDYdROBtYVqg= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 950C91C000E X-Stat-Signature: 936nj3kygeuz8dwr7qi6dj43es39omiy Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=cJO0Q8RY; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com X-HE-Tag: 1664182056-704270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/26 16:42, David Hildenbrand wrote: > On 26.09.22 10:41, Qi Zheng wrote: >> >> >> On 2022/9/26 16:32, David Hildenbrand wrote: >>> On 25.09.22 03:43, Muchun Song wrote: >>>> >>>> >>>>> On Sep 24, 2022, at 13:32, Qi Zheng >>>>> wrote: >>>>> >>>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>>>> if PTE entry exists") said, we should update local TLB only on the >>>>> second thread. So fix the misuse of update_mmu_cache() by using >>>>> update_mmu_tlb() in the do_anonymous_page(). >>>>> >>>>> Signed-off-by: Qi Zheng >>>> >>>> The change looks good to me. However, I am not sure what is the >>>> user-visible >>>> effect to xtensa users. So Cc xtensa’s maintainer and the author of >>>> 7df676974359 >>>> to double check this. >>> >>> And if there is one, do we have a fixes tag? >> >> IIUC, there's only a performance difference here, so maybe there's no >> need to add the fixes tag? > > Maybe be careful with the usage of "fix" in subject/description then and > point that out in the description :) Ah, will change subject/description in the v2, thanks. :) > -- Thanks, Qi