From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BB51C02180 for ; Wed, 15 Jan 2025 19:39:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCEDC6B007B; Wed, 15 Jan 2025 14:39:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7E5E6B0082; Wed, 15 Jan 2025 14:39:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45BD6B0085; Wed, 15 Jan 2025 14:39:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 866DA6B007B for ; Wed, 15 Jan 2025 14:39:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 085DA1601A9 for ; Wed, 15 Jan 2025 19:39:04 +0000 (UTC) X-FDA: 83010699408.14.802D544 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf22.hostedemail.com (Postfix) with ESMTP id F1C1FC0002 for ; Wed, 15 Jan 2025 19:39:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e6J/fpgg"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736969942; a=rsa-sha256; cv=none; b=5jMf3Lqcot4yLMgJgaYS84FNXba5GsMr+p0Sl9V2JSjHUDDq9jsNlDhR8JiOoGMz/f9udB 5lu3CLPo14PS+6HdwAv+VljkTJaYu997pNPgWtjbwQ5FaNWWrtL1kDqDrIg19jZ/nPq4rs 16NFLgJtJioxdt+QojzazbMB0fXtrA8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e6J/fpgg"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736969942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YT8LeYyl1IQE2OMUqDpDp3mQmKP3ywSVwhJGc5iz/kw=; b=Wf/vUUYX58h/kJSsvMb7KYLWJQnzrPSTSwD+hs5dLjuG7jSbrcFVwahqzMkpfwB7F3YwqJ Rk9nl/21CMoDA2egg3evZ1UvtQkdU+QTihQBCCA3yeljd4jYBbUWu+xDghRLwDQQgU4yVL B0OVL6gR/oVQakQyvHLp1wPpfxs6YwI= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2164b1f05caso737235ad.3 for ; Wed, 15 Jan 2025 11:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736969940; x=1737574740; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=YT8LeYyl1IQE2OMUqDpDp3mQmKP3ywSVwhJGc5iz/kw=; b=e6J/fpggU3mK3Vi4JcUI8O32QBYRaX3ODgvbtST86InNCHL4PFJDF/Il6sc5rMP1fI 8P/jGfC0TqvwSl1/C1RJRGlk0DJeFypcQArmFxH/6jk30vOjLHFRUKOfGx/4cfRxdgUo qkgEAzSGxef1Sul3AMu9zcabqi1qCLVRHtOz6udg7T80nM17W6AR9FwryQYI2Kg11mBT escbzMFlrxvkV1f0VdidECFpA7/Cua9DtbFMaFbMBfaiAJe3VO9XnmyiJOyrHYtGzy7j j914wiiJ2RT5axZ6NtQC8vtKuTwIolB6o7hXiyZ5CE58OjygUu2016wB2RMfFRuguZg8 5QMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736969940; x=1737574740; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YT8LeYyl1IQE2OMUqDpDp3mQmKP3ywSVwhJGc5iz/kw=; b=l5LgkBWttDFYnzMsauADY1OB4SLAJEI/t1RwkYPJB7lZ8pTScBqAMDvipcrUxPSP8W w2r845OSxu30IWGtmZW64llVWFdCpqLC3QWJUNk4Z2Pq4//vmIAHCmU0wJzyblx9gBju o7nv6dRNkZQLdqD2bod3omeo7s7x0rRnIj7zf3fjBq6cYaIvSd1Do3zYkZYvxvjigF99 n4Bo82oVYD7+JoWTexqAzV0x28c995oKHXemyzmx87nl2EeF1fvlCpO1qlXsc7C5B1bG cZlbaP20Q6xqZTTxCCI8soyBgmBu+sX08N+HAMNp6bK5J/L/nq+4O/XFhi6ud5Il67SF 5AYA== X-Forwarded-Encrypted: i=1; AJvYcCW/Elbjy/VXCYUdEfyaM34kQ/v3sbkVMhEVSH6ZbkqGPcAvrzphExi2jOofrdby5xkFxvLgA80uAA==@kvack.org X-Gm-Message-State: AOJu0YyveuU+BlzPhPn9Fqi620E0Y5BqsfgO4GchHY6gKZbHvAYe65pA 5hfDeKUidFS/Jatr/vxmCz3lCNKqLaA9dsGdJsZvyQoX06n/VIn9 X-Gm-Gg: ASbGnct8yqz6EHuwCf631jDJaf5nBT9sn34Q1kh1Bs4+4ooGa+zpA3xPtZRCxu1AipZ RH7RGp1xqWTbH8+yKsJyzPnjukX2YyTZgsqFZ8PZ/5NT+Tl4eDuVSakLbgwP96MndshrLzWQWmv 23EvIDs3yoe1K3Naw5lEnNN1RJ3dqr0JvoXTNNwjo9XbsgswdicCWdeQ8SPt1zTrDIWp/U/uJXe LmmrShZ2aaUJlEu2ale/dGQXKr3zrEMabk19Zl4RttT2YNadOoWYy8NltlLBsRtmBrpd3nGgFt0 B2Y7hLURKRE3lA== X-Google-Smtp-Source: AGHT+IFOKfNEni4cheEMDE4joOYaQXJ/C8N6Te9Lc9LoIuJOxFACSRD2Iq8Srr936C5fgptM1H/zEQ== X-Received: by 2002:a17:903:1112:b0:216:138a:5956 with SMTP id d9443c01a7336-21a83f59822mr478521225ad.19.1736969940495; Wed, 15 Jan 2025 11:39:00 -0800 (PST) Received: from ?IPV6:2a03:83e0:1151:15:dc0e:edda:f2ff:379a? ([2620:10d:c090:500::7:7294]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21aba7sm87093735ad.113.2025.01.15.11.38.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 11:38:59 -0800 (PST) Message-ID: Date: Wed, 15 Jan 2025 11:38:57 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: JP Kobryn Subject: Re: [PATCH 0/9 RFC] cgroup: separate rstat trees To: Yosry Ahmed Cc: Shakeel Butt , =?UTF-8?Q?Michal_Koutn=C3=BD?= , hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Tejun Heo References: <20241224011402.134009-1-inwardvessel@gmail.com> <3wew3ngaqq7cjqphpqltbq77de5rmqviolyqphneer4pfzu5h5@4ucytmd6rpfa> <3348742b-4e49-44c1-b447-b21553ff704a@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: F1C1FC0002 X-Rspamd-Server: rspam10 X-Stat-Signature: 8rrbepdu8jetyacifnnd3d96nuhroa9i X-HE-Tag: 1736969941-799478 X-HE-Meta: U2FsdGVkX19TMtyrTvgThkO1k8KshIsK90yTYrDerAJeQLjXO4taAppbqCzsBqoqOlk/Q1NB5E22JtssPw5/TKRE6lJy14oI2WvrQQnMpokEi5kJzeW2JOfE25hTurebpBheoItAYfsqdvMC9oABMzw+VCPCR46xbX8Ml1WIr94wGeTvYqCAnjF3qgvas107iziYDMwe77icEO3T8JJzNlo4MezelYlc6f7mGsUEffekn8XRsX6ii+1xwi4An+J/5D0NRsb20LuBORljO4vOfHro2O0Dt86hARMiposHTvQexT8spSvuw4xZVb9OajRrSCwmRQBUS0wzIyavk/E22eAhnT871JG60iejoRq6rYYm1oE6y/bmzKzCv0qI3PqrRFa5oQmzaBbccODzUywyO7c+AtS4EoX8CuEx6uWD/burpKttMHFwOHbl4s+em7cp8e4hyHUsMzbrefYAAnhs3VrG6h29XipUr7p07GCWRxl8s8GGeQ0zEJReUG+g73Z0k7+vIpwPGJxpxld1hztXpQhcAt6LWYtAxELG+/zlzjHu4z+DPJ51FEBhBITZm8BzWqAoDc7hbSqqAKKHwQbNOCOenc6TLe3rqiebVv5aaEDU7PYtEDSCLcPHz3wohHfgmhsV4IcFUQGJ+eCxZzqLF/tTZ852gIHj6UVHwwQL/j74veoxq60TEKnAMNeDMSviN9Q5sKmmwyy440X5dMgcCBaqA+xbvHK5/b60gbxD0JqFQIgf+vQ0kAE4KW3tFcqnPulFNehkSgQE7MsZktpeRVbUDXkeL56qBGy1eMMzibelcY01/oDYSAQUzDgkZm73NHswyQSHigR1mZuTgvipn6tilirbu2Y6tP3iF63DflEYF2Y0p/0gBxDcW2ulEi2wLolsWjwHKL774SKHagV0OFrSNOk6ltp2m+1o3vDaMyhuAYWQaUcz55mJIcMfiD0Ui0ymR08ccP4SyadYmTV jYjc8rK1 HwxBEyJ4ON3D2FNbbhbrMQ2cpzJNT+BuoFGeI5F8xgPibQklN2xFmELPOh3tNeZgTQ4k12JzYyiIIBmc//93dBaZDpugR9Q5azNVEbL8suA4oUu9bWiFSRUn7astN3oal7GzwRpFtQ9LcXrHL6q3c7kOVpsxd76a50VRV7PuujmvpUGVNKMODwZgD92l7WvrC2Ad40oDNRZkkvzhwp1i2Sj6PRcct2fWnf4Y7vgHGPo3tsIHCHnSpptKFNXOHHVap/mXdD7jez4f7Xi2FT7hb0Dch460DYtzYvrkDineFDBj/r92x600xeXaqM+qZAqZ0Rp8d1nNjl7Em0WpqlU4Wl0OW1bSjbtktAWwXbxeYsBeMEF19j6iHeNKOwLMMQHbRRKV9+vTupmCKVP0N1e83VKZzBnKBNRdmqdP/adtt50WYfNBrtpXdshYWoYxP0vcMLoW9TqUPMfS/b00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000072, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yosry, On 1/14/25 5:39 PM, Yosry Ahmed wrote: > On Tue, Jan 14, 2025 at 5:33 PM JP Kobryn wrote: >> >> Hi Michal, >> >> On 1/13/25 10:25 AM, Shakeel Butt wrote: >>> On Wed, Jan 08, 2025 at 07:16:47PM +0100, Michal Koutný wrote: >>>> Hello JP. >>>> >>>> On Mon, Dec 23, 2024 at 05:13:53PM -0800, JP Kobryn wrote: >>>>> I've been experimenting with these changes to allow for separate >>>>> updating/flushing of cgroup stats per-subsystem. >>>> >>>> Nice. >>>> >>>>> I reached a point where this started to feel stable in my local testing, so I >>>>> wanted to share and get feedback on this approach. >>>> >>>> The split is not straight-forwardly an improvement -- >>> >>> The major improvement in my opinion is the performance isolation for >>> stats readers i.e. cpu stats readers do not need to flush memory stats. >>> >>>> there's at least >>>> higher memory footprint >>> >>> Yes this is indeed the case and JP, can you please give a ballmark on >>> the memory overhead? >> >> Yes, the trade-off is using more memory to allow for separate trees. >> With these patches the changes in allocated memory for the >> cgroup_rstat_cpu instances and their associated locks are: >> static >> reduced by 58% >> dynamic >> increased by 344% >> >> The threefold increase on the dynamic side is attributed to now having 3 >> rstat trees per cgroup (1 for base stats, 1 for memory, 1 for io), >> instead of originally just 1. The number will change if more subsystems >> start or stop using rstat in the future. Feel free to let me know if you >> would like to see the detailed breakdown of these values. > > What is the absolute per-CPU memory usage? This is what I calculate as the combined per-cpu usage. before: one cgroup_rstat_cpu instance for every cgroup sizeof(cgroup_rstat_cpu) * nr_cgroups after: three cgroup_rstat_cpu instances for every cgroup + updater lock for every subsystem plus one for base stats sizeof(cgroup_rstat_cpu) * 3 * nr_cgroups + sizeof(spinlock_t) * (CGROUP_SUBSYS_COUNT + 1) Note that "every cgroup" includes the root cgroup. Also, 3 represents the number of current rstat clients: base stats, memory, and io (assuming all enabled). As I'm writing this, I realize I might need to include the bpf cgroups as a fourth client and include this in my testing.