From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7C7C433EF for ; Tue, 14 Sep 2021 10:01:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2C2360F8F for ; Tue, 14 Sep 2021 10:01:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2C2360F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 65B0A6B006C; Tue, 14 Sep 2021 06:01:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 609D4900002; Tue, 14 Sep 2021 06:01:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D1926B0072; Tue, 14 Sep 2021 06:01:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 3B7D36B006C for ; Tue, 14 Sep 2021 06:01:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E4FE782499B9 for ; Tue, 14 Sep 2021 10:01:45 +0000 (UTC) X-FDA: 78585737370.20.5CA7AEA Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 510D11905 for ; Tue, 14 Sep 2021 10:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=ImRIPihhAObidTCiJqcnR+Z8IfwFSS7GltQDYdsx+N8=; b=s9EIcM218cXLgAcVF x2igWWw+5J2ksbdHAJ76DZGcs4PAzMOI4aqrBzYOgTroR3W22sFgMdz6nr8qWJSgZEgjefXl12Zfz 5Rzt4hTINk5F9djLHnQdmuhAnpSxGuDgQmwNgTfiMHgIIord/XMaxAN3OiEGHEcr2V+NjawPY02l0 =; Received: from [10.93.0.56] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1mQ5G0-001w0o-Uf; Tue, 14 Sep 2021 13:01:40 +0300 Subject: Re: [PATCH memcg] memcg: prohibit unconditional exceeding the limit of dying tasks To: Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Tetsuo Handa , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5b06a490-55bc-a6a0-6c85-690254f86fad@virtuozzo.com> <7af26106-388c-6f99-e018-669a8f0cf9b5@virtuozzo.com> From: Vasily Averin Message-ID: Date: Tue, 14 Sep 2021 13:01:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 510D11905 X-Stat-Signature: qcfips4b363op94ct54cjqkyejk8m11z Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=virtuozzo.com header.s=relay header.b=s9EIcM21; spf=pass (imf22.hostedemail.com: domain of vvs@virtuozzo.com designates 185.231.240.75 as permitted sender) smtp.mailfrom=vvs@virtuozzo.com; dmarc=pass (policy=quarantine) header.from=virtuozzo.com X-HE-Tag: 1631613705-302387 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/13/21 1:55 PM, Michal Hocko wrote: > Here is what I would do. Your patch fixes the problem, I just want to add rename of should_force_charge() helper to task_is_dying() and will submit v2 version soon. I think this patch is not optimal, however its improvements can be discussed later. Thank you, Vasily Averin