From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841D8C001DC for ; Thu, 27 Jul 2023 08:30:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20154900006; Thu, 27 Jul 2023 04:30:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18B0F8D0001; Thu, 27 Jul 2023 04:30:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05266900006; Thu, 27 Jul 2023 04:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E65448D0001 for ; Thu, 27 Jul 2023 04:30:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A4266121055 for ; Thu, 27 Jul 2023 08:30:10 +0000 (UTC) X-FDA: 81056719380.13.09D9ED0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 8901918001A for ; Thu, 27 Jul 2023 08:30:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tr4M7HQ3; spf=pass (imf16.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690446608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCyRY2AypM6cafCQjVrDjLb4nbis8pECb0YQZp2M6iE=; b=rFo8qvRwr8vyHQknzkUGNLkJ+ZJmGgrE/3j1nyB4r0e8xaxlfxPXHYWwXIs6HzLvhDuddO rOWWlBoqmTBNkXap68NKkLFyBv2n8zMPCEM4sjynQuzX+/Bbufv0Zf6vgySbw4M0ATkS01 9kLVEzMqYjjKPIZQySm8l6abAi3mnTQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690446608; a=rsa-sha256; cv=none; b=CUgxceuIhUp6BAAOBiRSUfJYy2wF/8/2DNHCwsDj/bVy+smOAW4dqernbBpz/a5VJNMnmN 16hMbR/OP4CKwr20E2Nmv43pD2rGvKyjW+Zzft87yaCJfegLQr9mBKYWk9lj4znfCtLBZD tc3/o21kzWzBDxN+FTA3Y2NLMaSI+DM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Tr4M7HQ3; spf=pass (imf16.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6549661D96; Thu, 27 Jul 2023 08:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06711C433C7; Thu, 27 Jul 2023 08:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690446606; bh=lgMwb11ItIJ27YCsuj2akQ0e0AMgpISaoiuOUrGiITY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Tr4M7HQ3pxhso0Q/eg4xKtwD0lUURtq4zUL2WnDxbX7YJArr/oNtVx0HKmYWbVJCj uZ3CjjOq76HigUmfxsBIfU5BJp2UCC8gXysiCMyY4oUiNa0NyuYtXgOb+GgYI2e2UD q/DMid3QMY2nJGias56vfjnyYrQ2kAGyvOg7az/lKKcQPYsllW1cAnQl1FfA/ktsaA ypQoOxGNqaMUpP2GFbXa8+1QKt5gSsrAShH7O9rxadTFuFxweU5IvbZDayprJj2afQ IGlbjA9TtQP0FcoHyTXu4yjcQ81VS0g2mOFp+HrXHsn6/kAwTiNlXyj4HVftm6tXbg kxbv5Cd7EwHzQ== Message-ID: Date: Thu, 27 Jul 2023 17:30:01 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker Content-Language: en-US To: Qi Zheng , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-29-zhengqi.arch@bytedance.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230727080502.77895-29-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8901918001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 4e9qaamtjrmgoyawww8gpbrk6ajjmbpd X-HE-Tag: 1690446608-951784 X-HE-Meta: U2FsdGVkX1+Ek/+l2ImG4DXFO2TvdSdZ0177oSHA8SWQrpx7B2QsEkZAbecECCjcE0FVGeJcUQx0RACEqfwH8vOulF2xQYO4K1iiiStMobBNswevNazj6y/wiva5g/AXjaoqgbgca/amFkkcRwBqsmlYluXNIj5N0sjuf4MycjM6Ugmj54a5aCeLYdIe3YrGiyt7Rm1t1Ad9s0iDEx/+p4MylDk3lXhSN30wjBdAkd4ghVBI2kDS6n6Fy43zlmlUHc2NEW1QEwB3cXOPtPZunQy2//5NPcAMZBn3PfeFm3CBG2XazWnzyRYHnd9/lEITqz8rMA9vfvpQ3vq9+p4WFRM+wrNZYf9vBy0QlUtg2KcO6CFp6actnRKHP3qXXf6mqlLZQnBp2KwM18jTLpBQg0NEuO6QXSMq/1/AFf4qmXtv7X6JkW4BF8t/l1Ac4rYfTTdIP6qvObzj9JjqfRrufRJP5D79tEEYUBbgY6NlOvHCI2Y1WEp2IrpVjQShEUzwbiLWmSGiTz6IdLFDDGxpxZq3wQVnQm4dkyKL0Nu6WslU49ujen9juSu5pVj8t3stLkEbeRkvHORcG3KsBjgTxKImkHEe/+6qdgHmZiYln+cjVR71g6/hmiTG33gHqfHZUtHW8cBr06eid3PXcNT0lFab3ed+H3h3aCmdQnEFrDHVwGCqNGuozI4ZNOeKENRK7eN95wke6tiJie00HDKuwodgvQqiLVmeGAX9lv6cJNOzbwuBZHcJNxNXH4A7JzCF3r0Wy6NMC6E8wUl6Aj4QJ4fw/7QlSuo1yVEYsGS5wm1DkqsXlnmFlwnv8HC2/tIN1glVw40qalLosarsXKyPW+8PB2SQiNpE6XVo1kSFSgobIATKZYClorJOzM6lyxG/k6+R6CupXDNsYHe+wHqtQ96WtmuBDVu+UZTL6d/y8l1x2BEoTzpHSXXVitfal/a1zze3JaHJti4TYlaBYsf 4fDJE0BB +1GR8knqS9O0Qb/8WZ56VxGrceGxckimEkcWfye6YzuwliOvj0QLGXBAC/ZvKTHGpK9KbECRpfIVeFn+m4QkjSPLnsKDz/dabWXD3EzswT/SR1JzpASA7PIvWT+mVXGEOVO7zLWz+vAWGZUmJmU2gQdricfA5uT7CC7jeZY5ec3m+AI0v7U7/wSycEfIq+RaqA5pTpPxEM+dmdTe2Cns3ygdGZQw2JI9+x5mHsowBZBqkGG8ZYORqioQqFMo/3GsuDeq9yOurfPcmVUSfb0lkWQIBWssJ9/XybzPZam3Xy71WUUUExFTEc6n6W57AhHTsVKYdwN49lJAwUDtLWmkkpsCN1BGDy+7qXCmYxl+x+CSEbazAS0w3e6rWR66oy+EpW25A1sR/jypv6pnG6VNOEUVqmbnTkJ9u6dV6rTmkPi3ko/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/27/23 17:04, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the dm-zoned-meta shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct dmz_metadata. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > drivers/md/dm-zoned-metadata.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c > index 9d3cca8e3dc9..0bcb26a43578 100644 > --- a/drivers/md/dm-zoned-metadata.c > +++ b/drivers/md/dm-zoned-metadata.c > @@ -187,7 +187,7 @@ struct dmz_metadata { > struct rb_root mblk_rbtree; > struct list_head mblk_lru_list; > struct list_head mblk_dirty_list; > - struct shrinker mblk_shrinker; > + struct shrinker *mblk_shrinker; > > /* Zone allocation management */ > struct mutex map_lock; > @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, > static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, > struct shrink_control *sc) > { > - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); > + struct dmz_metadata *zmd = shrink->private_data; > > return atomic_read(&zmd->nr_mblks); > } > @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, > static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, > struct shrink_control *sc) > { > - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); > + struct dmz_metadata *zmd = shrink->private_data; > unsigned long count; > > spin_lock(&zmd->mblk_lock); > @@ -2936,19 +2936,23 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, > */ > zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; > zmd->max_nr_mblks = zmd->min_nr_mblks + 512; > - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; > - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; > - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; > > /* Metadata cache shrinker */ > - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", > - MAJOR(dev->bdev->bd_dev), > - MINOR(dev->bdev->bd_dev)); > - if (ret) { > - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); > + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", > + MAJOR(dev->bdev->bd_dev), > + MINOR(dev->bdev->bd_dev)); > + if (!zmd->mblk_shrinker) { > + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); ret is not set here, so dmz_ctr_metadata() will return success. You need to add: ret = -ENOMEM; or something. > goto err; > } > > + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; > + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; > + zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; > + zmd->mblk_shrinker->private_data = zmd; > + > + shrinker_register(zmd->mblk_shrinker); I fail to see how this new shrinker API is better... Why isn't there a shrinker_alloc_and_register() function ? That would avoid adding all this code all over the place as the new API call would be very similar to the current shrinker_register() call with static allocation. > + > dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); > for (i = 0; i < zmd->nr_devs; i++) > dmz_print_dev(zmd, i); > @@ -2995,7 +2999,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, > */ > void dmz_dtr_metadata(struct dmz_metadata *zmd) > { > - unregister_shrinker(&zmd->mblk_shrinker); > + shrinker_free(zmd->mblk_shrinker); > dmz_cleanup_metadata(zmd); > kfree(zmd); > } -- Damien Le Moal Western Digital Research