From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381D7C433E0 for ; Wed, 3 Mar 2021 02:45:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73A5864E89 for ; Wed, 3 Mar 2021 02:45:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73A5864E89 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90C748D0118; Tue, 2 Mar 2021 21:45:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD8D8D00FA; Tue, 2 Mar 2021 21:45:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737118D0118; Tue, 2 Mar 2021 21:45:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 59AC18D00FA for ; Tue, 2 Mar 2021 21:45:19 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E7A6180E894C for ; Wed, 3 Mar 2021 02:45:19 +0000 (UTC) X-FDA: 77877021558.25.ACCCF84 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 9289DA0000FF for ; Wed, 3 Mar 2021 02:45:18 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id k22so13209102pll.6 for ; Tue, 02 Mar 2021 18:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cBrDyODWb9o0wKTGlYEQJLE0F3iUV2itXWKb5sgDsGI=; b=S32DEI3weYwTGnPZ8gv3lwj9JSyyd87UoScYSPpyk+56v3bzARJ7vegfvrF2nPoCfX 4JG5b1M4DIWdFv9pg/4biqSPRF07OXjCohzt+aVYyNM1poxiskVpkV5n6BzciRVZTXwZ FraJjTzMYwywR5pzTMOGqGIKmHgz8UA3+DQH3CCwRwHkDhbs+vuBeZ4bm653zyBNLcQM FYGah9blETvflovotwrZ7xPbEqmGvG7iFtPmkcFNaqUtZH+AO5/ppGzI7BNSh8qMuq09 Wj+yrIsLqAz9x5UiM/DO43tUdFHrbxNLCk3NL5on8iv+KIFocI/YMzpPuy2M8ye7rVSY U36A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cBrDyODWb9o0wKTGlYEQJLE0F3iUV2itXWKb5sgDsGI=; b=CkQm4KLN/APkPAzLlXRzwOOTtyyswVJiuZoItwcaV7mtA4PI920FxEj7PyAPVk85je R8eGvRs1clLPPVtsDjjZf//ekUzvQyBSCjDsUtRe7KgYJzni8MaKygKk1wOPbXjq/m/O xRuXt4J3M4475D2m5l80cHQL/sLvvfOxUUv9AFwJ45vzSJ2T1ZqMm8d7CeZIGmcSJzKS nwY71Va6wX9HTZ319UKR8zH8VMrG7ZLRvl4h07gRNcg/FEhrJ2ydZYKMeguIlJKyKiFs JKzZNwK94pJxtqSWgcayehpX+rvTY/cYF0LTxLvTwZajrBvNxn+R7m2iUuZuga4H54vx ZQlw== X-Gm-Message-State: AOAM532yQIt5Xf8Xq6Fb+BFzNiKUK9PjP26s9XIBruxMHvgkjo1KYLq5 GFDp15mL/2JbFzSisbsfOlo= X-Google-Smtp-Source: ABdhPJz3Uicrb5pArHjvcxNRuVPXM7eJzoN2OA3/o6bPFEi4LuHy3GR0zsFUa6l5BKwnTzQroYVhVA== X-Received: by 2002:a17:902:7597:b029:e4:156c:ba97 with SMTP id j23-20020a1709027597b02900e4156cba97mr6223687pll.63.1614739517398; Tue, 02 Mar 2021 18:45:17 -0800 (PST) Received: from f8ffc2228008.ant.amazon.com ([54.240.193.1]) by smtp.gmail.com with ESMTPSA id y15sm915385pgi.31.2021.03.02.18.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 18:45:14 -0800 (PST) Subject: Re: [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c To: Muchun Song , corbet@lwn.net, mike.kravetz@oracle.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, rdunlap@infradead.org, oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, almasrymina@google.com, rientjes@google.com, willy@infradead.org, osalvador@suse.de, mhocko@suse.com, song.bao.hua@hisilicon.com, david@redhat.com, naoya.horiguchi@nec.com, joao.m.martins@oracle.com Cc: duanxiongchun@bytedance.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Miaohe Lin References: <20210225132130.26451-1-songmuchun@bytedance.com> <20210225132130.26451-2-songmuchun@bytedance.com> From: "Singh, Balbir" Message-ID: Date: Wed, 3 Mar 2021 13:45:00 +1100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210225132130.26451-2-songmuchun@bytedance.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Stat-Signature: 36phrx91w8x78beuh5sas1gd6arshprg X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9289DA0000FF Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-pl1-f170.google.com; client-ip=209.85.214.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614739518-359700 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26/2/21 12:21 am, Muchun Song wrote: > Move bootmem info registration common API to individual bootmem_info.c. > And we will use {get,put}_page_bootmem() to initialize the page for the > vmemmap pages or free the vmemmap pages to buddy in the later patch. > So move them out of CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code > movement without any functional change. > > Signed-off-by: Muchun Song > Acked-by: Mike Kravetz > Reviewed-by: Oscar Salvador > Reviewed-by: David Hildenbrand > Reviewed-by: Miaohe Lin ... > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > new file mode 100644 > index 000000000000..fcab5a3f8cc0 > --- /dev/null > +++ b/mm/bootmem_info.c > @@ -0,0 +1,124 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * linux/mm/bootmem_info.c > + * > + * Copyright (C) Looks like incomplete Balbir Singh