From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3F7C3DA4A for ; Wed, 14 Aug 2024 21:10:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7D716B00BA; Wed, 14 Aug 2024 17:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2D8A6B00BB; Wed, 14 Aug 2024 17:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1BEC6B00BD; Wed, 14 Aug 2024 17:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A63326B00BA for ; Wed, 14 Aug 2024 17:10:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 646B7A117C for ; Wed, 14 Aug 2024 21:10:26 +0000 (UTC) X-FDA: 82452094452.29.FC145CD Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by imf14.hostedemail.com (Postfix) with ESMTP id A158D100008 for ; Wed, 14 Aug 2024 21:10:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b="Pxr28h/P"; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf14.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723669744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BUOPubvBNvWiovsd836uznv4khRkwVqGpe5OVPT0LDk=; b=cVdgibiK+mZOoL5OwEmioZAh82etOBV+Sq8Xu8PKGX7Ybuf9TiI9kTnqStr4Z4BRLJHnd4 gtWLQIzf/l03FW4Ol4G3XI3XWXg4t8igTttdV2HwIaqZ0Xdrqm4pCkjni/RiRGHaMLrO/1 T+dZIUlZMx//+7SS8aB3SvpBYCHsxB4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723669744; a=rsa-sha256; cv=none; b=v60XlX5MTDYNXDHgFuLdHs+iUQr6RMiSUFAPMLV6hMmkvtUa/ZDPp2njnauYGuThOt1pRi U91RjIsHKJFqKdXGhtUF8ELYwy4161QRYSVmElJJ08iEdBaOmSP2dc3EYB8evL6gy2zEx3 sdhzceA+P8Fb/sUMq5FAljtt4enaGVw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b="Pxr28h/P"; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf14.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1723669822; x=1723929022; bh=BUOPubvBNvWiovsd836uznv4khRkwVqGpe5OVPT0LDk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Pxr28h/P48Z7GbVpx1FH+zG9d1e2JToTdmQtRy103y9JnIzGnDZHnCAEeFlqGkAwA wotaHSeHwRWcvrKJPKmh/rYIRz4/DPAu6yig16iT1MEseRXszTJquArdFRGaVg4DrH BWOeFjVkJPxBwQhfhNIfWO6vZzS4g523YBn/Gyd0q2ZlOXV4uMxDGBrLqAd8xhMpR8 tcQY0Z+nX68hNajYmarAzyTQ+nd1/LZI6UJvriqIv5nDDEwoNPCwDbVnHwrapmpQZp mWQD5MSHVnEw3HXpF0zVKYtFc+AECMATlUnyvTKecoX0bnLQw3uubwWaD6HlojDJsl Odt6dH3y+9C2g== Date: Wed, 14 Aug 2024 21:10:19 +0000 To: Danilo Krummrich From: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: In-Reply-To: References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> <04b0fd96-c91c-4f38-90e9-8acee31e8445@proton.me> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 73eec96c4b72b2b0ae127de1c0a689aa229f6d5a MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A158D100008 X-Stat-Signature: deyt7j745fj9irr8xo3736a97wc71asr X-Rspam-User: X-HE-Tag: 1723669824-975093 X-HE-Meta: U2FsdGVkX1/viRjXA8KDMOo9gq6KGK3NHCroJu4bKpDFPW6MdvTheVXRXhuX7O+Z2TnEkYWw2YRhHO7Ju53HPoiL6rJxl3KGExO2TUQrDY4shAe3NzW0B4IB1V68u19WsscHJuW15/P+vZa1dAHd6iX+JkX2r27azJkldlMTW1Wl7X70elXmCfy3FA7EpaGjJrWZuPS63NjJJVi9u0FrS+V/OXUGgsZ3OOM2/F1+esKSvtdyWqq6G55fGplgS+yIPS0ftSMl8LBmVuZLggdpsRLu781648SYt5x99WOxLE10xhe4bKjfccPOnQyiyUpEaSAJAeIdsY3IgNG+JAEbhhy3hV0OwZheCobEcr2JyEI7LrQbspO8654A+3XpmejkK7v3gJLlm1ImSbyy+YexgAaceERDJ4N0JzOthIZgNJcnF2XroD4lQFNGDQY3ijjLS+GbeHqt9TyGWXcTnlAJJNMxmCSh4pdExkDWa77RDlk+GI/Rvvms4HYv8ZFZA9SWO02VN/LyCh8OTGK0Fpgfq8Bf4c6GBIcE8tvQHWw82KmEiFycIQuc7yxgDjTJXZJnq7XRSP7Z48tG6pVqbN+6XruJbWFs2gXi3V+TDqNox6qS8C9ncsXjwTJXjSExQHo88vHzveFh1yxkiEMRx62yAmqjxgcAxBsRo+szNP2Rsd2tBPBRSiyJLGRCQo067PkeLIVwDkuTqTR5ilgv+wm5YbSCSjwb73hnCgYfQrA8oPX0PC+IePo04vHqlNXRqjgqGjUcmm5hNlPMl/6ieFkIUVX87NuVUmit5iJx2QY6WA3eY8z5P3iprzu3/hceIzY1+OmXi4nqN/dILan0X+PmCYPROWrFXIZyiwz7oJf7+DB87hBaQXwYzVrXyWHgMHyphSV646LlTw1i+xJmNe9HO5XdVRmIzVuKO6u/3kglx0rFODyVCE35cdUUFzYI2ptkUHAoUBbQvBeXotr4eJf UGtinZI6 O34YNI7KT0zKkFq4aUhq492PI69W8/Lvov5rtkowWhkPQDJIIs4+5cKcw8DvZhpEhJjgyOGA/miYlA8giu24OZjg331T0pxAK3PSi703ezYDlvGQnaRuAsMa1uhij0N29pJbD6Vmlf25hLlJMUxffqS79vohPyxECkyxAGQFO0qO5w/GbpHq3hMb9yhxku1E+u3h9xH0JYKHuvOQd/o84c/R05JY7ZSM/7bxUeIH7jCM+CH5OSg0jEBMm9WK80pT946frVV9kDIsQFXDfbj8FvdzCpZst6YPWg5uBFmWn6/4G8jVxAeQ47+m/BIv/03iH/ToFikEc5pn1d8uZsfVdaj+X7uVpWuTqZto4LMa4PqSJsN8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.08.24 19:13, Danilo Krummrich wrote: > On Wed, Aug 14, 2024 at 04:28:04PM +0000, Benno Lossin wrote: >> On 12.08.24 20:22, Danilo Krummrich wrote: >>> +unsafe impl Allocator for Kmalloc { >> >> There is a missing SAFETY comment here (and also for Vmalloc, probably >> also for VKmalloc then). >=20 > Any suggestion on what to write here? >=20 > I'd probably come up with something like: >=20 > -- > Memory returned from `Kmalloc` remains valid until explicitly freed. >=20 > It is valid to pass any pointer to an allocated memory buffer obtained wi= th any > function of `Kmalloc` to any other function of `Kmalloc`. >=20 > If `Kmalloc::realloc` is called with a size of zero, the given memory > allocation, if any, is freed. >=20 > If `Kmalloc::realloc` is called with `None` it behaves like `Kmalloc::all= oc`, > i.e. a new memory allocation is created. > -- >=20 > and repeat that for `Vmalloc` and `KVmalloc`. >=20 > I'm not sure how useful that is though. Ideally you would write down how the guarantees are satisfied in addition to the invariants. But I guess this is only guaranteed by the `ReallocFunc::call`, since that handles the ZSTs... Maybe this is a bit excessive. If I come up with something better I will let you know. --- Cheers, Benno