From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA840C433EF for ; Mon, 7 Feb 2022 14:46:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14A636B007B; Mon, 7 Feb 2022 09:46:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D3416B007D; Mon, 7 Feb 2022 09:46:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67506B007E; Mon, 7 Feb 2022 09:46:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id D1CCA6B007B for ; Mon, 7 Feb 2022 09:46:35 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9406095298 for ; Mon, 7 Feb 2022 14:46:35 +0000 (UTC) X-FDA: 79116259950.16.5B68787 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 2698680007 for ; Mon, 7 Feb 2022 14:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644245194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q5t79iozaE2m1xAHOPqGRMffMv8r6J72j302frUn+qI=; b=LtLtZBjUVRn7XOI16Rm33AyVBLaZdrsThpomhyNYCwzeg/Hq7bh+3tksxcWir5IewuTBHB ONV6ChWTkySxD1zuoc8DGtK1LKukHuPi6XgC6IXMtLds4o+0QRV6vjYpUuPgqDmTA79UqN 07rUu2whVDxU+cSfuLvTPSGjIUn64+g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-xZIE34PLMHitMjG7gVmI6g-1; Mon, 07 Feb 2022 09:46:33 -0500 X-MC-Unique: xZIE34PLMHitMjG7gVmI6g-1 Received: by mail-wr1-f69.google.com with SMTP id n18-20020adfc612000000b001e3310ca453so120342wrg.2 for ; Mon, 07 Feb 2022 06:46:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=q5t79iozaE2m1xAHOPqGRMffMv8r6J72j302frUn+qI=; b=Qde1+/2tnTHfzzmAeQY3b5inl/SN6caZvXAgagY4c+kjqZbRUzXVg8zCN21KK/IwKJ nZnCDE15y46H6HtAKWSMKvXqtmw/orbNuM0dAWf5QdtX39ilY8C8I+VTWaQmt5QM1gcq Ik/22ZGGD4OyR1nHvez97uZaD0xkDVrFdCbwBzzfndm5jnbN7MP/DWmb8lMUvfmANoxe OI1qiPmAUk1LfJaGCr4L+73hw8YghrFjTAyViPiTtF3ZvJUJxZnvvuHX1E66dNLcF+eZ 80H4W7mukLpW/9i6OsusWhHG8d+IAu/RjE/IV15qh3XDcmHJkzdxArBnFriIKVRqLkJ5 VLUA== X-Gm-Message-State: AOAM531mNWMsILVviob1VU2cjiSo5A5dQcIQF+isbMpg6LusF2ZxEkYv kiT0oKtOTNQdLB8HGqvRA9H+8GkHrSkEPyL7omNK3EzP3RnwhRX1XxnqBov1Rg68WNqm5tc4qVK 6Rh2Z2b03fp8= X-Received: by 2002:a05:600c:3552:: with SMTP id i18mr14940660wmq.21.1644245192335; Mon, 07 Feb 2022 06:46:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMVrR+RBrnlh8AzddSCKZ1Ca+zUuQZLn9WpRkM1MqzW2/120srKfxv4zFbFiH8BjRv6BS54w== X-Received: by 2002:a05:600c:3552:: with SMTP id i18mr14940642wmq.21.1644245192085; Mon, 07 Feb 2022 06:46:32 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6300:a751:d742:1f76:8639? (p200300cbc7096300a751d7421f768639.dip0.t-ipconnect.de. [2003:cb:c709:6300:a751:d742:1f76:8639]) by smtp.gmail.com with ESMTPSA id bg26sm18421742wmb.48.2022.02.07.06.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 06:46:31 -0800 (PST) Message-ID: Date: Mon, 7 Feb 2022 15:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 3/4] mm/memory_hotplug: clean up try_offline_node To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-4-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220207133643.23427-4-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2698680007 X-Stat-Signature: uhf5fo6dushg7r9gj361bj966tytmr46 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LtLtZBjU; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1644245194-406682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.02.22 14:36, Miaohe Lin wrote: > We can use helper macro node_spanned_pages to check whether node spans > pages. And we can change the parameter of check_cpu_on_node to nid as > that's what it really cares. Thus we can further get rid of the local > variable pgdat and improve the readability a bit. > > Signed-off-by: Miaohe Lin > --- > mm/memory_hotplug.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 140809e60e9a..4b9eef861ee4 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2008,12 +2008,12 @@ static int get_nr_vmemmap_pages_cb(struct memory_block *mem, void *arg) > return mem->nr_vmemmap_pages; > } > > -static int check_cpu_on_node(pg_data_t *pgdat) > +static int check_cpu_on_node(int nid) > { > int cpu; > > for_each_present_cpu(cpu) { > - if (cpu_to_node(cpu) == pgdat->node_id) > + if (cpu_to_node(cpu) == nid) > /* > * the cpu on this node isn't removed, and we can't > * offline this node. > @@ -2047,7 +2047,6 @@ static int check_no_memblock_for_node_cb(struct memory_block *mem, void *arg) > */ > void try_offline_node(int nid) > { > - pg_data_t *pgdat = NODE_DATA(nid); > int rc; > > /* > @@ -2055,7 +2054,7 @@ void try_offline_node(int nid) > * offline it. A node spans memory after move_pfn_range_to_zone(), > * e.g., after the memory block was onlined. > */ > - if (pgdat->node_spanned_pages) > + if (node_spanned_pages(nid)) > return; > > /* > @@ -2067,7 +2066,7 @@ void try_offline_node(int nid) > if (rc) > return; > > - if (check_cpu_on_node(pgdat)) > + if (check_cpu_on_node(nid)) > return; > > /* Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb