From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CF1C433F5 for ; Wed, 1 Jun 2022 09:32:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C887F8D0001; Wed, 1 Jun 2022 05:32:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C36636B00A6; Wed, 1 Jun 2022 05:32:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFC938D0001; Wed, 1 Jun 2022 05:32:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A13C86B00A5 for ; Wed, 1 Jun 2022 05:32:42 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6E8D5806DC for ; Wed, 1 Jun 2022 09:32:42 +0000 (UTC) X-FDA: 79529152164.07.D82A5A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B90B34005B for ; Wed, 1 Jun 2022 09:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654075961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BmPZwKNl0qsdfgB3OGMArzoWUPSA+8ZPWezDO9FEGpk=; b=Uc/uZFOSW8nznhPpb+bR9MB16VbWNs1YANz8+aBp9j2WOqMt3lHdeB/5dVPzvdBOafzrXk rIrsAAlvJ7yR3O9vANjA9pU9pLWnTlGHTmmwosoMxlWnM02hfMqPJJ7rREgi0xH6e2CC9D 93mct8BnczYCFQ/iL8fMO3LRDbyVibE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-402-eX8Et2grNeqOVgOdYOkgmg-1; Wed, 01 Jun 2022 05:32:40 -0400 X-MC-Unique: eX8Et2grNeqOVgOdYOkgmg-1 Received: by mail-wr1-f70.google.com with SMTP id o17-20020a5d4091000000b002102fe310dcso166694wrp.20 for ; Wed, 01 Jun 2022 02:32:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BmPZwKNl0qsdfgB3OGMArzoWUPSA+8ZPWezDO9FEGpk=; b=CV9O8E3N2KJIiM5ICBjh/h2ogl3Xy/UurNakiQzeo9OTucdj/mv/6HsrqQiD0Aw3lE W2wjh5YAd+X4vSJDMcZEVGy09wffwaA40pon5jh/kK0TqLpwI6Tegclkw/cz2CAO0A68 bMYImzE6DPAHd2CgfV7T1ojFs1+lzsC5jnLEjU/UB2ZMlG92KiebtTfp4nxhfNb5gMeW IEjJJ+faAfExfKUP3iDF/UXCKLFrifImguMk2+dDmGl1z0P6ggJcnN/DJ+Nuc2RMN62z DQg0rWPK1Tq+99DY7oNQfz28l/jqsYwPgcCnE4b4tPHG+aWgAO6uO0kVDndUe+3WMcE1 Sklg== X-Gm-Message-State: AOAM530ZtuoQfvI+74Ry3aCNQIPyJw7dD0oUi5gza3MYogOctBepvLGZ g/YKqQWo8HIm3/1tz0dC2T3qsP7KGc6WVrv86FoMQ1UofKcUSr6Io0bMevJ7RLfwsJ4P17ZH0Dm dSa+KFPV7Fy0= X-Received: by 2002:a5d:6d48:0:b0:20e:5f80:bd29 with SMTP id k8-20020a5d6d48000000b0020e5f80bd29mr53450095wri.428.1654075959290; Wed, 01 Jun 2022 02:32:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFtaO8hX+03ZBiEC4YQZfSqnLeiaEPaMeCvQfa0m+TWmUqq82gqOyLIU6Zs1St55ZbuVQl1w== X-Received: by 2002:a5d:6d48:0:b0:20e:5f80:bd29 with SMTP id k8-20020a5d6d48000000b0020e5f80bd29mr53450073wri.428.1654075959000; Wed, 01 Jun 2022 02:32:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2600:951d:63df:c091:3b45? (p200300cbc7052600951d63dfc0913b45.dip0.t-ipconnect.de. [2003:cb:c705:2600:951d:63df:c091:3b45]) by smtp.gmail.com with ESMTPSA id j22-20020a05600c485600b0039756cdc8e1sm1361072wmo.37.2022.06.01.02.32.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 02:32:38 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 11:32:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP* To: Muchun Song , mike.kravetz@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, smuchun@bytedance.com References: <20220404074652.68024-1-songmuchun@bytedance.com> <20220404074652.68024-4-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220404074652.68024-4-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B90B34005B X-Stat-Signature: fk4yhs3qp9r1ykzq53at6c9ik4jwus8s X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Uc/uZFOS"; spf=none (imf11.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1654075953-262411 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.04.22 09:46, Muchun Song wrote: > The word of "free" is not expressive enough to express the feature of optimizing > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze". > In this patch , cheanup configs to make code more expressive. Nit: why not simply CONFIG_HUGETLB_OPTIMIZE_VMEMMAP if we're touching this already? At least I don't see value in the additional "PAGE" :) > > Signed-off-by: Muchun Song > --- > Documentation/admin-guide/kernel-parameters.txt | 4 ++-- > Documentation/admin-guide/mm/hugetlbpage.rst | 2 +- > arch/arm64/Kconfig | 2 +- > arch/arm64/mm/flush.c | 2 +- > arch/x86/Kconfig | 2 +- > arch/x86/mm/init_64.c | 2 +- > fs/Kconfig | 16 ++++++++-------- > include/linux/hugetlb.h | 2 +- > include/linux/mm.h | 2 +- > include/linux/page-flags.h | 6 +++--- > mm/Makefile | 2 +- > mm/hugetlb_vmemmap.c | 4 ++-- > mm/hugetlb_vmemmap.h | 4 ++-- > mm/sparse-vmemmap.c | 4 ++-- > 14 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 56edbe3f458f..89a58ac49d5f 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -1660,7 +1660,7 @@ > Format: size[KMG] > > hugetlb_free_vmemmap= We didn't change the parameter name in #2, correct? -- Thanks, David / dhildenb