From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FA5C47077 for ; Tue, 16 Jan 2024 08:09:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC5366B0071; Tue, 16 Jan 2024 03:09:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B75F26B0072; Tue, 16 Jan 2024 03:09:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3D4C6B0075; Tue, 16 Jan 2024 03:09:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 927186B0071 for ; Tue, 16 Jan 2024 03:09:57 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 630191C0A46 for ; Tue, 16 Jan 2024 08:09:57 +0000 (UTC) X-FDA: 81684450834.14.ABE8C44 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 5132840009 for ; Tue, 16 Jan 2024 08:09:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Zgxj1qBV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705392595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=stmod4gMLQl5awDuuOKkSLLgiRIpKv0xEIhh1LQdtmg=; b=6mM9NbYFpWQqxUEGs0SjOlFRRamYKkSGKP3zK7iFu9k61DAfymZyJYsJQlsny6sdzigkyU 177VrRRZ4yZTTsgH02KteS5LqpGH9zyZzGLUL2g5tlRp2UjSfDXMNM3ZD/FlGgBAY2KgV3 Qnb+W0rc7+ig0SQP0LGP/lz8Q4bSpns= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Zgxj1qBV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705392595; a=rsa-sha256; cv=none; b=CvNZdEYy3ZZFu4JwEtVv+2bHxorICG1j7RzhChH6dZMnVl6CspVk0DoKxpFKCy3dozNV7r chg4n1OY7QpBwVcZjBP6VkYGrP46L+5gTHsywM6GwlmHECC6CbpueME/kUgNJ+/eOFqkIt mxJC62mjAmiLZDojp+5SXUsP7TPE6jg= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705392593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stmod4gMLQl5awDuuOKkSLLgiRIpKv0xEIhh1LQdtmg=; b=Zgxj1qBVWiqbB1I1nOZrqaiMvlvXAEAGehrdmZHerqFa3IsyBcM61rTo7Ag8rb6mul+rrD O3kJxh5BdL9NLy7C+EcrZKmJN3nIn25Etp+ojp9GCIw5kKAHBLEItGmz14dX+vJBQ1LYjF nAKuTEUxVFegTtOl8yA2zv47pMRFCIg= Date: Tue, 16 Jan 2024 16:09:42 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages Content-Language: en-US To: Muchun Song Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen , ligang.bdlg@bytedance.com, Gang Li References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-3-gang.li@linux.dev> <2ae5ec3f-4a96-4819-af65-5f04df0c2ebd@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <2ae5ec3f-4a96-4819-af65-5f04df0c2ebd@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5132840009 X-Stat-Signature: aan7ny41u35nq1bkm4t551h6rh8xh9qc X-Rspam-User: X-HE-Tag: 1705392595-560689 X-HE-Meta: U2FsdGVkX1/tZ/MIHNa/bjvPE64DKFOjrzoZSsaKP3u65xnS/nMsMy9wGkhCujP+NfP4i5CyL/clfq87RCjXBAj2yHFXTBGSIMedA+FSEdS4reNK/V4UwhDUW/ftFQYwAauHuNFHmD0bOJAsn28KYGYw3LuCHI0gax6LDVwth4JfJ00Ok/IjDqiLeYqmaYbVj7g6+UvUIR6hcao4tjSAGMU0zimrYLb3jIG2gHH7gvm0B+dgnqMLYpAG4f/WeO602OcXo56HpmyVLmN2OLjiGq91/CATw+3IOuJT+5htL4u69pZ0dYyWzcIpY9rEEcns79X5os8jnQ6ybf832Q/oyimrcfEs+KvEF/7qI0dhWtUQstiP8QaZG4P8LDZI4AGkd+pERDY/jwYytbEOanGn3+HSQmEWFeqqfobRwrmr2yzD3SuiHgMpJVzwAx/0L9nzNDplUYT5G7Dfq8CJAuA1Fnwsb1MgCr+9zECxFPVg3dZfE6AIENWLpVbcGqRRJ9cpu0wIirLHi6caDFz80ezMqtWbAs0VUAROsM4Fxl6zWiRl8myD05u0CeOhuJKL1S9w5C9VKtaRjegWVqvB5qoc6omVXyGsAXR26/xWGDJu8wYaDkR5LkIc9QMnMDlsk8EqBbcj0PBtzI30htllh/A8XvEl/PlJ+WZ+7H0EPCYFS4ihC/Y3clzkATbiM6UCZ7cByAF/N5pSrXWNZhZKnJA49G0cHpL0cb6IsmEOEFEpqon9xNUnTRcSFHAyvIJKlQTUT4+vlwz0dKqOBXvdYCaaUoKrbzo2sGb+5gSu8gGg8ysOgl26jh+mzL87qHygBjlZnAwJ0GQCusxmMqz44qufjrCjqb23m02DuA93YZZ2/aRbAxYlUKw/N7VWZns5ZLOWJomU4FhfmODE7snK/hlohOV2+b08ausNSWB7Cro4OJ9s2r6wHgJepJyD0EO3GnWHw51aQlCIABW0YLHVTwJ gWxoALIT p3tIlJVlVl6CYODdJkFoNQ9MXqO9CpYvZ7cv49RVn0cJ10r38M8Kd5gd87vc93yz5Tw9dkcw2imMUi0AWjdOaf1IPej7gw2GrL9ZsMZa8n9eyvrzcTwTJce2A+jomYzaUFmnr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/16 15:02, Muchun Song wrote: > On 2024/1/2 21:12, Gang Li wrote: >> hugetlb_hstate_alloc_pages_gigantic(struct hstate *h) > > The name is so long, how about hugetlb_gigantic_pages_alloc_boot? > >> hugetlb_hstate_alloc_pages_non_gigantic(struct hstate *h) > > hugetlb_pages_alloc_boot? LGTM. > It it unnecessary to reverse the condition. A little sime like following: > > if (hstate_is_gigantic(h)) > /* gigantic pages */ > else > /* normal pages */ Will take it in next version.