From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712DAE784AF for ; Mon, 2 Oct 2023 09:57:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CBF58D0016; Mon, 2 Oct 2023 05:57:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07B548D0001; Mon, 2 Oct 2023 05:57:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E85678D0016; Mon, 2 Oct 2023 05:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5D468D0001 for ; Mon, 2 Oct 2023 05:57:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A32181C9DC0 for ; Mon, 2 Oct 2023 09:57:15 +0000 (UTC) X-FDA: 81300068430.03.AB1A47D Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf17.hostedemail.com (Postfix) with ESMTP id A35D240011 for ; Mon, 2 Oct 2023 09:57:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ObfOUgA+; spf=pass (imf17.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696240633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iwEtkxsfBhgs6E7OtuujbkpVgU3JMhyc0hqKghcL4RU=; b=YImxhVnimvySHf/1wEVtVDujWDAzdFAJrL7CkfDilzZ1EcOaWjrd6v7QcsfIZduX8kyN4H oQZy7y9X8ZIdR4sXNvoFRkRLN60SQDi+P7U+POFHSbT2Tt5caUkSHAgsXbaekiTSoRfjOA jv/cUkiz4/ZAv/J/fmpjZTm13x6XZXc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696240633; a=rsa-sha256; cv=none; b=3K0wQ0MrBo/fFocjFdwZiMTjamXtLMBcNJMS2MSO5qr9VX4mhhIZHsCK9VIFcwUSAdOo5+ 1hEkKmvWza/jg+0NMK/gqwYLhwUj10VrQKBKw2r28AWruN1jOOD12zm1LAcNQ7FKVc5+Xf 2iiq7wWgb3CO/F+9dOUFefyztjIdpsQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ObfOUgA+; spf=pass (imf17.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.49 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50307759b65so24990676e87.0 for ; Mon, 02 Oct 2023 02:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696240632; x=1696845432; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iwEtkxsfBhgs6E7OtuujbkpVgU3JMhyc0hqKghcL4RU=; b=ObfOUgA+r9qvt2veNQolprzxvhepB9arYVlnNeG2bYClHUNn7J9bfjb34zuvad3sax FGYaCUxfeW+Mtq15ckFsXi8t47kuDZZNlj+RgrYnX6bl1RQBMogt3Nj/ZmChjqtxB/eB oKBK3jXYM+O2RovudB5yq/sTl1ul83mGkaEb8LOdEFf3dZC8qR8wfGV3VPs5MdLWgdeW mIXBBqYm1wbcfDmijnXpH1H85K0Wk1xGZ+duPJ0USkOmTafT8Ngd2TZqSxS9t4JjSM+c xKMciiuPSpv2X3biO7cqDlXnRJP/nDeuAQenJnP1LG9sKWTmcotPeokAo2XM9FjWSgoz slCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696240632; x=1696845432; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iwEtkxsfBhgs6E7OtuujbkpVgU3JMhyc0hqKghcL4RU=; b=XmO0gbp3zEBP/hVwxof6aTjK4vWfCn3r1CcZ18UsKYDreuM+m5or3ljJfL8/mRZbfU V7jxkf39tYjVB35/xSh+tl+t/wGOxbhk3bdkQ+PtLhVguP1/xurf9He0jLMLTZPYgRqI tQ7L5Dba3omaFE84afxkn7ZhLc6xGk8dwEGSb8Pn/QgB+w7Hnf0b0zUhATHdpiXQUwXd kV4Z4DQXx7YIBuHqFiZo8+DlEb+zcdnP44ewwLWL2YyK62YZyEwXYU4Xg3tFwhVn22ev R9z2RjJAV6cs91OirbyK97ZkF2YhlmtdRmfAnKPF2IVkpUAgsSaR0Re2hcyTGFORM6i+ y54w== X-Gm-Message-State: AOJu0YwC82DdwiBtQubl3+/rw6h7q5DOY9hV8PVIx52bMWBuSkYFmh4v YuLHVqR0Q1H0MtbDmAwDXTDV/Q== X-Google-Smtp-Source: AGHT+IFdE6YQcfmyUbpQxzt3Mj9yhWkQUIGV2HAIWGVAJzNvPsQqCa1EWZ80dNv5OCeTvDOY0+o5wQ== X-Received: by 2002:a05:6512:4011:b0:500:9d6c:913e with SMTP id br17-20020a056512401100b005009d6c913emr10719139lfb.52.1696240631837; Mon, 02 Oct 2023 02:57:11 -0700 (PDT) Received: from [172.30.204.164] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id v2-20020a056512096200b005030c533843sm4617893lft.154.2023.10.02.02.57.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 02:57:11 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 11:57:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations Content-Language: en-US To: Mike Kravetz , Konrad Dybcio Cc: Anshuman Khandual , Xiongchun Duan , Barry Song <21cnbao@gmail.com>, David Rientjes , Miaohe Lin , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , Naoya Horiguchi , Joao Martins , David Hildenbrand , Michal Hocko , Oscar Salvador , linux-kernel@vger.kernel.org References: <20230925234837.86786-3-mike.kravetz@oracle.com> <20230929205731.GA10357@monkey> From: Konrad Dybcio In-Reply-To: <20230929205731.GA10357@monkey> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A35D240011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: i4n9emececun5bi4eja18pqdjgpshb7m X-HE-Tag: 1696240633-858953 X-HE-Meta: U2FsdGVkX1/Qwl0gXHCrnzTDRW0w+v90EGx33sIASaYXQTOkJ3TAuwnLFWPYypxGx9jzZzOfJQVLmdxWK3ib5Yj5Mb5wP7u4npBwZx+r/dJ9K5bBcthx5F7KxPL4h1pjOWo8Fq8LXHcntF0aHYhLQ7p5F4oJecvbuo6oG8hQT+oRMiFJqVhaogjpv1nKVirSOibuUtiKiJ9JgvrdnVnyojjsCfsmAzWQM43QpcBqhRwGC+sOGRd/ohZDPPfCT5IeUaiZwZhaeQVlz5q0Ohzbv6erudXF84cLX6XhOEDDX/MvPzeyGZ+mVjsnaf3sbrgYXWF5zcBe1L64mDyqMzarK/rBJoFJGFIo5rN8yufxDCUn3aikO0KEeQpgnXoyLGLanjxWEC6SsLnBJN+5IKulnXyvynV4/cyB2kInlNHUL2FvKW0KHxLk9Hzv58l7sMbHccowyldNSqbUa+C+eTGwUKfYKKpHWSxaJ4nVyD0QM7PAXKJ2U72JRORRA8rSlppRk+DRuY3p0rr+tebo6bH8LfSPh8u+VpfIjokOC44I3++EKXZxRVskyfj8SNZOu4tV2CgAyxRzV2lCJg5PWMZoQOF0CEU9REYsbi5CY7TE2YMmKb/WH9FhM4OSdq470pOBzV6FXUcAwMlkSFgfKqUCqETp0alj7k6NQdEtfIYZ+g9btkiy8XhXO2jSD72TzTCHMQe5MxJ7XlpujWjfa7Efoclri9MePPV63bbQidFrhObjNitpuGVkQRsFdpKbms9QmzP/HeHjHtg3IAb43Ejq1xzadM2U72qMPX69M9c5H2SgTkMjR8XAGb7h9MKds4CWnNa4VN97h7aYkivEqJ9Wj5zjO9cDSNn0qvImftbM+ZGSG9AjXXQAyxg/pYMPbeDlNaKhe/AXl4x3rap1/ljlM+25ihUnoHf7bRzv2BhJPUk9OKDDQAQ/J496U1gAMYAm2D7kwhnfLTLwvJkCIeP 0EXNLJJE mVcZMUh8NvxenMZePKOSlBES42wZwmF9j1soCz3jK/sBLTrGrFC4I7VeSfezHQeK0w0FNHZkS5KZUUgJXhBZqn0X8p04OmjEFJJD1vIkd2rtlZ+3zdJPcwkmHj9jm+BUhuYw10iYIMNb0xapOn38vtqEiA523nYBCMrSmWsc2PNVc2DdOKVON39F/yZZUgGKJGOpDwbQDuDTqMEsZvDlkhNW7g3lhKGu7FaC0jmv5dfIKPnfuJvViq6FUC513lySgonUvAGSVFZeC/+L8Ppa3YiG1jA6+y2ISBZmWV5GRN7eYJsyYN8wEMI5cvffMpIWU6sTMwk3J5wAvUoytGd81wcV4XQJPr9q0o0CX2k/GOfuZyLkJDidsE/EGLIygsvKJLvR+PPCU2T5oiZiexKJ5tP7aHUuCUFOAEo39pG8wTS3umJiv+11R5EakNqjOs+wRjs4H9JtS0XtX6bMsyhHx4Fkb4m4kRNcc8qYpF8aNR2nJQEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/29/23 22:57, Mike Kravetz wrote: > On 09/27/23 13:26, Konrad Dybcio wrote: >> >> >> On 26.09.2023 01:48, Mike Kravetz wrote: >>> Allocation of a hugetlb page for the hugetlb pool is done by the routine >>> alloc_pool_huge_page. This routine will allocate contiguous pages from >>> a low level allocator, prep the pages for usage as a hugetlb page and >>> then add the resulting hugetlb page to the pool. >>> >>> In the 'prep' stage, optional vmemmap optimization is done. For >>> performance reasons we want to perform vmemmap optimization on multiple >>> hugetlb pages at once. To do this, restructure the hugetlb pool >>> allocation code such that vmemmap optimization can be isolated and later >>> batched. >>> >>> The code to allocate hugetlb pages from bootmem was also modified to >>> allow batching. >>> >>> No functional changes, only code restructure. >>> >>> Signed-off-by: Mike Kravetz >>> Reviewed-by: Muchun Song >>> --- >> Hi, looks like this patch prevents today's next from booting >> on at least one Qualcomm ARM64 platform. Reverting it makes >> the device boot again. > > Can you share the config used and any other specific information such as > kernel command line. Later this week. Konrad