From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E2EC369D5 for ; Mon, 28 Apr 2025 20:53:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E53FF6B0012; Mon, 28 Apr 2025 16:53:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E033C6B007B; Mon, 28 Apr 2025 16:53:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C54686B0082; Mon, 28 Apr 2025 16:53:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A7A7A6B0012 for ; Mon, 28 Apr 2025 16:53:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 738A381510 for ; Mon, 28 Apr 2025 20:53:46 +0000 (UTC) X-FDA: 83384654052.28.99C122C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1135A40007 for ; Mon, 28 Apr 2025 20:53:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+D5Wmb3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745873624; a=rsa-sha256; cv=none; b=tHxe5Jnw8VyP8+8p4F8Qfj6kaDrkwbzhobWFc3xaICy24GAPc2eDT4BSxY19jPLu7pPtQW SzHwF5YAU9rfQxuT8Su7EMvvQPKZr8Ogzn+CHTOV3+ibKZgkXjuTRf4YhKFbJzwE67YXee s9aq88Din6qBvhMp+nMOh3WDZvNkw+8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+D5Wmb3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745873624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9NrijACrVI0d46In4Ef/eZDIzQK/apI7tktcFwphNAA=; b=x3pyHmw62r/aU/gSr186XInk3p1bToVnr779fpRecn3jx6RemYnbrtpqJI8wEq/sm1sKRb yoJHUc4uexWtLL7ZrcpB7fqlMDB47o9vibm0NvLiPwbDQhR4csL3avuTqDK7qHaSoxvX+m 6UTQQmVea61UcnKXF2LS+Zj0niuNUVI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745873623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9NrijACrVI0d46In4Ef/eZDIzQK/apI7tktcFwphNAA=; b=a+D5Wmb37cF7dVb+D3ISlAgTmJ88vt3QhF+6/G64mbuBptEHnUIpYnqUUAvMOpIxFHRZJC EPJk32UlesOKun6OGBM1MfoTSKUNw73SsYGDV2HUGOCcDbCKVRRVXoQMHkyyqweakSFMku QmjpGqwnXZWToZATcPyw9aPvdnDeC2Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-rcQW2nVaMBaYHa0XHQEKrQ-1; Mon, 28 Apr 2025 16:53:42 -0400 X-MC-Unique: rcQW2nVaMBaYHa0XHQEKrQ-1 X-Mimecast-MFC-AGG-ID: rcQW2nVaMBaYHa0XHQEKrQ_1745873621 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf327e9a2so35015245e9.3 for ; Mon, 28 Apr 2025 13:53:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745873621; x=1746478421; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9NrijACrVI0d46In4Ef/eZDIzQK/apI7tktcFwphNAA=; b=pON+v0vzRhDsMqx4GKtsTjcAugzAHIOmCRKpFLNuVKlHfr8OyBbYoFL5WIqIIWPHJW XG8io7nWVasLXfIueIuazWBCRZEra82pY3FRD549ckNefP8LjPh15sUJ4Ls1Jk8DuVb2 zW5g6g3pHTG551sQtf9/+CmGXCQrB4YucuH5CnO2C+k/QZKFFC3EJA4mOxU/BeO8CPN3 dQbpyLpNQJsxRP1H8NNOe6IVVMMuPbhtXmVTrKpuLTC5ZjCj6xXa93VtGXviTRKdhF2V N6foIpWEcvlP5NOibKqIDfam4VsBQeAHJYxyHmYkp03jSnk8mL7mwhSwl3Ib1O9un6eK 2pNw== X-Forwarded-Encrypted: i=1; AJvYcCW1Sp2HV95ObSKdABif7UNc9w5htzLDHgizi3XRh3jGZNe8FBfGhkV0MaCaNeXp2BEBSP1k8YKHXQ==@kvack.org X-Gm-Message-State: AOJu0YxzLw+vk8YIucqYyIpL0uCh/HecJQW39Vk+JV4JLCxR+4rzDbYn OwiEtxCbjZXtavgCzUqV0SjT7Q32xTib2G7WuCkbxyNJxQEFcC4hb1CLnFEBzsqOKosAokaBE+C vttVKGA9uHZNitmTT+jz2HrCzFg6nHiEoiMAQmygLGCcAc1DS X-Gm-Gg: ASbGncv4UOONhKaSb4RP1alYyDFB3vCc0oeNrQx1WO5GUY4Eth/WF8MB0h+kIeTeyZx UJ1L5+tKvCAgVxiT09aVaKotdAxYs+ah+uTdN0uPpINT94P3QOaGoOy2jL7Y6RdBSHo2RP4Cjjf FE4FcN8tjhnhqtlaLBTT3aiS566nQtC6P5k749pt0RcKcpjs/Ox+WAJ3MyYyTHYOAPn5SO1vuUX 4pjXZPxwEMzmTmgdus8GoZStzxJHSn1xNinOJdywo92uZiemoOwRetJYBcMAz7LZKyNuBdHGFu8 jiLls94kP/ZIueaF0piM2AYCzbFUtXmHLP2Jes6rVYLWzO4wuFrV7ATkZfLelwuSER1xCRjneR3 YMaV+xE5SqKgReLenOyHnZAQkCggDoh4JFsoyiIQ= X-Received: by 2002:a05:600c:8112:b0:43c:f78d:82eb with SMTP id 5b1f17b1804b1-441ad3c708dmr1746245e9.15.1745873620922; Mon, 28 Apr 2025 13:53:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEw24C6HKQcRQnuzF0GizlWJ2/kyYEzORcRGXEVbHeQEcXEI1mVjEfDrlAfYscrdW/qBLTTAQ== X-Received: by 2002:a05:600c:8112:b0:43c:f78d:82eb with SMTP id 5b1f17b1804b1-441ad3c708dmr1746155e9.15.1745873620606; Mon, 28 Apr 2025 13:53:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d868asm166551305e9.26.2025.04.28.13.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 13:53:40 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 22:53:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm/hugetlb: Convert use of struct page to folio in __unmap_hugepage_range() To: nifan.cxl@gmail.com, muchun.song@linux.dev, willy@infradead.org Cc: mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni References: <20250428171608.21111-3-nifan.cxl@gmail.com> <20250428171608.21111-7-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250428171608.21111-7-nifan.cxl@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qsz9EB90USukfVLTXWPjGu29SzkP3VgYKUp9KjGzO-4_1745873621 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1135A40007 X-Stat-Signature: kra811etkqdfzsbrbzinhe6fwqt6d9xh X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745873623-886454 X-HE-Meta: U2FsdGVkX18OcaZioOpQ0O0VKYpZekNvbaGuqzExFIWIlgUBl2++IEr7FUDdB8dcBMAy2oDGpX0zaqFu4EICyIAqvOWPSLxXSu4f64tqPgMdosAh5+CiXvNryd8cm7lYReGO4HnODQjnWEerFN1Cs2/TqW8WycqkcoljfenOLVwQJaCzQYLO3gqZVgVyu3uuoFPsWZRBl9cLdoN34U/j6xvjAd32pnUAK2g4DFmG2Nbu9yBr7PSJ9KLgSNmzglNgBT80IAvAutkK3T3KkxG1h802gItXrkocCsBlYtYHC0k9a3+FWM/BPYbBtMxyIEQwoNF0eIO9eHWDmvJDlNaB+3QEc6DY3muRE74bsz5EcILlBEIoDyHvsKyRn8X3Qph71OwJvQ76r2n1NdxkP/sd9Minzg/WyNlWLhrhVQeKv6yAIF88zgLlI3ATuC4cnZS5pT/W4PSWpegav0wSW5zKMU8QLgAm4InHfB9WDNoIG1iuLCncEme8a8WS2uiO4cDi0npRvYsnWnrzoKjAllu8eL3N+GJfE2XH87iCq73Bn7sae6s/XdhMhFTwENrXsyXO/UprRNdrJXx8sc1Ajic2WYaawpPLTfdKijLxL5flfD4GWHTtwaiiDW4dXi8/b5/gkYSGWsgoAkuhw+nbmzACe+RFpIw7nv2YejhtvPwo1bT7c5u/c/r4wBff4ZrG5pbNLVf5BZUbqobHT0AepYM+BvF6gR+7GN4asoLIKQfZIUMZvlwlWQlX+8xSrESO97Qeo6PESRjfIX53bwQt8Qimaq2Jepa2Bn3EueTzpS53OxTnzqXAfv6C0KMhVO3eEWz1Z1TsO1ccg5yF/vaggp1dPF7dJkk54nQPpsoeeeKc6MRFoVIdfttHF6XSm5s9//egAhg2+xWLvQHtM/4LvgWxPvBeucxk8za2A9h4HF1wFJx3+IQffxhOtMAqtzVw5kdx+y3AGz+/ZYRDVjTEfkM Tb5Txk4O y8CE/6usdyl09Kgoy2h/Bboc0B600kVZiCGrgq0AfG8mvSZRELr8tmg8T1LnCVrWWAo4v5nAoo6GP8G+mjcZ47wt2OB0flfje/Wy//9/x6syTXfFtt+ZBwUGd1NBx9A1/m9uqrGpFodtsrH7qlarnfk9PqplSxe/Vz3gGCG1ljb+9E478i08Y1S42c9YYPv4pA5u4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 19:11, nifan.cxl@gmail.com wrote: > From: Fan Ni > > In __unmap_hugepage_range(), the "page" pointer always points to the > first page of a huge page, which guarantees there is a folio associating > with it. Convert the "page" pointer to use folio. > > Signed-off-by: Fan Ni > --- > mm/hugetlb.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 6696206d556e..293c2afa724b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5815,12 +5815,12 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > pte_t *ptep; > pte_t pte; > spinlock_t *ptl; > - struct page *page; > struct hstate *h = hstate_vma(vma); > unsigned long sz = huge_page_size(h); > bool adjust_reservation = false; > unsigned long last_addr_mask; > bool force_flush = false; > + const bool folio_provided = !!folio; I would but that all the way to the top. > } > @@ -5943,16 +5944,17 @@ void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma, > * count will not be incremented by free_huge_folio. > * Act as if we consumed the reservation. > */ > - folio_clear_hugetlb_restore_reserve(page_folio(page)); > + folio_clear_hugetlb_restore_reserve(folio); > else if (rc) > vma_add_reservation(h, vma, address); > } > > - tlb_remove_page_size(tlb, page, huge_page_size(h)); > + tlb_remove_page_size(tlb, folio_page(folio, 0), > + folio_size(folio)); > /* > * Bail out after unmapping reference page if supplied > */ I wonder if we want to adjust that comment while at it. /* If we were instructed to unmap a specific folio, we're done. */ Acked-by: David Hildenbrand -- Cheers, David / dhildenb