From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568CAC5AE59 for ; Sun, 25 May 2025 21:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A4E6B007B; Sun, 25 May 2025 17:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 771EC6B0082; Sun, 25 May 2025 17:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AED46B0083; Sun, 25 May 2025 17:53:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DEE96B007B for ; Sun, 25 May 2025 17:53:38 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 608C81A132F for ; Sun, 25 May 2025 21:53:37 +0000 (UTC) X-FDA: 83482782474.18.A98640E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf20.hostedemail.com (Postfix) with ESMTP id A1B4D1C0002 for ; Sun, 25 May 2025 21:53:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n1thvU2n; spf=none (imf20.hostedemail.com: domain of ilpo.jarvinen@linux.intel.com has no SPF policy when checking 198.175.65.11) smtp.mailfrom=ilpo.jarvinen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748210015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=av9VsxIknWUUfE4hYtNhEtgrxuLaquIfnPWePa13ql4=; b=FRuDcKpd9kIoKa2xfs8iOI9aZnKJVmLrZ+JCwudKsJOO03nR5oDFf3NVpoutKW9u5W+Gqd cLiPpzpMqONLIld2DQ7dm8aoI0MvlmfQW4k0F+cJWnfiOkmeOkXAslVpKRyxc+wsNhWHrS 0eVdbIUnGdT1YIXoHfuRXhk2a6ksaSs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n1thvU2n; spf=none (imf20.hostedemail.com: domain of ilpo.jarvinen@linux.intel.com has no SPF policy when checking 198.175.65.11) smtp.mailfrom=ilpo.jarvinen@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748210015; a=rsa-sha256; cv=none; b=LLGc+TD1wydpoW4PRISqd1NrPxisurmarH1RzZkiaNHybVUrgZGy0Swt5J3P1TDmr3QWAh ymJ8aXGcgwh3JybA4G8RiqSQfF+5V7suUag/dX/wY1nf7qZjMQuFcTurIC4HnI1YnvyWfj ULc9hoeNyV1jySYZTBKOXiORwIuKwdU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748210015; x=1779746015; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=y5rT2ewj429hL1YZNClBKAuoapp2CjjiHYqsoHYBDa8=; b=n1thvU2nsN1FekQdLWKzOwYQeuWZcLH4BM61MM6F/Lveg8ERF3nrMIUP mkAREHfVaZCius/8GkG9imgSXPV0oo48VuUmmgI8gU8AztmBoLLdhSPF0 oCH+3OqERJTs8rxkrfXfPHfsHWnDFGNfwNZz9jClh/Xru/Namb4AqyGuB 3skJ60V6LGOOQVKijDHWh0saYGFNojrrTPzjeDLjhCIp+AYB84l0YW3Wb gJHGm2tG3mv8MHjzAPZTMHJY1Qc29ElxMKf9+HlgZSl6R55lCHBicJLAr V17yIdDC9O+67KroxtscWk4nRjAdyWmnOYUUK7pzwebacR81rf+he13h8 w==; X-CSE-ConnectionGUID: 97wKc77KSLmX5OCUHH1icg== X-CSE-MsgGUID: 6fxXGvXuSDi1vDw0wm7pnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11444"; a="60435796" X-IronPort-AV: E=Sophos;i="6.15,314,1739865600"; d="scan'208";a="60435796" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 14:53:32 -0700 X-CSE-ConnectionGUID: srkUUk2LSiS9AVRoLfAP+A== X-CSE-MsgGUID: abYToWTKQVe6L6ZrKUUaNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,314,1739865600"; d="scan'208";a="141991367" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 14:53:16 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Mon, 26 May 2025 00:53:13 +0300 (EEST) To: Kees Cook cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , LKML , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches In-Reply-To: <20250523043935.2009972-4-kees@kernel.org> Message-ID: References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-965883235-1748206555=:933" Content-ID: <8656ab6c-8f8d-81d1-5dfa-740e7f21544c@linux.intel.com> X-Rspamd-Queue-Id: A1B4D1C0002 X-Stat-Signature: 65usfkdrm1sogkpbc7xux5jrica6ew8c X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748210014-299059 X-HE-Meta: U2FsdGVkX19mAFDILjXnQS6pzbNWcYU3niJ5QxfmFdnH9oXBK003bTljxEOQQrnKtwF/AyEoUPTfzFqqYvRloTeel+TqoB6jJi0aWYYEHBckIL9kOPOj5ueFyMLrBbrvWfmZt9BEviJPrBmvWe1585BfnejSniMI91dueI7gS90OQNLtLZH4VPEvQZAFLQgONeDWWT/1xeGkR5ZSQHZPX5/0LfkDqr8YkUr8X74LtkfmXMlot/UGpJXjuMMSy0lkUAD91RGOSK8mFAoR3iZUw4cFlmVXwx9ET3Mj1+3G/AbibHQxVqic81hPmyDfCuVjY3rA6yOrbaBKIYSnAuASomABiDESeLqWaxcLXBlteDE16USxahv6D3kFrdtQv7ckq2EWv9hi3be2C63bLNSjLjCnRwtqE01qeojKugDFIclisKPkNIPLOBGgEL05PsEPG/9AtrhAfwvTFbSFpOXWw6IuOrYbwEXul6p+hHEsXhoLZsjvAwPx3AqI2GieusF33fHojRZT35Hv3O1xk7mlDrsJU44ia8xV7KEvPgPk1l63uFha07rBxNJEiLWB5nDnNlqxlZEaeE1PxHxCMTo4KJCLAmdiTohJn63mlKvAXfloCPsJ3NKPIFwx36B8f45MGUsVWtdJs5M+x04dsBe8g0CCgIDZo8e6UFE5Y9wKNmjqJQWoqqY6sEdMMT58t3beimc+55kmOhWSEo9HnzFoGmQ2eOkaeI/DdBzfd6voX94ETDb8pAHc9FsX8VfNiCq0Btmjery8ASxJM7btdKosWilnqE3aHB+4/UKb+BJT0PHBRP9AXM7r8jZCQekvL3TABK3TDRJu4kR2E614eGDcYj0NPEpyUxJRIZRRwtuXda7yrMfvMidNtKhROoFuCoRE9waSLN3GmecoWTrDhgSvY2TBiqT34u5T9ZphN7kOZC/ouDXJzqDDZCzM/7MTa8eCV9GwuzSSZrlnsDqDMIK QhWLioO9 AFsYTCWo+5jevZTkbAodYLUOD+A2qX4QHRM0YwedSStXXyWO8MpE3pH8/4Upy9OcEqSrggV0BEYvkZ9eQFPkZla/978DLfz4ZivIT85DsP6UrBG6HK5L2HpUdhctZEcTQZscr99RBiugrV0wwyagOBBcJd8DRpm1I97EGE8bRhp0lWlL4Mmyw5MryGKtjn6j4MXiT9ERxtHKVgi4ju4lSgIo1aSJWLEF5QJVMVli4bTWSEXOpFp8FEcNEqj5k01vbMn0CtM0cWnfdbLyi1IC/j4+2uCvuwmjHJntRk+FV59xyKURIqqwpznVkBx1sJpmyuMNMYphcpkcWIf0Li/Useym9Con6P9CsXdsp/IpBXI70ym8fQlmaIjh9oDHyWAhgrsjqXKmp8Hnn8an4EJpkmmC61pLiilPyWiFasmMSAcOKvukM9wSwGjOfeLAZP50hKtDFqluMTPoj9IscX6lZX2BrAt4ofPPUqhK4pNkW/hgEZqVOzU3gMsloXgRa3hoZDhCH+OtvYqxCN9VpBYLEoX3o5nnDF6p2taRAIFBJPPnCHjR67NR1VOGhCakdCWV9+ystMNZN5pcfWGvoDZOKZvuLskbqbKrv/ldbnvLKuFb6NuWZFVFCwz6SNCtjM8YldHy4CD7x2Hb0hwywP+nb9zVh8w48h3uTtkzIOWUxxbA8WVtyTupZ5Fcsb2QWzykK96yXfPOG9KO92Ojkn5POmTwGuwGR7tmfy45RxZ5Tu3PamBNTKpISLJVgCBtNbR/GFKEKSKWdY8OwgIo7oKH3HyTOFJYNJGFsy9mZKlHJPp0e0K7wOjswiya5wcudm5776h+1Fq5M3EKEwDc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-965883235-1748206555=:933 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Thu, 22 May 2025, Kees Cook wrote: > When KCOV is enabled all functions get instrumented, unless the > __no_sanitize_coverage attribute is used. To prepare for > __no_sanitize_coverage being applied to __init functions, we have to > handle differences in how GCC's inline optimizations get resolved. For > x86 this means forcing several functions to be inline with > __always_inline. >=20 > Signed-off-by: Kees Cook > --- > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: Vitaly Kuznetsov > Cc: Henrique de Moraes Holschuh > Cc: Hans de Goede > Cc: "Ilpo J=E4rvinen" > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Masami Hiramatsu > Cc: Ard Biesheuvel > Cc: Mike Rapoport > Cc: Michal Wilczynski > Cc: Juergen Gross > Cc: Andy Shevchenko > Cc: "Kirill A. Shutemov" > Cc: Roger Pau Monne > Cc: David Woodhouse > Cc: Usama Arif > Cc: "Guilherme G. Piccoli" > Cc: Thomas Huth > Cc: Brian Gerst > Cc: > Cc: > Cc: > Cc: > Cc: > Cc: > Cc: > --- > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/= thinkpad_acpi.c > index e7350c9fa3aa..0518d5b1f4ec 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -559,12 +559,12 @@ static unsigned long __init tpacpi_check_quirks( > =09return 0; > } > =20 > -static inline bool __pure __init tpacpi_is_lenovo(void) > +static __always_inline bool __pure tpacpi_is_lenovo(void) > { > =09return thinkpad_id.vendor =3D=3D PCI_VENDOR_ID_LENOVO; > } > =20 > -static inline bool __pure __init tpacpi_is_ibm(void) > +static __always_inline bool __pure tpacpi_is_ibm(void) > { > =09return thinkpad_id.vendor =3D=3D PCI_VENDOR_ID_IBM; > } Hi Kees, What's your plan on upstreaming route/timeline for this? I'd prefer to=20 retain full control over this file as we were planning on some=20 reorganization of files into lenovo/ subdir. --=20 i. --8323328-965883235-1748206555=:933--