From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA837C61DA4 for ; Tue, 31 Jan 2023 01:51:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 680166B0072; Mon, 30 Jan 2023 20:51:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6305C6B0073; Mon, 30 Jan 2023 20:51:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F82C6B0074; Mon, 30 Jan 2023 20:51:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 401076B0072 for ; Mon, 30 Jan 2023 20:51:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 12AC1160722 for ; Tue, 31 Jan 2023 01:51:21 +0000 (UTC) X-FDA: 80413416762.24.676454E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8D7961C0012 for ; Tue, 31 Jan 2023 01:51:18 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DC/74vsl"; spf=pass (imf18.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675129879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mBv8DJNmeWTzhqoixUePfk7DvfX/r91Bih49ZwlSTgg=; b=gQnRJnoCNikTORYXktFjzoQlIDc4fZkrBzs3V7KdGfHvMOa07j9l6a1sFkegb5zrBT2rkG 8ivHDw2ZpILHLcMiZp5fZmBmeXSQeQH/ESeWpq5M8F3yvwXc65aQWxRZ65EfLG7I3/2X9Y JzH+VHq7VsiMlzlggT/YIOCNeVaRKS4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="DC/74vsl"; spf=pass (imf18.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675129879; a=rsa-sha256; cv=none; b=uK3rt/0xbou/2dApKoa/V5wDzs5niHfGcxYf+I6wHJk2YzYKDo7BqW991jYBacL0lzhozH Fe0Q83q8afV9Yvyf6+CKHaynxWgRxr3pEJ+m1WdV2VV/8n62Vs1wieC+RY7J79lAiAXimk ab9+eHvAyVRknzngkxLFMCsTrVKr4LA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675129877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mBv8DJNmeWTzhqoixUePfk7DvfX/r91Bih49ZwlSTgg=; b=DC/74vslTzwnAVEO02wzUzKZO9FsmJQQvVyLu1aOUQQoIFRxiJB2pM3C6SSQ8ZwwTMh653 0dTn7zVksefp4LEZoq7HcTjcJ7Sgzcq3kwcZ1KyfZXMAdhSzPv2ZX+XPOqVvutfVgE/Fwd C6ReLcsooHyYBc0JuMNS1RmenAaSZwE= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-520-SHjhAqNNPm-2KItSj1T7cg-1; Mon, 30 Jan 2023 20:51:16 -0500 X-MC-Unique: SHjhAqNNPm-2KItSj1T7cg-1 Received: by mail-pf1-f200.google.com with SMTP id y5-20020aa78545000000b00593b071cb99so2586768pfn.4 for ; Mon, 30 Jan 2023 17:51:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mBv8DJNmeWTzhqoixUePfk7DvfX/r91Bih49ZwlSTgg=; b=sZy3AqoY8+zy6DGmIOogoO3NNvWsUC2Vv9aIerZZq1CsC8DcKPtlklwg7PUejy5piy Awsa6C37WfzwyfQc30G5kD9AgUJp/f+XmhtYt/GlHHlSeiC7sQA7omikYkWa/VLutCzf D/Rn2QrddSqngZNjVWidRNopIhplh4ocapaHsIrRLqOtrdkAO2F73SPfL48RZRETVYHP AK8PjIYPKj1YyfxfQRPodDKr0qjyXLjjHtpm5+FYZFqgeQw5jvKELIEacUi7WGHYLrKf X7D4ur/KIwidtO3OYViFXsV4IWvxVHutKLuM7sLSmNswo0HOVxCB2wq6/kbh6Y1fX0C9 ONeg== X-Gm-Message-State: AO0yUKXJDqrm1SiaD6952XnKp+icVBcZqi4ZiptOicpZ3qv3p4Hed4kj bd800uTUHW2HK2Ee6pggaFmcCzkjH4r/XZWL1qS8ou1YRpEsS0Vb+beRjNq5nFoNIvb9LEmkBwd lGum1jM72cl8= X-Received: by 2002:a17:902:d487:b0:196:15af:e6de with SMTP id c7-20020a170902d48700b0019615afe6demr29574979plg.68.1675129875389; Mon, 30 Jan 2023 17:51:15 -0800 (PST) X-Google-Smtp-Source: AK7set8JSjJ+sRvtPcXP6fVdufCYZ8fk74MG4aecVDj2Iej+5W2CdxzxrzRUj04G/QWJkYRImmyA4Q== X-Received: by 2002:a17:902:d487:b0:196:15af:e6de with SMTP id c7-20020a170902d48700b0019615afe6demr29574939plg.68.1675129875072; Mon, 30 Jan 2023 17:51:15 -0800 (PST) Received: from [10.72.13.217] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id o17-20020a170902d4d100b00196077ba463sm8430985plg.123.2023.01.30.17.51.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 17:51:14 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 09:51:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 12/23] ceph: use bvec_set_page to initialize a bvec To: Ilya Dryomov , Christoph Hellwig Cc: Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-13-hch@lst.de> From: Xiubo Li In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8D7961C0012 X-Stat-Signature: o7m6apa48pbcg91kpbznanizgufpwcys X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675129878-15378 X-HE-Meta: U2FsdGVkX1/CuL5+z08F30IsfsFyuaCR1C0auBbkZ2tkoiPEWUdRMSMi0rLEsJOF+uoieQrxYA8p2z5nBsFDBHNSdYqSv7VbMFP2Hp/vfon0YNznFcix5qA+HlPPsARZZP3ZeoSy0dNzntNMH3xDD7d7wI2GA081WUcOETTV0iru/G1sHjwrWUVCTs7yVOdXCPWieV8bLOKP6I15pdcMPY9+Pgis6wbIvnQaYb0qihMk0/0VhpxXOTISKILDHkaZoeChZmBHIciJkavFTj3IQk0pP1CqMAV0vYqjIfVbc63VBLGOs2zIcEKwBoBMf2lMPF1fkFwUzB8q/a+wtVRjGG7yiB7Nn6qC0uGkCAv53/jeJfVyTswx82Wk4NY8e/DSEPC7Q/cbYax+lkuE9zy+m3XTdEFVVFjeiTgHqRQ0BRXOiMPTu8PGbRnHsYfuoHejPx5o4lmQ1JQWswttZE8qdK/S61vwif5Lhp8zXII68g1UzgH7nFwynmeeAhJMz9mKw0jg7or6pYNknXDMNZY4jW8qvlZKaKq7aiWYPHZB/i90AHldmPxz2qe01AnPqc6XSzz+9OonU8yU9MuLfcFJu7tShQzd5ZKcJc0WXzvxQV5Xae1TkNC+dinmnEPZh6qk+KDKoErsBovXfCF+XCR/7g0Wjrlt3XWGUK/QtQ0rQMHUUL6pkoj7lE3cPbnU168yR3yKPI7pye9UxY2XsdC7LW4yFHwojSXfRfT6HLwK3sLhMCAvyz/0zsbIRxsSxiLfaRDbKhxugAcVNE2DQV2UFpkMgf2zuOpQANxDjo0k/q2g42imHevPpxVAfidE95I64uicc9hP91Km4zzWM7cGWXjVrRKNp1Hv3YPHS3j+t14NXicp8T/FUnJI3dC8vZ1VCe+zbtAc3Y5MeaUcdT7Q/GEGCcenoOViVO7dJdd+pyLsPR2evWfVADogpNk6KKvhRGiT2Me0nkEG+c+AGXG 23gedvWQ I1utTcuoNYwymJA5+dylqlIIvIUQkom92I1GZ9XSq7Eg3/bMo8f1eNIoubLKmwn9seikJaM9UumhwJj9K7/NULnxRk3i/UtNS5TrnjrJUzLS7GqVV2QTvbOKQpxj120/Eo5cJKLnAAaSR0w4l6iCEshf8YQWBqpEr8XEumMzisPLVKmxw7xJtB5B17VVkf49Frc4z5TgAdAJV57I24/tv3btw7Fy8xmRZze2MOaiUeG7E+xdAaY3YMzx5k7/B+rb4pAAPMfseeEWgQgAm48ogVXcvtnTyuf/+dc74QT+Eqrc5BCwJbH93QFW7LnZtI2geaxXvlPc8VJbN7uS7ssz8yQrTCLvfI8opnH/Wj1bZRbWogVzWArN38+Yb8RO+3ejtZsU/6dOTrD9AuyNXz1t7K3n2eYGjJzleBmdoWWLIQZJbysrttILvRtu24A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31/01/2023 02:02, Ilya Dryomov wrote: > On Mon, Jan 30, 2023 at 10:22 AM Christoph Hellwig wrote: >> Use the bvec_set_page helper to initialize a bvec. >> >> Signed-off-by: Christoph Hellwig >> --- >> fs/ceph/file.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/fs/ceph/file.c b/fs/ceph/file.c >> index 764598e1efd91f..6419dce7c57987 100644 >> --- a/fs/ceph/file.c >> +++ b/fs/ceph/file.c >> @@ -103,11 +103,11 @@ static ssize_t __iter_get_bvecs(struct iov_iter *iter, size_t maxsize, >> size += bytes; >> >> for ( ; bytes; idx++, bvec_idx++) { >> - struct bio_vec bv = { >> - .bv_page = pages[idx], >> - .bv_len = min_t(int, bytes, PAGE_SIZE - start), >> - .bv_offset = start, >> - }; >> + struct bio_vec bv; >> + >> + bvec_set_page(&bv, pages[idx], > Hi Christoph, > > There is trailing whitespace on this line which git complains about > and it made me take a second look. I think bvec_set_page() allows to > make this more compact: > > for ( ; bytes; idx++, bvec_idx++) { > int len = min_t(int, bytes, PAGE_SIZE - start); > > bvec_set_page(&bvecs[bvec_idx], pages[idx], len, start); > bytes -= len; > start = 0; > } > This looks better. Thanks