From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B94C5B549 for ; Mon, 2 Jun 2025 08:24:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87FCD6B026A; Mon, 2 Jun 2025 04:24:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 830856B026B; Mon, 2 Jun 2025 04:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F8A86B026C; Mon, 2 Jun 2025 04:24:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4BD5B6B026A for ; Mon, 2 Jun 2025 04:24:20 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B661C1A0A3D for ; Mon, 2 Jun 2025 08:24:19 +0000 (UTC) X-FDA: 83509773438.17.FCCE703 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 5EC7D180018 for ; Mon, 2 Jun 2025 08:24:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=W4tM2GX7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="AtXtRF/U"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=W4tM2GX7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="AtXtRF/U"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748852657; a=rsa-sha256; cv=none; b=wVBSn5QyDy5xzaL5UE1+vwfh+3Uax2ROMp/6TLTsyXS6sbsmBjFv3OzIXPOeYcEmONn/J5 h/wm27DFVOzluNC4t+DoDmnljBNxd9NnV7LGBYqkTd887SZz/mL3P6mrf1oq+UXfowOtr5 jspqlygpWTt4nsPFRojkEFZxWheMcEU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=W4tM2GX7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="AtXtRF/U"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=W4tM2GX7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="AtXtRF/U"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748852657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UD8ca6htrwG56j6z357MyYbe+Zb0EK9l9LJ0+RTTU+E=; b=I0bqSB6CW5tQ7zqEEUE6ifDZFAs5ZenD4CLRM8bPjJHLqkBvUigoc8OkHyE4ZpRBtX+Czc TMBQ0PbQnFLOPjV2saq9ZgH/2oQi/Ii4ECVdNDayF9/A3q3PHU0iPZ5NVAaYSRmp7HJAMZ KkZ9JjcsO2Hy/Z3R+n0wxHT9GGkdz1c= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9EF4A216F2; Mon, 2 Jun 2025 08:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748852655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UD8ca6htrwG56j6z357MyYbe+Zb0EK9l9LJ0+RTTU+E=; b=W4tM2GX7rvPd2XXYzV8zDIU1Epgm5FjaDac8C92eQb0GIK0pwzjjKMt/51cjR1P98nvs9Z rljke0qDewGTzDnPtS6ffAEGBS1Rr2eAIopwVTRWk8MHP/iUel2dVaGaRdun1RlywyNIS6 FzskXD9a8aOx8EKBQ+ve8/LxZobWh/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748852655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UD8ca6htrwG56j6z357MyYbe+Zb0EK9l9LJ0+RTTU+E=; b=AtXtRF/UGAgXnwmlfaXoQsaQfS2eXrgzRTwGn8SWwL/QZbtAHlsJkkx6rXu/cGKMaVKZFb PNktu+GqQfD8mBCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748852655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UD8ca6htrwG56j6z357MyYbe+Zb0EK9l9LJ0+RTTU+E=; b=W4tM2GX7rvPd2XXYzV8zDIU1Epgm5FjaDac8C92eQb0GIK0pwzjjKMt/51cjR1P98nvs9Z rljke0qDewGTzDnPtS6ffAEGBS1Rr2eAIopwVTRWk8MHP/iUel2dVaGaRdun1RlywyNIS6 FzskXD9a8aOx8EKBQ+ve8/LxZobWh/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748852655; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UD8ca6htrwG56j6z357MyYbe+Zb0EK9l9LJ0+RTTU+E=; b=AtXtRF/UGAgXnwmlfaXoQsaQfS2eXrgzRTwGn8SWwL/QZbtAHlsJkkx6rXu/cGKMaVKZFb PNktu+GqQfD8mBCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8C154136C7; Mon, 2 Jun 2025 08:24:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4rfVIa9fPWisaQAAD6G6ig (envelope-from ); Mon, 02 Jun 2025 08:24:15 +0000 Message-ID: Date: Mon, 2 Jun 2025 10:24:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm, slab: support NUMA policy for large kmalloc To: "Christoph Lameter (Ampere)" Cc: David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250529-frozen-pages-for-large-kmalloc-v1-0-b3aa52a8fa17@suse.cz> <20250529-frozen-pages-for-large-kmalloc-v1-2-b3aa52a8fa17@suse.cz> <17a999f3-7e6b-17d4-2caf-4912221894ec@gentwo.org> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <17a999f3-7e6b-17d4-2caf-4912221894ec@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5EC7D180018 X-Stat-Signature: cux14az43kt343ypfhreooboumzwh7fj X-Rspam-User: X-HE-Tag: 1748852657-692458 X-HE-Meta: U2FsdGVkX1/N27+N0j4CHzv3nYYRWzsgHiGwP4BWSMGeDoaML+2FvdlvRljrbD/VahO30DhV7xIEbfTFF6sd1OULt554XeYYDaM48WnmOLdOqRjPojP6KBmIWa/lH+kcaJCFSeSK3SzZNa7PR6TRGzK4D8x7c7MofiTjVFVoMbl+YspKuFPJm+iFIy7dsKcL2thcUtuM8eFfH/a63D8KJ1uodzjTwvovf3/nXkbjauO1S1RUXB6d64LvSZWTfrjywx7sgOR5cjvX9MQsffk88grQms/J5BnCE6oIApFMglXfv36EQ+8yd92j5VszJmhvHTY0MnzZch8FrkJsgwDyGGrzXgryQYPLeKXllM52zrllo7ricFtCx1PWqYCNJpWZeLmnYSWyO6YM/BwfRose4godQ8EwDUqEc67kIXBqtzHzVz0dAYVdeNqQvcIyxBh84LP7j2ruPnxKsjd8c8U/KjAfnHtlXbC3fMNSMTszxYvbaya59km07mUfVnRTcL2/TGoAmnE8gCZdv+dLlmDmfDp/h8StqsrXbmxXOG9sdIhepFxJ25eBQpl6PDPGZ1Q/4GmOhVIYmqn9lQvw8xqWh9n14oVnHu3eXNmfNpwGYRbYt2RYtwUbPANiEd5+yd9XSQ2qUuLjSdK2Ziu4wP5ybshX+yr3hP8j2nM7OyUJfBbdz9Cml7BzNqZ+4h2czKPz5gfJWwsi8rXSC+MSw1ioBjaeWwWF1AOAgbUmFghJDLq+NIEmQ7IXmUKtyLKJ+717iVvUfwrYtUSybDdr7j+ZuulG7H3S2kYvJN2rW80aFwT+9x3retvb59Y0AO7Ms3wsbggdA1GgI2eMWWqij+mmG5G9weQ7Pj7jr/k9F+lJBcQFCU6T84E+luTLlr9R/wmyEn+Ll3SNLgQ1ketkyh5oS+4XnkH6rDwFLn8eUUdgCtaDN6UI7MSgR/tJaG98LhBSwWRRZYLWPS90WHJsWTe JOfySkj7 pR6TyX9ze5qL3rYjszPhi0Mm+RikntZ5XLgSu8/tXk7+r5X/GZV7dya2J2P0jOGq1SMMKcop8WQK42+kmsUIIvNjW3w4UIVLUCHsp4AB45NTdxItJy240I/MTxB9soe9fXXkvo8w3kFCryz26YotU+p+cy4c6GFyZhnqoVu2EP91+6MLlhUCm31rGLdw5T9PePSRljUc/0KIz/tnAXxaEzdWPjW06JQk4E0Wq9zg0ReK4jhC+pzfoVyJW2ZOkQF+mNrhmUVk4ZOB5uivu6F8kswaehkLPfFL5oqKT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/25 21:05, Christoph Lameter (Ampere) wrote: > On Thu, 29 May 2025, Vlastimil Babka wrote: > >> On 5/29/25 16:57, Christoph Lameter (Ampere) wrote: >> > On Thu, 29 May 2025, Vlastimil Babka wrote: >> > >> >> The slab allocator observes the task's numa policy in various places >> >> such as allocating slab pages. Large kmalloc allocations currently do >> >> not, which seems to be an unintended omission. It is simple to correct >> >> that, so make ___kmalloc_large_node() behave the same way as >> >> alloc_slab_page(). >> > >> > Large kmalloc allocation lead to the use of the page allocator which >> > implements the NUMA policies for the allocations. >> > >> > This patch is not necessary. >> >> I'm confused, as that's only true depending on which page allocator entry >> point you use. AFAICS before this series, it's using >> alloc_pages_node_noprof() which only does >> >> >> if (nid == NUMA_NO_NODE) >> nid = numa_mem_id(); >> >> and no mempolicies. > > That is a bug. > >> I see this patch as analogical to your commit 1941b31482a6 ("Reenable NUMA >> policy support in the slab allocator") >> >> Am I missing something? > > The page allocator has its own NUMA suport. It has support for respecting a preferred node (or forced node with __GFP_THISNODE), nodemask, cpusets. Mempolicy support is arguably outside the page allocator itself - alloc_pages_mpol() lives in mm/mempolicy.c. Although some generically looking wrappers alloc_pages() lead to it, while others don't (__alloc_pages()). It's a kinda mess. > The patch to reenable NUMA support dealt with an issue within the > allocator where the memory policies were ignored. I'd agree in the sense the issue was within the slab allocator, calling the non-mpol-aware page allocator entry, which was not intended. > It seems that the error was repeated for large kmalloc allocations. After some digging, seems you're right and the error was done in commit c4cab557521a ("mm/slab_common: cleanup kmalloc_large()") in v6.1. I'll add a Fixes: tag and reword changelog accordingly. > Instead of respecting memory allocation policies the allocation is forced > to be local to the node. It's not forced, but preferred, unless kmalloc() caller itself passes __GFP_THISNODE. The slab layer doesn't add it. > The forcing to the node is possible with GFP_THISNODE. The default needs > to be following memory policies. >