From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C107D6B6DD for ; Wed, 30 Oct 2024 22:17:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BFEF6B0099; Wed, 30 Oct 2024 18:17:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E726B009A; Wed, 30 Oct 2024 18:17:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9F376B009B; Wed, 30 Oct 2024 18:17:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CAB7D6B0099 for ; Wed, 30 Oct 2024 18:17:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 79DB81C6F5E for ; Wed, 30 Oct 2024 22:17:44 +0000 (UTC) X-FDA: 82731681102.16.A4E9B49 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) by imf19.hostedemail.com (Postfix) with ESMTP id 76BBD1A0017 for ; Wed, 30 Oct 2024 22:17:09 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=fastmail.fm header.s=fm3 header.b=tMlpxp0y; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="H kpgAaJ"; dmarc=pass (policy=none) header.from=fastmail.fm; spf=pass (imf19.hostedemail.com: domain of bernd.schubert@fastmail.fm designates 202.12.124.146 as permitted sender) smtp.mailfrom=bernd.schubert@fastmail.fm ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730326501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2eeGGIhfQ+o3+Vs5R+YZ3pcGBYA0Jz/O5mq++nI8uY=; b=sfuw0oVWvEAzdtt7yfyRNTQDZ8Two9Luhmlivxp+i4ohyNAN3vEPIzmHkzGHMXGjBDpZT3 8/J+1ClMyh+yVQtcc3OQAhYnYuk82sHeAKaIbgbxpIKjiQAhBl7X0+PuIlQeCQjo5jb0hg wfojKDgH9Gn4TDUf8mAAH9MMWAJK9DQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=fastmail.fm header.s=fm3 header.b=tMlpxp0y; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="H kpgAaJ"; dmarc=pass (policy=none) header.from=fastmail.fm; spf=pass (imf19.hostedemail.com: domain of bernd.schubert@fastmail.fm designates 202.12.124.146 as permitted sender) smtp.mailfrom=bernd.schubert@fastmail.fm ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730326501; a=rsa-sha256; cv=none; b=Xn0CVba3Nr3cAFnfSh39sz+jO0BPKr7hanRtorcGpwOzFkzs1VS/rVHUES9da7tMHpZbWq 6YuYnCGDdJ2m0RAzL1qWq6donpZX53W8iK53+hA8dNy2NNquRwtIOdB3Oup5NmkJvpGmV8 1hx/0SlGfjRC56rrMmwk5xiNy4wJAdI= Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 2AF34114018D; Wed, 30 Oct 2024 18:17:41 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 30 Oct 2024 18:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1730326661; x=1730413061; bh=f2eeGGIhfQ+o3+Vs5R+YZ3pcGBYA0Jz/O5mq++nI8uY=; b= tMlpxp0yw0rFA8YwKsWbtd3T3yNnxh8oKrdzj6aPP3FccZMfEGTOVVXchvzRBT7h pGnEIRwEwANQkiZnwecHmSSDpgEflvYk1anoZRzpeOO4x88zUuHua2qFf3CDayFw 6yPFOY5xkit0AkYf2JEeLkZ2vlskgUvq6CAPOiKtpPCvoHGGp+udlQzrL3xIIKxV LgIGO+XyLN6ZTVMh1ZE8vTPPpzblrNkzP5Z1lpT+CrOV65Pht0gv4PYnoPYfkP9g XbQdX+1ACvkgMKvstOfvzYqFxIa7+QkTorkJYhO1OrIiyNZgmPgyohvqfqjhKR6i GbQ46ktw+iTAaWMTmJ6BgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730326661; x= 1730413061; bh=f2eeGGIhfQ+o3+Vs5R+YZ3pcGBYA0Jz/O5mq++nI8uY=; b=H kpgAaJGdGfbnDN0mItiSQOjvgwyohp7TQvuxsxvsMKBSv+XFzu9WWuK+PzYV96e5 W8reEBvmnQP54iLWJcshiJKnwZQ65PQCRGgX9JpWxLqiWyCWCcH7m0QW3DH/SZ7e egVPzxlK3neW/qICIUjxxXem9vTTCYhwbscTQjuVLLWlatlI2+Zw/Cq4BLM1TSNM KRwQ0ZyjQvU/2iHChAgylfOcddxmmzQ2dIOrfu3OeZpOxL6od+CXO5M37ijP6zpn ZWRuycrxJ5Qg8h8tjpIGwwTHlWrc7FlNyhSDUEGExHGQFLxbu4DzEX/ScQrZ30MJ EkhYAUFrBc55fIc/U453g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekfedgudehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttddv jeenucfhrhhomhepuegvrhhnugcuufgthhhusggvrhhtuceosggvrhhnugdrshgthhhusg gvrhhtsehfrghsthhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpeduleefvdduvedu veelgeelffffkedukeegveelgfekleeuvdehkeehheehkefhfeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsvghrnhgurdhstghhuhgsvghr thesfhgrshhtmhgrihhlrdhfmhdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtph houhhtpdhrtghpthhtohepshhhrghkvggvlhdrsghuthhtsehlihhnuhigrdguvghvpdhr tghpthhtohepjhhorghnnhgvlhhkohhonhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoh epjhgvfhhflhgvgihusehlihhnuhigrdgrlhhisggrsggrrdgtohhmpdhrtghpthhtohep mhhikhhlohhssehsiigvrhgvughirdhhuhdprhgtphhtthhopehlihhnuhigqdhfshguvg hvvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhhoshgvfhesthho gihitghprghnuggrrdgtohhmpdhrtghpthhtohephhgrnhhnvghssegtmhhpgigthhhgrd horhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthht ohepkhgvrhhnvghlqdhtvggrmhesmhgvthgrrdgtohhm X-ME-Proxy: Feedback-ID: id8a24192:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Oct 2024 18:17:37 -0400 (EDT) Message-ID: Date: Wed, 30 Oct 2024 23:17:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree To: Shakeel Butt , Joanne Koong Cc: Jingbo Xu , Miklos Szeredi , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com References: <3e4ff496-f2ed-42ef-9f1a-405f32aa1c8c@linux.alibaba.com> <0c3e6a4c-b04e-4af7-ae85-a69180d25744@fastmail.fm> <023c4bab-0eb6-45c5-9a42-d8fda0abec02@fastmail.fm> From: Bernd Schubert Content-Language: en-US, de-DE, fr In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 76BBD1A0017 X-Stat-Signature: 6zrxdt87cbbh64dusqwc1nrny6wyepb5 X-Rspam-User: X-HE-Tag: 1730326629-215769 X-HE-Meta: U2FsdGVkX19YYRiOar3dJ7M3SYpoCiV2ahDSusw33B6gt+q2Y+loxft5R+ssAFRIXZCo07pzYBA7HfaIiEPo1JczzjgHOuuQSP4JxgN0OI0metrKiRkof9qg8iTPeXpkKJAImGPUZQi7492mDlOCwkRjekcaUUr5JssCtMb62R6sfXJT9mscy2qaQI1zMUTf8r0EsbrKdSEwHNgGAF0cE73/GX5l9XGcc5yJ9sWd0kXlYT09QQgbAySYvbEc4Pqt3eAvrFSZaD8rRZnF+DJiItH8+RqQmfzwfZuSaUKUskJ2bK3DY9vLZFvJbrmvyLlGEe5ocXgfwQHGTyiYR/ksyR7Oynqgj1TL4aawIxbEpFyyujZugxBp+rzHw6OO0UtLZ6wWf2pdUGXw2JtrgAQPWQOWzNxBpnmzgAVDM3fDeDx+iGHPYKYDu4cYqz8L5s0gdmfyF6iIC7OQHp0Y5jeXgW40L3EcOv1P437uAFcyweVmQZ0YTUqkvbTQNuSMcyKEJcgJuKTTiqTf3rGWHPfvbr3xyXucwIuGApuoe6u8WdvUanMGQc5Ye6kaJm7veFj+ECXgw7A+4rDJIKXLzZOaqArxvvDl9K+47QdNp7S70k5FibGRskxMOtlFIUyveDsNAZEXrAleWFYYZrcJn375eEc03ZFd8p1IMyhDs89ALDQBkp0cRshKMuRx6nWlyFcp9+xNgLtIEGJbAaLAx0iZwHvIXzaj4qahpJzd+JO5B7RXriU7TBrHLyMoAnkCGhySTkm8IYpMkIDEx885piYO+WAnHBZCJeBxRvIBeIRjS4jeitw9UxhZf4YU3iY8FZ5HTouhU9akwfnVbm0+3ZVT1Rv3Dhfk2E15dScOjciTTTq8kMIu8OdPhl0DeuqaY+HYkAbZ9SuWCFU/PPCLGHWtNohXnlTDRozicHGa0PzofWTHs0lXhOaU6H5PgJ9SiA1U5V8w5SNpkymCOm/xOyo qwVqgOZN f/1oQMu+56dO8zEs9Yz+KJu9IL9VXEG0pLfBKbsaU0oBwuRcBZ/2JwAOt0OsgReiYW6+ipNcFgcyLAzYeozoprz/0ZfwN/0UhAmp9+mqcjzg9161xJxN9UA/lKfe1tIBVw+4u9TM7fK6dZCVcpcDrUKhwn79HC9xnZec6yKc54rNVs60OnmWqCVtBTWgRmNW8DITVdpl3OHJhy87dJcB9u6nCIAgBk9dznxaos+chaP2bSqXwRRs77+KIDgKiCwhvsYyd4Dly0LZxZCAMEDAhJA4Wm+7HIE7REUIvHyD+voXyJKZWdWOdAaJcvudVsFK3lXU5wztyu+cBsFMV2QslOzYxF3hQUqc95ZZMJETUpAE32o/rjANEVm+v9oLi8BzJXDRKotAsulbIwbEjJwbREX5eLRocz55x4bmo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/30/24 22:56, Shakeel Butt wrote: > On Wed, Oct 30, 2024 at 10:35:47AM GMT, Joanne Koong wrote: >> On Wed, Oct 30, 2024 at 10:27 AM Bernd Schubert >> wrote: >>> >>> >>> Hmm, if tmp pages can be compacted, isn't that a problem for splice? >>> I.e. I don't understand what the difference between tmp page and >>> write-back page for migration. >>> >> >> That's a great question! I have no idea how compaction works for pages >> being used in splice. Shakeel, do you know the answer to this? >> > > Sorry for the late response. I still have to go through other unanswered > questions but let me answer this one quickly. From the way the tmp pages > are allocated, it does not seem like they are movable and thus are not > target for migration/compaction. > > The page with the writeback bit set is actually just a user memory page > cache which is moveable but due to, at the moment, under writeback it > temporarily becomes unmovable to not cause corruption. Thanks a lot for your quick reply Shakeel! (Actually very fast!). With that, it confirms what I wrote earlier - removing tmp and ignoring fuse writeback pages in migration should not make any difference regarding overall system performance. Unless I miss something, more on the contrary as additional memory pressure expensive page copying is being removed. Thanks, Bernd