From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C12CFC288 for ; Tue, 15 Oct 2024 10:57:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09ECD6B0089; Tue, 15 Oct 2024 06:57:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04D9F6B008A; Tue, 15 Oct 2024 06:57:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57976B008C; Tue, 15 Oct 2024 06:57:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C68F76B0089 for ; Tue, 15 Oct 2024 06:57:28 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2935041533 for ; Tue, 15 Oct 2024 10:57:23 +0000 (UTC) X-FDA: 82675535250.02.F6A18EF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 4C44114000A for ; Tue, 15 Oct 2024 10:57:22 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728989800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMjIUx5Ou6YSzWO4OiC2Zvx7NxBqmQ61ZAXL0EJQzyA=; b=idNuol5ZoOz9fhjSersziec0vhLo3i84qCLOzNNgf2dLq5geFnGcRUpXp6Aor2ly6iLFJH y6nLum6Vtv3jtq+AZSouiFks39Stzo1t1YoWQ3jzKKwXRbj4or1kmvIihdnJsSbXLUottA WTRjEfYOXL6RyAbpw6blK5xOk8XyINM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728989800; a=rsa-sha256; cv=none; b=QFD5MPBBDbZOzcLZ/8dC/qRgnO7zo72kRAooEMsecXgYzaUaSwCbI/VODUAe4Gjvxom6eD WvwYFRBM9zE6BcxNM8Z0MR5zfixAn3u53x0Ykh2V3pZozzehzUusl1C9DF8qXkakUZbF5d 7kdA0jCEQWuBEqkCaqTp4MPH0aqDDLQ= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE54D1007; Tue, 15 Oct 2024 03:57:55 -0700 (PDT) Received: from [10.57.86.207] (unknown [10.57.86.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 020BA3F51B; Tue, 15 Oct 2024 03:57:22 -0700 (PDT) Message-ID: Date: Tue, 15 Oct 2024 11:57:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 17/57] kvm: Remove PAGE_SIZE compile-time constant assumption Content-Language: en-GB To: Sean Christopherson Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-17-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7ifehax4huhxi336318itfy9eraqskoi X-Rspamd-Queue-Id: 4C44114000A X-Rspamd-Server: rspam11 X-HE-Tag: 1728989842-371081 X-HE-Meta: U2FsdGVkX18zh6+35+TP0blrqOf0yvI/9FIHTaFlOzSflPOfeyb9cjW56JLRXneyb1b2Kw0ob3RpLiSDKpPfAT3CEArTEdtR+fbYsrGH1UWfzqWfVQPRa8D4uRfdDPOTy8Kdg14JDRs/Tf7vYKE05ZzhQBdWNks7Vhyu5PDr4FFDrkvapO3Xa3WwpvQIRl9Nae1cWdjnMkp0jZGl/vShZliuTxdVEo1+ewjRCgAVD3jls55FKUieQC2uHcK2Bn+NtABQIoUoVBvm0T1MRpndKEmjKf9oX4FY+Q4lMZI87JHK1HQuJMA2FjLJ5F7EdqjfkI4p0DazvcOywpJfqcXL0YsFkLbWMczwXEcp4i+fz2LbtpfB1n6SuYmZ2RWchGtWplL/2t1BMltRhImD/T6RZ4J3fiMjdPzZRbTRw5wbbHUTpQbk4nwcVAdr8HvxECVNKeIHS9lafuNaaSBeeS8cR7KB5EHWCISScoksEB7A+PhL7XTXFzTWk4XEXMlInuzQA0qp700PSeLdqmwSR9CtI3Ab2Zp8RcthZRQcM1gIWjCkSdA1/3lbV5DlFKSEZ/HKPH+NJuNoe9GL/vkPA9rvYD9qGeBvvPpiMxMWMCJGF4n812l6ZmmMMv/PkEGY9xHd55OG4yuyH9ExdPQ+WsL/hRw4WreV6OEEwMKvHCp/HT727+Z6sKv02xjJ2FmaUa77LxtW0WAyOPk9dccuFImV/gbWH6QQ3S2DqCYtndjpdbTXQQcOmthUolUMjEjM743rZwK+yUCFwmEx/MueujcVZXHdl5Vy0YG1YN0y0zm0Y3YNKrZz7zGVIcd9vD/VFkVd2L/DiY48dK1mYN+h3l+13S60E3hgFoe/isfYfIHnzskSOLbXNSiLRx0ngd/vWtXmJUqF20V39hdxsa51xeZfxawkX34r2MWYhWNM4ZVJ1MtKbide/w3gEYyzDxM6X2vrXFf0aON8yzqqeKotb3S lCWQ96VX yHUAznuXuLV9cq2MNeXfpTmrlGOvacdOEdEAvOiWQT2jbWwWw5v3hMNJIMNLmbUT/bkR9PaHzkk3YzrBZitspMXRBl9D62og6s/MRLjPe5inj7lUNrfd7vYdTkAWqaVYeG7dTochTZNm1c03TbRuS/9Wh4rzLFu92QX/yjKRkE1HrjtOa/kdmBXXEBqRJ6837wFoiiWqt7cJ6umPIX3QgNdcPALmJFCLHWuIavpySdrh53K8Hd1wmhffAr5Vapeal12GVQmBU6mpOX1lDsfD7Q2KTQeupwi5266wyEQYCYsrSe64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14/10/2024 22:37, Sean Christopherson wrote: > Nit, "KVM:" for the scope. Thanks, will fix. > > On Mon, Oct 14, 2024, Ryan Roberts wrote: >> To prepare for supporting boot-time page size selection, refactor code >> to remove assumptions about PAGE_SIZE being compile-time constant. Code >> intended to be equivalent when compile-time page size is active. >> >> Modify BUILD_BUG_ON() to compare with page size limit. >> >> Signed-off-by: Ryan Roberts >> --- >> >> ***NOTE*** >> Any confused maintainers may want to read the cover note here for context: >> https://lore.kernel.org/all/20241014105514.3206191-1-ryan.roberts@arm.com/ > > The patch should still stand on its own. Most people can probably suss out what > PAGE_SIZE_MIN is, but at the same time, it's quite easy to provide a more verbose > changelog that's tailored to the actual patch. E.g. > > To prepare for supporting boot-time page size selection, refactor KVM's > check on the size of the kvm_run structure to assert that the size is less > than the smallest possible page size, i.e. that kvm_run won't overflow its > page regardless of what page size is chosen at boot time. > > With something like the above, > > Reviewed-by: Sean Christopherson Thanks! I'll update this for the next version.