From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D2AC0015E for ; Thu, 27 Jul 2023 10:20:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE5F6B0075; Thu, 27 Jul 2023 06:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9EF76B0078; Thu, 27 Jul 2023 06:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C664B6B007B; Thu, 27 Jul 2023 06:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B767E6B0075 for ; Thu, 27 Jul 2023 06:20:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 743DC1A107D for ; Thu, 27 Jul 2023 10:20:55 +0000 (UTC) X-FDA: 81056998470.04.3F83479 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 86812180008 for ; Thu, 27 Jul 2023 10:20:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VjGCTE5f; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690453253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OYsCQphrFkTsVVXxjq3sue57eMySXbrEkugySFi/daU=; b=AJGYQVsZlXPtAwoMNY6yruufKo0EUtD2QxVsLbDzlQyQhBHRnXb3DCe1xAFuZPrfBDQUtR F4nZFA1cIPUVR8FbnzrDfxYhWyety96UqCOnw9QtYk2xpTfvm9y5aLNOWxmIT8Wh3YwrEF xfD1YH0XooIlANd7wFiQaGFNLixMLLM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VjGCTE5f; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690453253; a=rsa-sha256; cv=none; b=GwR9cpuNJ3mG91iZ/qoKeRhRT16r0bgWi6IY2eihXBgw/5Rb4DFKFGDGG3wUxwmivPr7kp BBShHZ9cK/Xv9o1JqDRm4/ZWs0/6ddTcOAYOELRNasdgvUmWM1iUW2BmmbMnbK4VSqab7I GrSS2vRmCulJzhLx1NA98NW+j31hv3Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 44B6761DD3; Thu, 27 Jul 2023 10:20:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9266C433C8; Thu, 27 Jul 2023 10:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690453251; bh=Uv0jglg4XDxm5uiOcl1Fs0VDdmS3vnj5J06IHksC3j0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VjGCTE5fXWQGMkstr5mWfG/olGcukHbx9MJ5gIHM1kJfwo/BiFcjiuEaiA2TxQad6 b/CL9D78jYHhDiLBxLD9gCBB6CtR9Pngnq1E4RM+cWQl1ITCzXzhPBEMorh0UStJGb V5QypMia7H1mT7Yv9W7oIRfkDRB1G3xJIxfo7Y/Lymzj+mXx3lcBAFmRFbWxhh8lk9 h4N9LjcMkMC3/ZfJEah0qCVly/fWQ4ostsbFgLI1m7GG/WQbkHJ87BAgn9cUsNUERW XrnUyEDaK9+tFU+Iukly/qv+tfC9IZiVkgJJJYsmEkH+2gmJEivzAz4IAcCpkEsNUW WY8rxT9ubVHrA== Message-ID: Date: Thu, 27 Jul 2023 19:20:46 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 28/49] dm zoned: dynamically allocate the dm-zoned-meta shrinker Content-Language: en-US To: Qi Zheng Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-29-zhengqi.arch@bytedance.com> <56ee1d92-28ee-81cb-9c41-6ca7ea6556b0@bytedance.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <56ee1d92-28ee-81cb-9c41-6ca7ea6556b0@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: wknr36onicrksg165txi1cwa455m116s X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 86812180008 X-HE-Tag: 1690453253-155269 X-HE-Meta: U2FsdGVkX1/p3BjfDyP+McOipkE6VYOTbopLezl1VwvdSaqU3hNOKzCNdJgWKKeBxzet3+I9AW3PRzGd01ygiT/8UnpiiRMh0nSfUWkbVOx8PKPSEkD8Bi2m/znyFP/LRzyp+a/8nYXEN7Q69XB3FQsc4MA9N5+5J+SV2L9NkjZFdU2UW5K7e6xY0m3Bp4LX8Qk/yPq56DOyJYdMvr5u5H9YA+5df15YUSCmXbKMLId1cWCRR9GiRkKJdA0TMtzTo6pHSl1B6MtM3uPvMcM3fS1qdFg3HWsFYyK/YbcqQbsb7c3qQ1QOO2FgRrVW7egZr+q4boftJS9oJlGDUNpktMbIt3dlzC3/K6b/CtFLLzlWdQeEEUwh1IFkiN0Katr1J+tvpY5zcF/CFQ4zihwp7M7VWE6TJiJdu+TKDSTTlrRqAn3qhhl4Wvy4Vi2YFC01RpuSBfgf60gz8TwGUu0XHeL0/XLocTa+yu0WNvHxbvGhccq1ybFNC5jhObUOhyGt/2RlSseqhHPz27I1sBNshrNMdrjIBXw7LdBefe0cHjNPbi/Bdx+2R88zPZgoSth/pGI57UNeubT+gMGBUSKHwOribSE93B1p7GPiYaRrUdhj/LRQpUYRokEJQQSGzYx+lplJ5oyX3GvnIJY/ob4CQBShsp+Yab4Z/PwnRVrb55n5f8MTTduihzrE/TsSXLbhFWAbGO/4VjIZWRjcocv+UumMuiSrI8ifqWvMiWKC4wRQjrkQREGpRJHlV/3kseqCqV+UVsnqlbuxrPRZtkBWZnk3JMunGg7SDUdreDjdVGzFYH47M8kWLzKbaBRWlRkhsDCxycmQtnCJqoBCsa9ckW+bocE0CtoFxUkbcFW7rHLOLp/jDeeHDVp6vwdHhQNSIl+wy/GokKcFs382FWMRYPYYRQpaRR3qU+rS4QYOVcgdMKZECkE1KxpWzT/EYfwMT3Tyxfio05oGj86SCAi 9hakipEk vzFa6kn6Bfapf6GRdoIGOx9ulGqKeN0tNi/Cv7geVhMRxITvQkjGeMxBQfbxZPkSvfwcRx1A6X29NN2HPEKzv2J3gW/HhRbo1r6TJv7XcmXMKIb1epFEmzfyyRNzy69zH7KMh5z1gs5lPVCU2IQPYAdHFsL7AXw2elOcUpsLUX8w9xcgZCGVqfGrjksODbVGWGXe7bEJC6mFIIXQgqaQAfwxRiFof29sIddFXvQC/KS1JhmYIyuE2AtnPmelh+vK3N0aHywWI0yewguihHB8Wr3QgeTaR/15S6CHYp0MOnW4DG4DRceiXm34SKh2EffyNF51VnThehYadwtg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/27/23 17:55, Qi Zheng wrote: >>>           goto err; >>>       } >>>   +    zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; >>> +    zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; >>> +    zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; >>> +    zmd->mblk_shrinker->private_data = zmd; >>> + >>> +    shrinker_register(zmd->mblk_shrinker); >> >> I fail to see how this new shrinker API is better... Why isn't there a >> shrinker_alloc_and_register() function ? That would avoid adding all this code >> all over the place as the new API call would be very similar to the current >> shrinker_register() call with static allocation. > > In some registration scenarios, memory needs to be allocated in advance. > So we continue to use the previous prealloc/register_prepared() > algorithm. The shrinker_alloc_and_register() is just a helper function > that combines the two, and this increases the number of APIs that > shrinker exposes to the outside, so I choose not to add this helper. And that results in more code in many places instead of less code + a simple inline helper in the shrinker header file... So not adding that super simple helper is not exactly the best choice in my opinion. -- Damien Le Moal Western Digital Research