From: David Hildenbrand <david@redhat.com>
To: Rafael Mendonca <rafaelmendsr@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>, Nadav Amit <namit@vmware.com>,
Peter Xu <peterx@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Christoph von Recklinghausen <crecklin@redhat.com>,
Don Dutile <ddutile@redhat.com>
Subject: Re: [PATCH v1 1/7] selftests/vm: anon_cow: test COW handling of anonymous memory
Date: Tue, 25 Oct 2022 09:05:34 +0200 [thread overview]
Message-ID: <b9e88ddf-e0ac-ce81-d6b4-caf70772c455@redhat.com> (raw)
In-Reply-To: <Y1bD+8CMzlqkbPwU@macondo>
>> + /* See if we still read the old values via the pipe. */
>> + for (total = 0; total < transferred; total += cur) {
>> + cur = read(fds[0], new + total, transferred - total);
>> + if (cur < 0)
>
> Hi David,
> I was looking at some coccinelle reports for linux-next and
> saw the following warning for this comparison:
>
> WARNING: Unsigned expression compared with zero: cur < 0
>
> I think 'cur' needs to be of type 'ssize_t' for this comparison to work.
>
> The same warning is reported for the variable 'transferred' above, and
> also for do_test_iouring() and do_test_vmsplice_in_parent() in
> "selftests/vm: anon_cow: add liburing test cases".
>
Thanks for reporting! Indeed, we need a signed value.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-10-25 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:01 [PATCH v1 0/7] selftests/vm: " David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 1/7] selftests/vm: anon_cow: " David Hildenbrand
2022-10-24 16:57 ` Rafael Mendonca
2022-10-25 7:05 ` David Hildenbrand [this message]
2022-10-25 7:07 ` David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 2/7] selftests/vm: factor out pagemap_is_populated() into vm_util David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 3/7] selftests/vm: anon_cow: THP tests David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 4/7] selftests/vm: anon_cow: hugetlb tests David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 5/7] selftests/vm: anon_cow: add liburing test cases David Hildenbrand
2022-10-25 7:10 ` David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 6/7] mm/gup_test: start/stop/read functionality for PIN LONGTERM test David Hildenbrand
2022-09-27 11:01 ` [PATCH v1 7/7] selftests/vm: anon_cow: add R/O longterm tests via gup_test David Hildenbrand
2022-10-19 12:31 ` David Hildenbrand
2022-10-19 12:33 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e88ddf-e0ac-ce81-d6b4-caf70772c455@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=crecklin@redhat.com \
--cc=ddutile@redhat.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=namit@vmware.com \
--cc=peterx@redhat.com \
--cc=rafaelmendsr@gmail.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox