From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CC0C433F5 for ; Wed, 5 Jan 2022 06:24:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EC0C6B0071; Wed, 5 Jan 2022 01:24:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C0F6B0073; Wed, 5 Jan 2022 01:24:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 715916B0074; Wed, 5 Jan 2022 01:24:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 617D26B0071 for ; Wed, 5 Jan 2022 01:24:53 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B8B4181A3488 for ; Wed, 5 Jan 2022 06:24:53 +0000 (UTC) X-FDA: 78995245266.06.BEAAB63 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by imf13.hostedemail.com (Postfix) with ESMTP id 44C3620006 for ; Wed, 5 Jan 2022 06:24:34 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzXs0MO2bwAnDu2H5GdAUHsX1ITWuHFDYsMZK6B1YYwfGU6C1gNM/fdVatjVRMxXTuYqadqUVN3ynS5XY9qeewrbag+9lhoelFh/60HG/18o1NSdYXhUpQzhlEYg46js6yh2CmakTKySXLXtw4WEu6Ayv39buLrbucMCpDIJw1KnM/PTFMEN3tAlyL0eq5EVWh/oDG8s6Kjgk/MEeutTiB5gW2MP5dxXzHXhP+NvKJqOPtm7iq61sZg+qSUyAA8x0kZbXy1Z2FM22gDUF6YUzgbTV99hjW5DmPEtekrjO+ULv7S66JfqMwXeaIqU8eLb8Lkf9xJ7ukbo2PcxI0HBKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9R7cCTkPdzKA5dQ2pxMQtLaQE5oOYb/II89EaJPz/jk=; b=O0OofaormYq3RWX2oD4zekeIB77iCQ154qFLkYDFZ8lHZSLoP+nvydqxBmRR3od7uXJCsQGmVR5AXTjLJgGwzkj9lIycvuhSqpq/ebsEItiYbFP/96OrrX2aJRIrHHyGYvfio1IdDCrVBvEksODIz203W6xQEahRhR/DTjUw914Dhu3s5hR+So12N9An7PQFxRzCYgv3Y7j5sue/A9OjXGWFkjpNKkTgd8YK4PD+iqXKsuGHE3ujobvHyIz0aGo5TYT0ZsW6NygRv9IrApYxk4K83sNk/eR9rQKDE4o9BirWNmuw1Pz5EmiDeYi17Fyy6VuYgRyTTVFbNqOO+WYIhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9R7cCTkPdzKA5dQ2pxMQtLaQE5oOYb/II89EaJPz/jk=; b=WQ8ZoxwVI17sOqfTariLGaTnLByKmhotAgrOvZXs0C11iKaTwToesOr3XeKIrGMLe6a4427V5M5jrtNGEXtMEPB+USLNQ78VaqiXFC/3oApr5s5Jr+unW7o/2J3+FI/mK3GSQwTbVwQNqsPGc7diuzSBCJ4qvbYyb6fscUbPiiMyS9o71AKtRbFODiCeO9k6sN3+TYFDxBDRvfcTTwCijJlsZ4VW5jXvkK4dZxh+pYk35YYB4I+j6VTuzSsCN7NTSHjsy1Rxhr1s1e9sXXJwYn/URRYzb49UAFjSj1HUQzzLezZMUteXwSO6Zc9TIepVSTLFzRRRgAcSb/cTHsbPrw== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BY5PR12MB4161.namprd12.prod.outlook.com (2603:10b6:a03:209::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Wed, 5 Jan 2022 06:24:49 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7%4]) with mapi id 15.20.4844.015; Wed, 5 Jan 2022 06:24:49 +0000 Message-ID: Date: Tue, 4 Jan 2022 22:24:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 02/17] mm: Add folio_pincount_available() Content-Language: en-US To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-3-willy@infradead.org> <20a06269-3bea-27c3-568f-6459fa3374ab@nvidia.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR05CA0093.namprd05.prod.outlook.com (2603:10b6:a03:334::8) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d412ba8-3a4b-4e89-88b8-08d9d014136b X-MS-TrafficTypeDiagnostic: BY5PR12MB4161:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYOzMtYs/ENKoSqJBLnv7YnDXuog9boPVtSvTyFKOOwq/o2V3wW47rz9iUGMjYy5PQGmQNdFMqw/OE52VDqq3Gd9zUwr5f5vQIroXj6SPiWoWH/B+ERyf52wwI8VH594Hw2G9nV0suazBWf7fjiJKqXpR2kBjyI0o7ZsVvyns5EDyCQ701/PsGvV+/5WB43w1hrZNtRE2eWGZW/v8+MiGeuu/Bo855704EOwrB5xdsVK84bebMBgnVHHJxkSeR60VMZX3iY7ALqEO7kulSEHuZADqyfiLjY4kD6bSX/ixBB2kOfO4OooVckkuBzgoFdAXLnXOKHowf+2TBwQQAuaSPsUr33L2Nr2UVX7Q95hOFVySYQMQfGyxXD3tVyhaKvAcw3oKbw++tR3nQnuPeKkJQuGfQJymcUEP8nq5TG5OgBdDbrwIcUsBcztL/NOF2TtLbaLiT4NQlBmLn6EBdQaMSUdCzlVCBxQVDU/r5CloHZxik29AqkFd7bnBu7RehqrcKYV9UQEjmFU3gzHTs6lRpRIeVtVNcrzldmKBOlgHh9yG2nUOC4NJrbWrq0Urz5pimdGfUMv1K7ne0ub7HtJxB+zt1+L/YDRXrsyPcddNlc/M7bUMpD4zVIAA857To/oOH0eWDJvHme5pOgeYr90kXwN4AQqo8PfyylugMSFH7IcwZjVQkYCIDKNRvW+Ntl3Xd78erqwYS4Pwc0X5YlmBjVo64JZW3BjpUVE+2hntZ1pXmevfjsMd69zYjq4Cswc/jPT9JirccwaoZqAbUTFnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(26005)(4326008)(31696002)(8936002)(5660300002)(53546011)(86362001)(4744005)(316002)(83380400001)(6506007)(31686004)(508600001)(66476007)(186003)(6512007)(2616005)(2906002)(38100700002)(6486002)(66946007)(6916009)(8676002)(66556008)(131093003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTFaaUhFT1lpLy9taG1EU1dKaXZLSlJxbTVJYW84VFUwMlkwMUprZkZVMFMv?= =?utf-8?B?R0NpbGo4aWJFVmNoeTZxdW9wUkR5VUlncy9yQklMblluVnQwT2xiVGV3aXpM?= =?utf-8?B?YTZMNm9OMjdNcStDQmgrVHh1bmxKWGZNMGJFZDZ2bzg4SHNuN1FhcGtPWUtj?= =?utf-8?B?TTBaa3NRN04xY2NUL0J0QXJMcVFIb1NpOXU4YXorNzJtREM2NTBVWVR1OVpT?= =?utf-8?B?UlN2NmJ4dlNqbFEwb04vUG94UERUSEs3R2hWQ3RxRWRUbXl3ZlRHQUVnd2JU?= =?utf-8?B?NTJKVHNVVTVYeG5rQjZUaUhiQ1EzeThSa25tR0QzZkRLOG1NczM2Qy9WdEg0?= =?utf-8?B?UGFmb2NNSXBUR3ZBYUk5eUFEK0kzM3FJT2diWDNNd1hEUWFlcUhsUW5DS3VH?= =?utf-8?B?am9JSm5jakZQU3RZSzZYM2VrbEZUYzBaQVczaC9sVjVnOVd3L1JkNFJURldr?= =?utf-8?B?SUxXWHlzYTJuOVVKSWZNU2ErcnIxdThoVURJL1lYNlNDMHdMcTVvTml6Zjh3?= =?utf-8?B?M0tSZGdaZmxxWlo3L09NTDZOd1ZEWDYwclRqaEp2L3QzTC9CTWloaEFtMjIz?= =?utf-8?B?YVJkS255YjBxTENFdzNROUdYK1c5cnRJaERUOWhoL2tKN0U0MUdDUHZ0NXdC?= =?utf-8?B?VjFLWEZYakZocVppaFhIOWthWXZpa3RLM0g0MnE2UmpCVnMrTFg4TUVHUXZa?= =?utf-8?B?UG5jYTNiWG1aS3VaU1Vqd2ZxRmJYL1crN3l1M2huM3U2WklzVm93RzlCNmtE?= =?utf-8?B?cFQxZUNMMzVCL2tnNkc2N09KLzR5SGxzODRoU0NJSGRoaU1OUDRmdURTbmc4?= =?utf-8?B?RGVZWUpma3JlQWVTeU1oVVV3VXFiSzRDMXcrMm4xcjNkSW0xeXR3N29QWEVm?= =?utf-8?B?VW9MZmlBRkp2ekxBME5veGxlcVB0OTB6bmsraEQ5eE1QVjBjdHVDZTFEWGEw?= =?utf-8?B?SVRNVWl4bkc2TEdnS3FrK2RsL3pCUGpmTmpsRCtlY0pWazVwWlBMRkNpNFho?= =?utf-8?B?WDBoMUkxY1dhbXZndmJPL1Z4RXhZMVluZmZNK0REeVFUeWZ1cDNCdndFdTRy?= =?utf-8?B?VEdJWkpkcFhwajlpN3dYb2V2Mk04U3FOQzBkMDdNTXExV01qZ0tZUndPOUx6?= =?utf-8?B?U2grN0VIR0g5aEVydUZYTFJXODFxcTNVdHB1NlNmNVo4OHo0M1NockZtOFBB?= =?utf-8?B?RVd0a1ZPZzBzaVFUY3VSaW5XSVNoN3dCNmZKTm9ISXZXRm5WZXY5U1I0WnVy?= =?utf-8?B?NHZvY2lFV1dPSnZtNkV2QThpMFkxOXZ6YlF4anZpUWdvUW5haFJCWUtaendo?= =?utf-8?B?WEdOSXh3UkxudG9udXcrS1RFK0toRFNWOFRKQTh0Nzh5VGc2QmplT2VRT2FF?= =?utf-8?B?WlZoa0VuZlVNWnMvWFlzOTk3dXpJZFloeUdaSU90dVJ0dkhpZXF3ZjQwbWZO?= =?utf-8?B?emtaOE8zVyt1REtiSy9zRFREQlJ4Wkkxc2pLQ1J3ZVdmQ29aOUEzRmZMRjhB?= =?utf-8?B?R2VWOHU4cTQyRWRtZkN3VlAxT1dkU3JTd01ka3dpa2ZTZnhBOUpOZm8ybVN5?= =?utf-8?B?b1doZXE0cW5BeDd1UCtiUWd1SG1rSjJPZWdDZHh1MHhTdW4veWRDQUhPdUxI?= =?utf-8?B?NXYyRDZabDhPeUZ6S1FRQUZhYXBPTzVnZk1lbk5YY2Jmb3R3aEJmeEorRWV1?= =?utf-8?B?cWpEZGsxWXExeC9hdXp6YUdwQU15SWU4NVVoL1ZQdFJTcndhRUVVUUpsazFi?= =?utf-8?B?S2FIM1dXV2NneW8vbmFLY1dCUXZhNjFhV3RsU3FGNEFwcWtqOVBGdThKcUZ6?= =?utf-8?B?TFhWODhSeXVqRHViYUNGcVFIaEdrbWdYZjEyQlhodXJkL0o5WGJRQ1BVUkpM?= =?utf-8?B?bUYvY3VaL2ZKQThUNDJKeFNaR3dsbUZkTERCS1NzUTkxQllxWkpOVThnM0RU?= =?utf-8?B?aC9pN1NHQmt6UEtNZityd2RIdEhaeEhUalJ0Z29sMlZ0ekZPcmY2cWdacDRS?= =?utf-8?B?Ly9ERVNhdjVOdFFycW4xS3FnSkxyQ1B2VlREQVFCcmFwb1FLNzFQbUxTZDls?= =?utf-8?B?dFA0emR6Q2NueTVpK0daQTkwUzFXZlFQTGd2MUliMkpZOVV0Mm5SUFA0c0E4?= =?utf-8?B?eUUwZnQ3NGxYQThnZXdwZHV3dk1SLzJVcGhGekM4aU1Fb1krQ002dlJJdi9t?= =?utf-8?Q?rpflx+JfONMj9I+d6TPoCh4=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d412ba8-3a4b-4e89-88b8-08d9d014136b X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 06:24:49.5248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bfi9c5b+/ttyDgI+dEBcqTpkN8xYA3mS3E1OJDHzbqBq70Gg0+/rKUgUTymbJElZupt5ba2m2dNJJAyVXMmqjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4161 X-Rspamd-Queue-Id: 44C3620006 X-Stat-Signature: ub1nbf5qpojbgid8x7mgr7w8jkibp7f3 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=WQ8ZoxwV; dmarc=pass (policy=reject) header.from=nvidia.com; spf=none (imf13.hostedemail.com: domain of jhubbard@nvidia.com has no SPF policy when checking 40.107.94.56) smtp.mailfrom=jhubbard@nvidia.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641363874-662025 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000098, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/4/22 21:04, Matthew Wilcox wrote: > On Tue, Jan 04, 2022 at 01:40:36PM -0800, John Hubbard wrote: >>> - page = compound_head(page); >>> - return PageCompound(page) && compound_order(page) > 1; >>> + return folio_order(folio) > 1; >> >> I see, no need to look at the compound page head, because folio_order() returns >> zero for tail pages, and neatly avoids all of that. > > Did you mean base pages instead of tail pages? A folio can never be a > tail page. > Oh right. I was thinking (incorrectly) that there might be some cases during the page-to-folio conversion in which a tail page could sort of slip through, but good point. thanks, -- John Hubbard NVIDIA