From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BAEEDEC63 for ; Wed, 13 Sep 2023 14:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FEF56B0196; Wed, 13 Sep 2023 10:31:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AECC6B0199; Wed, 13 Sep 2023 10:31:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 777286B019A; Wed, 13 Sep 2023 10:31:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 679716B0196 for ; Wed, 13 Sep 2023 10:31:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2EAC2140E68 for ; Wed, 13 Sep 2023 14:31:20 +0000 (UTC) X-FDA: 81231811920.30.D5A301A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id 9CC1512001A for ; Wed, 13 Sep 2023 14:31:17 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NeoBvf5V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="otSpZk/6"; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694615477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EY/TxriRyLcQRT/QMGb4HpluzBBUSCH2N2LP0RzmfO8=; b=2fCsacVThW3WndpBg0dC4uPP1CrFK7lJLMX1PZhmwAzmFocH5nbIx7n73IugPBfG+OE4PG ZXcvqAYVzwhFdvBHJupwHb3rqhXI8eY1hIW0i5RTK5DIRbLIS9eAyY2BlaWi3sPLI1SQjZ y68rjEXhZqWcH55F2K/l0mCofEmWeqI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NeoBvf5V; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="otSpZk/6"; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694615477; a=rsa-sha256; cv=none; b=mb1v0vY5bOf3KAUAoeGqA41A+oRYVkXRgt4eHujxuqskOveRypyS4o1QEcXmOx7SM9i2l4 p88xfeThKBVCZpHpMS9A2+n6bXTaXKJQgvLlMYR1px31/99pV64iEFxdrmCmrYDgBHRuwf XbBnW7oxOZm9ECysI+de3IdE9LHtLiA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67772218EC; Wed, 13 Sep 2023 14:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1694615475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EY/TxriRyLcQRT/QMGb4HpluzBBUSCH2N2LP0RzmfO8=; b=NeoBvf5VsVcl9T2Kn2QDODTiiC7qSnHJx+vjBBavdg/eaixbkUXEyz7gvKNUoP0mT2Pz9R t5sej4mVeuZzT2wEbYDB3CaxQLw7c1mFuTqal6sojjcFlUbWPOhHmj7UDZxSXM+nwTeLB1 34ksygCii9pbj8b7VG2iXea8MxacYJ4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1694615475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EY/TxriRyLcQRT/QMGb4HpluzBBUSCH2N2LP0RzmfO8=; b=otSpZk/66fLfB3CFnrVlBquoqW6KRhdLNyBirtLyf/jREhi1uEp8DdaQjY11JfLOcSxy9U ADnCwyuUgNT3SXBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4425813582; Wed, 13 Sep 2023 14:31:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JpOOD7PHAWX0ZAAAMHmgww (envelope-from ); Wed, 13 Sep 2023 14:31:15 +0000 Message-ID: Date: Wed, 13 Sep 2023 16:31:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/6] mm: page_alloc: move free pages when converting block during isolation Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Mel Gorman , Miaohe Lin , Kefeng Wang , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230911195023.247694-1-hannes@cmpxchg.org> <20230911195023.247694-4-hannes@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230911195023.247694-4-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9CC1512001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: eprqtaez7ojsjnkzkha6js1bw1jtmbea X-HE-Tag: 1694615477-506764 X-HE-Meta: U2FsdGVkX18ABV28eDod4EaLfCqhaiIQYNa9mAzBb+Xz2jXPQCpdQ83ykmXanAimzLq4Mn0yZsn91UICyObAaV22N1AwlYGckmtGKRa4NUwtM0/yBbbTG0ADEbsqFfBqe1criNv1c+AHrB/nVd48F6W/mGFeDfyRqEzVIt9nBAjye7ojmjKdKRqw9nUqyIR8qEO92X8/KDKMJ7+wAglcpqIn8RVBJbKVTStHDVtsebgI3+uc6IQZfvrc84EU02Hu3wykR9Vkwp7Y76FcPwBgKDFuGSkibWger8kSpe1Di26Nz5hmK0CtvF+NEwLRpNMbfqJ3FlsXLQ4+T40drTDKNAVkXtxdw4bHo8dMjA6OAOeRahy1VBwSlBj3dZuskLaIrifmsgnoEMR2MsSM/ghBMGOble2yF1Mk4cVyNAWzfyRh2cgZxlQ/vnucOAhm73GXA1K7Z8MWaQn0oHYn+C2enW/bWNngyq+NysADX6uwAHlC0JE0Te4JorhDv6YkEP639AwK8bcBsKHekgqEutR7bE3FIVdQyyPI6cupB20pEPzhBEjzg1EMzqjVfaQdoEIggYgniNvPd/4c249qVQTjhBefhaB1jK1lTzMUEcR4h7qz6/DrMQjz08Edm3BiEq6gjqrIyiGNnf2Eamjg5g1OI2XeYZMFFyf5yU1Ay5ojUP9SEROi1ex/OLuNEx97v9eaQrp6S1Ghtpkedvrshim8dd3C4x47Vx5e5Iak+DrEY1kmNylsVRL1bYwa4KFYDupCJjE2Qz3Jix9La1+1dpmQIAYb/jccrYsnmroa85fcZkKeS+XyVpW/SQuUKAY1wBYN+zTbuG1zWWDNyKipKJzfEm1Iwknesztm1JQCYJItciZtsGkLyqqVlUUjcWXyyZy3qKJqyh9sRuaHv8iBj+KUQE1fKxIGApWHBv9bERXV+NCSG1kSZX4z1iuT10Z27im8Puc1aeuJOndeLK2Wx3Z PoFmVCeS Z/axv0AOV+AHUCIf0lgEh+PWqYiqCoe+7s+9RAf+Gu6yAon9/61ME5+HtDmKbzAMJ345AfFap3q8NOd5PDXYuCoORlWnfUPJD+mOrvICuLt+dFNMtPrj1+vnzJ8e/Ru7lbNtR9dy94Iu2Ze5jGyMlTOKsB1ElRwibClTTCstpLWStfV00Hq93lyDxi590z6dvrtl1dpI4CpZAtn7QmP7484EqRNtvihlgnedzR6AhBfSI1GsBmME+yFiP3RkoPIQRD2eA/MRj0xWaczf6RfwdVjmNyEutOmdrS3sMjlivSh1uOV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/11/23 21:41, Johannes Weiner wrote: > When claiming a block during compaction isolation, move any remaining > free pages to the correct freelists as well, instead of stranding them > on the wrong list. Otherwise, this encourages incompatible page mixing > down the line, and thus long-term fragmentation. > > Signed-off-by: Johannes Weiner Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3db405414174..f6f658c3d394 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2548,9 +2548,12 @@ int __isolate_free_page(struct page *page, unsigned int order) > * Only change normal pageblocks (i.e., they can merge > * with others) > */ > - if (migratetype_is_mergeable(mt)) > + if (migratetype_is_mergeable(mt)) { > set_pageblock_migratetype(page, > MIGRATE_MOVABLE); > + move_freepages_block(zone, page, > + MIGRATE_MOVABLE, NULL); > + } > } > } >