From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FA1CD1284 for ; Thu, 11 Apr 2024 12:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B347D6B008C; Thu, 11 Apr 2024 08:30:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE3ED6B0092; Thu, 11 Apr 2024 08:30:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 984FF6B0095; Thu, 11 Apr 2024 08:30:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 767DF6B008C for ; Thu, 11 Apr 2024 08:30:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3EF441C0DB3 for ; Thu, 11 Apr 2024 12:30:42 +0000 (UTC) X-FDA: 81997184724.25.79DE7E3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id E3A9510001F for ; Thu, 11 Apr 2024 12:30:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VkQluPua; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712838640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y7TwXs97cGKCSPlZat8D9T+J4ssIvDgilxKFcQCp65o=; b=yc/MMmyTsh8C+VvINhK0OZKxfNhYmfUyZ/Av6Q6lHL9iqii2DYYjd0ymmsjsCm1rG3jjtm 9Ng0XpWO3TvAGkLhm/bpzzVLeQHHdFP9Gwm6KOh8zNCYuxI2Rt8QIbBfu+DrqjIIRo2aSR NBqqKI1YNi4Wdx8Gml4ReAhc6jJY8GU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VkQluPua; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712838640; a=rsa-sha256; cv=none; b=3sESlPJpCCdQ9UDzEqtBsInR/biSmKIlcmiVlZ68XOd4s1nyr5mTuLcdHYj9TtdCchg8sr AXtSRUDgZdpAb23HdJ4YsiZo632dFQ38viIbdMGXsJ3BCtd5nG4jDtK8JlILuWoDRRdtLn JJ3Ua7zouD/luFUX4Qb7D5wSoeDxktU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712838639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=y7TwXs97cGKCSPlZat8D9T+J4ssIvDgilxKFcQCp65o=; b=VkQluPuaQCI0On0fVS9vc8g4orgtB8jg7LRIM+8Kqe3KPSXQX+AxzQNvr6fcQVM+l0J4Kf gNfs1HdSKGFnhRpbId92+qAWwYka+Dv3Dvo5KY2Wj8WxQNL0G8h/TiVVUXQ2WhNK6EjGRs m+G4Cp4YKkg+3PgAy6q8ynfho0mIw64= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-e4KxYsRWNS2HXrWOqcLL9A-1; Thu, 11 Apr 2024 08:30:37 -0400 X-MC-Unique: e4KxYsRWNS2HXrWOqcLL9A-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d88bc8e8a4so39727731fa.2 for ; Thu, 11 Apr 2024 05:30:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712838636; x=1713443436; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=y7TwXs97cGKCSPlZat8D9T+J4ssIvDgilxKFcQCp65o=; b=IAIwRK758FfqrWZzIiFQT0DLU/xETcc4Q/meQi7rieAdnRCpNjm3GWwkZZ0ZhHqKZI CeGynDpc0SP+LkI8/oGCcdwlheVOE92syXNat71tQdXquc4Pvf9ALXMpPsQI+ceBKfq/ zDxR+/KfD47eO+JJXhM9WkHNT8jamKxRIqhOnIvNwZvj8OlDUmCisDFl6z8OQTT5iXVi vVojEU0EoqzmypxuGoN4IXmXdrgJypkhzQDHxJ58AnEHLx3yqGXLjzvAjSqTkQTYdyJA UWynD4N/Y5xL7w3VUCBQMAQ9D1FRQS7R5VEiCluft4K5rzLmrC0QnGaRM6Bcf6ZUiBg8 bkfg== X-Forwarded-Encrypted: i=1; AJvYcCWwy3qTgb4f1Ck2LNqBL6wT6bZQ8cch1b3tl3xI0TXIxOv1x5t+8z/tGOg2fpfdoIhJc4nTuGps92dqV1Oe8nhAor4= X-Gm-Message-State: AOJu0Yz8HappYB2ndIk52xBNvk34Av7c468i0J0E8w9YGNpt7akQz8aj mAcipVwW0prIc2z2wD3jlQJDI04AA9asrh8Zv09LsXjG8SQibY+Wr9UZjNKtklfx45sFsa9uQzC /qilPD6aFnFZP1LsQCi50SHFz5zhhed9R72jfAebj8I/KVBpW X-Received: by 2002:a2e:98c7:0:b0:2d8:dd28:8748 with SMTP id s7-20020a2e98c7000000b002d8dd288748mr2945371ljj.1.1712838636015; Thu, 11 Apr 2024 05:30:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNhbKnm91UzHHYzeclwSv0GXVTE0gXbsFHBBDgl8GE19+0m4lF65G2tfbEM69kj3DPzwh/3g== X-Received: by 2002:a2e:98c7:0:b0:2d8:dd28:8748 with SMTP id s7-20020a2e98c7000000b002d8dd288748mr2945334ljj.1.1712838635554; Thu, 11 Apr 2024 05:30:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c724:4300:430f:1c83:1abc:1d66? (p200300cbc7244300430f1c831abc1d66.dip0.t-ipconnect.de. [2003:cb:c724:4300:430f:1c83:1abc:1d66]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c1d8f00b00417e134dd2dsm1142306wms.37.2024.04.11.05.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 05:30:35 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 14:30:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Andrew Morton , Peter Xu , Sven Schnelle , Gerald Schaefer , Andrea Arcangeli , kvm@vger.kernel.org, linux-s390@vger.kernel.org References: <20240327171737.919590-1-david@redhat.com> <20240327171737.919590-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E3A9510001F X-Stat-Signature: dqk7b35y6yx35xhjsdqc4u9c99o4fuzf X-Rspam-User: X-HE-Tag: 1712838639-509865 X-HE-Meta: U2FsdGVkX186B4Efy15ogTKmTAF1QmDk5FKBz4qhG7yBpGofcpeU9rM0jUPdJK07p3SioCeufVK3QNiHPBvaFHDV61W9BautSUpWmAXLyMG8ODDGtEuizBcz61q31Py5LibY/pLnq9xF1ma/GCZmlaWlxNXuXUZNyaY6PRLkeGRDLYZb6Yi9AMEFUy5FQq/qwW8d10xz8D1iXPasMmnoHN19a4ErG30ZENDGNWqozZ2OARwrYeUM1pYVGI9nB/a2ETF96a7ttFmtS8JeDVcX01j9Natk6I1YKOnYFct4TYKEus7FYqbTGG/D9kypLSXbRRzdxLWD5qs7kJr38u8/IYv3Rb7TwdlJ3QEPCKksxpAc9TXwxNRzuAhnm0y7x7E6xRtm9ddEUF37OD74ol/UPmvPAbJeK23CgIbfrteUV9YRzk/8BrmPlhNJySAChAxDzGGnyiQVxHHrvzUZnghz4TohR6bbvpsoTASU6VOkEGkQIU2/R8f99K9smNkB06ryJC9J1fwg0ex8yKfOjmhkKjUkr4Hz5ghgCVc/cT7fdaFttQCWW02xv39StcHXGJgDz1SXWx8ThT8lR3k0HzvRrHlfduswMNkRZBMD05T2rxnDbNaWcPJ7wm9AumJOLgMn6S1oTVaj79UneJKDUnZaBER4RRVCphQLd6ZN2L4BabVCsc/3ohDDXw8WdDGZfwNAXZ8ENojQdDpK6hjS3HnwVdhbwMuP6R00QHj6srmV1DpzAGgQXtHRkSzV1YcMzzk5JX+ImdiH0LQ9Ofur80DwsJrJOQyrwrjXeYltRIc/eCyQ3FqQ2R3I0eibJYiocsC5CngIPh3cw16k5MtfXTYiqwMIFiOpKCmZi8GhAAGQcjM092RuJLL1wjJeTN8O9tnVlBlvcqFrkzCFLFSItbkxO5hKyJf62erPUnGLARN7JKJ3el33dYXPF4blnISqsJEO5FH7crcg6h+TbntTiGV 189iSvrT OsMTgC4KgOOT2UN3xllwM0a5V7JOXRdKkT1PpixerBvNUvrihSLgl4bDZw7VSI7ZCA9EkbaK1aD/oCUuZPzjmv0xhFLkywLyN/folNS18QZbJFLmc6sd98c3sClPcZnvwX3RQo8YEqfadNJZe+fhg24qYy+BTd3QWqa5arhCJCCKU/Yh/2fqqmrJoBI+PZel20s+UsRX4RoF5owpEmdIzkMd6gAF9rWTHc+mnxhOxt3zqh0/uVd/ZuxgNlleePxbBqobvoGwQSsgMayq/0c4YkPGB51ck+oefpC7xVv0AUFgdVqeqyezVy52kdLUW/QGx0tFXZeHILc+dtekxO+bB1MC/BwbzcLqS+pDLqZb2Ncvb35P13C5ET8YtU1BS1LI2jEEzbQyiuCuITB4lVkePZVrBp/gtnyFeGpk+PKoPZFiIkbA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.24 14:26, Alexander Gordeev wrote: > On Wed, Mar 27, 2024 at 06:17:36PM +0100, David Hildenbrand wrote: > > Hi David, > ... >> static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, >> struct vm_area_struct *dst_vma, >> unsigned long dst_addr) >> @@ -324,6 +355,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd, >> spinlock_t *ptl; >> int ret; >> >> + if (mm_forbids_zeropage(dst_vma->mm)) > > I assume, you were going to pass dst_vma->vm_mm here? > This patch does not compile otherwise. Ah, I compiled it only on x86, where the parameter is ignored ... and for testing the code path I forced mm_forbids_zeropage to be 1 on x86. Yes, this must be dst_vma->vm_mm. Thanks! -- Cheers, David / dhildenb