From: David Hildenbrand <david@redhat.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>, Sven Schnelle <svens@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed
Date: Thu, 11 Apr 2024 14:30:34 +0200 [thread overview]
Message-ID: <b9d9af94-5935-4034-bf3f-9ba283df3ede@redhat.com> (raw)
In-Reply-To: <ZhfW7qzAGPQo3mJN@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
On 11.04.24 14:26, Alexander Gordeev wrote:
> On Wed, Mar 27, 2024 at 06:17:36PM +0100, David Hildenbrand wrote:
>
> Hi David,
> ...
>> static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd,
>> struct vm_area_struct *dst_vma,
>> unsigned long dst_addr)
>> @@ -324,6 +355,9 @@ static int mfill_atomic_pte_zeropage(pmd_t *dst_pmd,
>> spinlock_t *ptl;
>> int ret;
>>
>> + if (mm_forbids_zeropage(dst_vma->mm))
>
> I assume, you were going to pass dst_vma->vm_mm here?
> This patch does not compile otherwise.
Ah, I compiled it only on x86, where the parameter is ignored ... and
for testing the code path I forced mm_forbids_zeropage to be 1 on x86.
Yes, this must be dst_vma->vm_mm.
Thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-11 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 17:17 [PATCH v2 0/2] s390/mm: shared zeropage + KVM fixes David Hildenbrand
2024-03-27 17:17 ` [PATCH v2 1/2] mm/userfaultfd: don't place zeropages when zeropages are disallowed David Hildenbrand
2024-04-11 12:26 ` Alexander Gordeev
2024-04-11 12:30 ` David Hildenbrand [this message]
2024-04-11 12:55 ` David Hildenbrand
2024-03-27 17:17 ` [PATCH v2 2/2] s390/mm: re-enable the shared zeropage for !PV and !skeys KVM guests David Hildenbrand
2024-04-11 12:33 ` Alexander Gordeev
2024-04-11 12:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d9af94-5935-4034-bf3f-9ba283df3ede@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox