From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A91EE7716C for ; Thu, 5 Dec 2024 15:22:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05B2C6B00DF; Thu, 5 Dec 2024 10:19:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1F3E6B00CE; Thu, 5 Dec 2024 10:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B5E6B00D9; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F9706B0083 for ; Fri, 25 Oct 2024 07:32:48 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CEEA9C0848 for ; Fri, 25 Oct 2024 11:32:26 +0000 (UTC) X-FDA: 82711911660.06.A75D1B6 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by imf01.hostedemail.com (Postfix) with ESMTP id E68E840010 for ; Fri, 25 Oct 2024 11:32:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=iogearbox.net header.s=default2302 header.b="gEf/7YW1"; spf=pass (imf01.hostedemail.com: domain of daniel@iogearbox.net designates 213.133.104.62 as permitted sender) smtp.mailfrom=daniel@iogearbox.net; dmarc=pass (policy=reject) header.from=iogearbox.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729855913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ou8Xa/I0YBpA5T56l1O7WY5r2Zh0QPkuOkUMaRnLN1o=; b=IjRHBFqo+tke2ynLtK9XDj6axWzdzMMCy1CoeylefytP25qcv57n5a+rKGFYbRgj8AY4LK PbFSbPNmHw7eeS4gMmQoSaQ4AJ3K15ZwdUtGU8x6ksOc7oepBsUKr8UK52TN8f4RVAjSFC OTZvSlHvz/uvykPm7JiT0ZwP47jjrCU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=iogearbox.net header.s=default2302 header.b="gEf/7YW1"; spf=pass (imf01.hostedemail.com: domain of daniel@iogearbox.net designates 213.133.104.62 as permitted sender) smtp.mailfrom=daniel@iogearbox.net; dmarc=pass (policy=reject) header.from=iogearbox.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729855913; a=rsa-sha256; cv=none; b=V6hcMnieJJujvtRZBlpfkgkuGh/nkzGlHPxBFy/xldTIRdvP5Ja8h5SdieAJMN5P+nO3IZ TNPjKo7sKDG0Lk430P87Kg8xf1/8QLmwwXJrv5Wyojz6cHtz8RVl7sNlfV61voLjIZGs1w +brll3bVhbQg/+P4nva/VVFbQJUbrzI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Ou8Xa/I0YBpA5T56l1O7WY5r2Zh0QPkuOkUMaRnLN1o=; b=gEf/7YW1rhhxsG10DvPAbrRuty FPjfpgB/vTcJHUncG8OQJRctjeiOkD4n5+j4I0t9RazVZgBt65/Wd7FI2+qzxePkbaamQd/AVOjL9 NYX6GZSip3akvpYROQGi0U62jFkLfh3WMqAmE0PtEaVvlFRyrHHkWkcqQqodpR8+BqAZpsIneDI52 L5WsluJnCpcz7MweTb5mWO6ybw2wIi44aheoPq9g4RnZUGY6QqQtKnW52iV+wUFjRAIXs4D0x+f30 9WveP7ZklrblRRMas3RGofwtonmxg7EUQsrYiuoxzsnwSQGsY67aSQQd2s/2yNfSa7rGfugh5FvBc lK99fQZQ==; Received: from sslproxy02.your-server.de ([78.47.166.47]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t4IYW-0001FB-AX; Fri, 25 Oct 2024 13:32:36 +0200 Received: from [85.1.206.226] (helo=[192.168.1.114]) by sslproxy02.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t4IYU-000HsF-1h; Fri, 25 Oct 2024 13:32:34 +0200 Message-ID: Date: Fri, 25 Oct 2024 13:32:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 2/4] bpf: bpf_csum_diff: optimize and homogenize for all archs To: Puranjay Mohan , kernel test robot , Albert Ou , Alexei Starovoitov , Andrew Morton , Andrii Nakryiko , bpf@vger.kernel.org, "David S. Miller" , Eduard Zingerman , Eric Dumazet , Hao Luo , Helge Deller , Jakub Kicinski , "James E.J. Bottomley" , Jiri Olsa , John Fastabend , KP Singh , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Martin KaFai Lau , Mykola Lysenko , Palmer Dabbelt , Paolo Abeni , Paul Walmsley , Shuah Khan , Song Liu , Stanislav Fomichev Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , netdev@vger.kernel.org References: <20241023153922.86909-3-puranjay@kernel.org> <202410251552.LR73LP4V-lkp@intel.com> Content-Language: en-US From: Daniel Borkmann Autocrypt: addr=daniel@iogearbox.net; keydata= xsFNBGNAkI0BEADiPFmKwpD3+vG5nsOznvJgrxUPJhFE46hARXWYbCxLxpbf2nehmtgnYpAN 2HY+OJmdspBntWzGX8lnXF6eFUYLOoQpugoJHbehn9c0Dcictj8tc28MGMzxh4aK02H99KA8 VaRBIDhmR7NJxLWAg9PgneTFzl2lRnycv8vSzj35L+W6XT7wDKoV4KtMr3Szu3g68OBbp1TV HbJH8qe2rl2QKOkysTFRXgpu/haWGs1BPpzKH/ua59+lVQt3ZupePpmzBEkevJK3iwR95TYF 06Ltpw9ArW/g3KF0kFUQkGXYXe/icyzHrH1Yxqar/hsJhYImqoGRSKs1VLA5WkRI6KebfpJ+ RK7Jxrt02AxZkivjAdIifFvarPPu0ydxxDAmgCq5mYJ5I/+BY0DdCAaZezKQvKw+RUEvXmbL 94IfAwTFA1RAAuZw3Rz5SNVz7p4FzD54G4pWr3mUv7l6dV7W5DnnuohG1x6qCp+/3O619R26 1a7Zh2HlrcNZfUmUUcpaRPP7sPkBBLhJfqjUzc2oHRNpK/1mQ/+mD9CjVFNz9OAGD0xFzNUo yOFu/N8EQfYD9lwntxM0dl+QPjYsH81H6zw6ofq+jVKcEMI/JAgFMU0EnxrtQKH7WXxhO4hx 3DFM7Ui90hbExlFrXELyl/ahlll8gfrXY2cevtQsoJDvQLbv7QARAQABzSZEYW5pZWwgQm9y a21hbm4gPGRhbmllbEBpb2dlYXJib3gubmV0PsLBkQQTAQoAOxYhBCrUdtCTcZyapV2h+93z cY/jfzlXBQJjQJCNAhsDBQkHhM4ACAsJCAcNDAsKBRUKCQgLAh4BAheAAAoJEN3zcY/jfzlX dkUQAIFayRgjML1jnwKs7kvfbRxf11VI57EAG8a0IvxDlNKDcz74mH66HMyhMhPqCPBqphB5 ZUjN4N5I7iMYB/oWUeohbuudH4+v6ebzzmgx/EO+jWksP3gBPmBeeaPv7xOvN/pPDSe/0Ywp dHpl3Np2dS6uVOMnyIsvmUGyclqWpJgPoVaXrVGgyuer5RpE/a3HJWlCBvFUnk19pwDMMZ8t 0fk9O47HmGh9Ts3O8pGibfdREcPYeGGqRKRbaXvcRO1g5n5x8cmTm0sQYr2xhB01RJqWrgcj ve1TxcBG/eVMmBJefgCCkSs1suriihfjjLmJDCp9XI/FpXGiVoDS54TTQiKQinqtzP0jv+TH 1Ku+6x7EjLoLH24ISGyHRmtXJrR/1Ou22t0qhCbtcT1gKmDbTj5TcqbnNMGWhRRTxgOCYvG0 0P2U6+wNj3HFZ7DePRNQ08bM38t8MUpQw4Z2SkM+jdqrPC4f/5S8JzodCu4x80YHfcYSt+Jj ipu1Ve5/ftGlrSECvy80ZTKinwxj6lC3tei1bkI8RgWZClRnr06pirlvimJ4R0IghnvifGQb M1HwVbht8oyUEkOtUR0i0DMjk3M2NoZ0A3tTWAlAH8Y3y2H8yzRrKOsIuiyKye9pWZQbCDu4 ZDKELR2+8LUh+ja1RVLMvtFxfh07w9Ha46LmRhpCzsFNBGNAkI0BEADJh65bNBGNPLM7cFVS nYG8tqT+hIxtR4Z8HQEGseAbqNDjCpKA8wsxQIp0dpaLyvrx4TAb/vWIlLCxNu8Wv4W1JOST wI+PIUCbO/UFxRy3hTNlb3zzmeKpd0detH49bP/Ag6F7iHTwQQRwEOECKKaOH52tiJeNvvyJ pPKSKRhmUuFKMhyRVK57ryUDgowlG/SPgxK9/Jto1SHS1VfQYKhzMn4pWFu0ILEQ5x8a0RoX k9p9XkwmXRYcENhC1P3nW4q1xHHlCkiqvrjmWSbSVFYRHHkbeUbh6GYuCuhqLe6SEJtqJW2l EVhf5AOp7eguba23h82M8PC4cYFl5moLAaNcPHsdBaQZznZ6NndTtmUENPiQc2EHjHrrZI5l kRx9hvDcV3Xnk7ie0eAZDmDEbMLvI13AvjqoabONZxra5YcPqxV2Biv0OYp+OiqavBwmk48Z P63kTxLddd7qSWbAArBoOd0wxZGZ6mV8Ci/ob8tV4rLSR/UOUi+9QnkxnJor14OfYkJKxot5 hWdJ3MYXjmcHjImBWplOyRiB81JbVf567MQlanforHd1r0ITzMHYONmRghrQvzlaMQrs0V0H 5/sIufaiDh7rLeZSimeVyoFvwvQPx5sXhjViaHa+zHZExP9jhS/WWfFE881fNK9qqV8pi+li 2uov8g5yD6hh+EPH6wARAQABwsF8BBgBCgAmFiEEKtR20JNxnJqlXaH73fNxj+N/OVcFAmNA kI0CGwwFCQeEzgAACgkQ3fNxj+N/OVfFMhAA2zXBUzMLWgTm6iHKAPfz3xEmjtwCF2Qv/TT3 KqNUfU3/0VN2HjMABNZR+q3apm+jq76y0iWroTun8Lxo7g89/VDPLSCT0Nb7+VSuVR/nXfk8 R+OoXQgXFRimYMqtP+LmyYM5V0VsuSsJTSnLbJTyCJVu8lvk3T9B0BywVmSFddumv3/pLZGn 17EoKEWg4lraXjPXnV/zaaLdV5c3Olmnj8vh+14HnU5Cnw/dLS8/e8DHozkhcEftOf+puCIl Awo8txxtLq3H7KtA0c9kbSDpS+z/oT2S+WtRfucI+WN9XhvKmHkDV6+zNSH1FrZbP9FbLtoE T8qBdyk//d0GrGnOrPA3Yyka8epd/bXA0js9EuNknyNsHwaFrW4jpGAaIl62iYgb0jCtmoK/ rCsv2dqS6Hi8w0s23IGjz51cdhdHzkFwuc8/WxI1ewacNNtfGnorXMh6N0g7E/r21pPeMDFs rUD9YI1Je/WifL/HbIubHCCdK8/N7rblgUrZJMG3W+7vAvZsOh/6VTZeP4wCe7Gs/cJhE2gI DmGcR+7rQvbFQC4zQxEjo8fNaTwjpzLM9NIp4vG9SDIqAm20MXzLBAeVkofixCsosUWUODxP owLbpg7pFRJGL9YyEHpS7MGPb3jSLzucMAFXgoI8rVqoq6si2sxr2l0VsNH5o3NgoAgJNIg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.10/27438/Fri Oct 25 10:32:52 2024) X-Rspam-User: X-Stat-Signature: 61pw7kh7w1kjrpto7zqzd5zq413ckrhp X-Rspamd-Queue-Id: E68E840010 X-Rspamd-Server: rspam11 X-HE-Tag: 1729855949-943726 X-HE-Meta: U2FsdGVkX1/fq3Y/zPd4n2lCvwkc+l4JtWx6Vb2NXCs10MMOyyxihTIvEATakY/RVrlXJzpu8BHKe+ec4d/Fs7OdJvRLcXynqI3uvn9LfGMVBSmY3YwhiVzu2rddCjFphCXS2W2HW2PzLGXAo1ufuwXkG/PwDevKuy/pWoiJqqTPYAwII4001jtgkHxXg1hY9OyLBoEsAoBuE1FNDvDe0SmiU8u9++cfsffNjOTF7IdS8VX8yNGCU11nss/6C8WGkOIYWpZX4M48MuaCsl3DIF8bWjZz1CYlCuKf6jv1IaSz3q5bVui66AWWoqrsSxtrJUxEC6L/7Nt9KTAS53ZrCjhg16TQSUhAebKMR5g5HuVyhzj7bFNWn1gmg5PbUh0z3MFg1cTkAADdhOD88oycLspiEozzCdO9qXLbGzHeD/sH0uYzbr7yW+IGS2rmGmoBvNKVw5rQtxBh5MfoMcf85KfpRfLzgUh1CT7c5EmMzvnDxvt/4PNo9vp4i/6bjTkZJdpw+CfFBRdhY0qeHS8TMz/KiwxsAnoJJ2pncgZyTVipbIIU9QAOKNwDeoGwRmyuWWCHQSdVAV8GDzkaIuhOcmGo6xP5LxqGUvDHIMsZzgVFcqaFHjcQlnfcWwOI3ISijvzRdpcbwT7/vhzuF14lD10koBKPBBz1x2YQANcbF3Ae5tsYjrkQOXdVgpPTIv+niGfSlo6K4ZqO3Pb5u2QMtl2QayfaMnnk2Z4vE/rWopOHA3Eq9nw30pn+tJJSZ+5rzU04JQ/7zGzVSo4kEn1o+zi3tpPBq/N5fDU0lCwsyh4sAxiRPB8/osSQEwujyctFT9H3u6/SuAxyoTlmtnTfk/l9gaVOxGR4AQ+eNodXbKw2IzichhE8zwnFG2wKTmgurY5oukzfHOJpOKAjpxWHRRQ5GqlGfQCa+3nytGe9D7X6gQaIVU0YklIXIiWOLIX7cErBp06M6FvT3AT1APk DxZ/Hjav C66TKHRyBD9OdmEIViYsuV68crApZPYOVwdihzdBQYrkXjoPDx22LNRDKI0pCg8CMCXSRtcGRWMUYd13o65AjcbihbGGPYgnGXR4zT4gTEi367grE297r+rOOKKr5zTHkq/LpBawP3P3/vbNVnjPkgNtBBiHdiSqTprRj0AzO+v182P3Fc7HE5f+9oyEdf9EeOx3dwWDKXWtMdoVstOtrrh3b8UFCMzjCDcT++A8CIAJe85K1c0DvDgnhpEZm8faA6sTlq8jZeKou/uE2veLByHN1TuoGGQES82rkC2Sk3QqsY/whqktflHxXu96/JCq8knnhOxp/eV8dkGbWqrGAtKNIqRLMG6luGKsy3Ifx9VDY+ppO7a7Hi8jdqwPxzZD9dTDL0cEjzNGgkwqOTZjcSTpnCyUJxbJX5w/IJalhEPFohNvy+XSH1m3O96MHkY3zNbeTRNdpQPmRY2l/St14EEsGQi0dL4lji+JsnMO+5tOlXR9JrFCe+iRs88ydo8lLiV6P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 12:11 PM, Puranjay Mohan wrote: [...] > This file has a lot of such sparse warnings. Specifically, to fix the > warning introduced by me, I can apply the following diff: > > --- >8 --- > > diff --git a/net/core/filter.c b/net/core/filter.c > index e00bec7de9ed..b94037f29b2a 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -2019,16 +2019,18 @@ BPF_CALL_5(bpf_csum_diff, __be32 *, from, u32, from_size, > * Even for diffing, from_size and to_size don't need to be equal. > */ > > + __wsum ret = seed; > + > if (from_size && to_size) > - return csum_from32to16(csum_sub(csum_partial(to, to_size, seed), > - csum_partial(from, from_size, 0))); > + ret = csum_sub(csum_partial(to, to_size, seed), csum_partial(from, from_size, 0)); Lets also pass ret into csum_partial() instead of seed given the arg is of type __wsum there too, otherwise lgtm and yes lets fix these. > + > if (to_size) > - return csum_from32to16(csum_partial(to, to_size, seed)); > + ret = csum_partial(to, to_size, seed); > > if (from_size) > - return csum_from32to16(~csum_partial(from, from_size, ~seed)); > + ret = ~csum_partial(from, from_size, ~seed); > > - return seed; > + return csum_from32to16((__force unsigned int)ret); > } > > --- 8< --- > > If others feel that fixing these warnings is useful, I can send another > version with above diff. I will then also send a separate patch to fix > all other such warnings in this file. That would be great, as separate patch, agree. Thanks, Daniel