linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [linux-next:master 5069/12910] include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
@ 2023-08-25  9:07 kernel test robot
  2023-08-25 17:00 ` Bart Van Assche
  0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2023-08-25  9:07 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: oe-kbuild-all, Linux Memory Management List, Martin K. Petersen,
	Avri Altman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   6269320850097903b30be8f07a5c61d9f7592393
commit: 617bfaa8dd50d6a3ffc8694b4696bf2aa196bd44 [5069/12910] scsi: ufs: Simplify response header parsing
config: arm-randconfig-r001-20230825 (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308251634.tuRn4OVv-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/container_of.h:5,
                    from include/linux/list.h:5,
                    from include/linux/async.h:12,
                    from drivers/ufs/core/ufshcd.c:12:
>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
      78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                         ^~~~~~~~~~~~~~
   include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
      77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
         |                                  ^~~~~~~~~~~~~~~
   include/ufs/ufs.h:22:1: note: in expansion of macro 'static_assert'
      22 | static_assert(sizeof(struct utp_upiu_header) == 12);
         | ^~~~~~~~~~~~~


vim +78 include/linux/build_bug.h

bc6245e5efd70c Ian Abbott       2017-07-10  60  
6bab69c65013be Rasmus Villemoes 2019-03-07  61  /**
6bab69c65013be Rasmus Villemoes 2019-03-07  62   * static_assert - check integer constant expression at build time
6bab69c65013be Rasmus Villemoes 2019-03-07  63   *
6bab69c65013be Rasmus Villemoes 2019-03-07  64   * static_assert() is a wrapper for the C11 _Static_assert, with a
6bab69c65013be Rasmus Villemoes 2019-03-07  65   * little macro magic to make the message optional (defaulting to the
6bab69c65013be Rasmus Villemoes 2019-03-07  66   * stringification of the tested expression).
6bab69c65013be Rasmus Villemoes 2019-03-07  67   *
6bab69c65013be Rasmus Villemoes 2019-03-07  68   * Contrary to BUILD_BUG_ON(), static_assert() can be used at global
6bab69c65013be Rasmus Villemoes 2019-03-07  69   * scope, but requires the expression to be an integer constant
6bab69c65013be Rasmus Villemoes 2019-03-07  70   * expression (i.e., it is not enough that __builtin_constant_p() is
6bab69c65013be Rasmus Villemoes 2019-03-07  71   * true for expr).
6bab69c65013be Rasmus Villemoes 2019-03-07  72   *
6bab69c65013be Rasmus Villemoes 2019-03-07  73   * Also note that BUILD_BUG_ON() fails the build if the condition is
6bab69c65013be Rasmus Villemoes 2019-03-07  74   * true, while static_assert() fails the build if the expression is
6bab69c65013be Rasmus Villemoes 2019-03-07  75   * false.
6bab69c65013be Rasmus Villemoes 2019-03-07  76   */
6bab69c65013be Rasmus Villemoes 2019-03-07  77  #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
6bab69c65013be Rasmus Villemoes 2019-03-07 @78  #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
6bab69c65013be Rasmus Villemoes 2019-03-07  79  
07a368b3f55a79 Maxim Levitsky   2022-10-25  80  

:::::: The code at line 78 was first introduced by commit
:::::: 6bab69c65013bed5fce9f101a64a84d0385b3946 build_bug.h: add wrapper for _Static_assert

:::::: TO: Rasmus Villemoes <linux@rasmusvillemoes.dk>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 5069/12910] include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
  2023-08-25  9:07 [linux-next:master 5069/12910] include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12" kernel test robot
@ 2023-08-25 17:00 ` Bart Van Assche
  2023-08-26  0:18   ` Philip Li
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Van Assche @ 2023-08-25 17:00 UTC (permalink / raw)
  To: kernel test robot
  Cc: oe-kbuild-all, Linux Memory Management List, Martin K. Petersen,
	Avri Altman

On 8/25/23 02:07, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   6269320850097903b30be8f07a5c61d9f7592393
> commit: 617bfaa8dd50d6a3ffc8694b4696bf2aa196bd44 [5069/12910] scsi: ufs: Simplify response header parsing
> config: arm-randconfig-r001-20230825 (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308251634.tuRn4OVv-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     In file included from include/linux/container_of.h:5,
>                      from include/linux/list.h:5,
>                      from include/linux/async.h:12,
>                      from drivers/ufs/core/ufshcd.c:12:
>>> include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
>        78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>           |                                         ^~~~~~~~~~~~~~
>     include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
>        77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
>           |                                  ^~~~~~~~~~~~~~~
>     include/ufs/ufs.h:22:1: note: in expansion of macro 'static_assert'
>        22 | static_assert(sizeof(struct utp_upiu_header) == 12);
>           | ^~~~~~~~~~~~~

Can anyone tell me where to find the gcc binaries used by the kernel 
test robot? I cannot reproduce the above build error with
arm-linux-gnueabi-gcc 13.2.0 from godbolt.org.

This is the code that I provided as input to godbolt.org:

#include <stdint.h>

#define __LITTLE_ENDIAN 1

typedef uint32_t __be32;
typedef uint16_t __be16;
typedef uint8_t __u8;

struct utp_upiu_header {
	union {
		struct {
			__be32 dword_0;
			__be32 dword_1;
			__be32 dword_2;
		};
		struct {
			__u8 transaction_code;
			__u8 flags;
			__u8 lun;
			__u8 task_tag;
#if defined(__BIG_ENDIAN)
			__u8 iid: 4;
			__u8 command_set_type: 4;
#elif defined(__LITTLE_ENDIAN)
			__u8 command_set_type: 4;
			__u8 iid: 4;
#else
#error
#endif
			union {
				__u8 tm_function;
				__u8 query_function;
			};
			__u8 response;
			__u8 status;
			__u8 ehs_length;
			__u8 device_information;
			__be16 data_segment_length;
		};
	};
};

static_assert(sizeof(struct utp_upiu_header) == 12, "");

Thanks,

Bart.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-next:master 5069/12910] include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
  2023-08-25 17:00 ` Bart Van Assche
@ 2023-08-26  0:18   ` Philip Li
  0 siblings, 0 replies; 3+ messages in thread
From: Philip Li @ 2023-08-26  0:18 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: kernel test robot, oe-kbuild-all, Linux Memory Management List,
	Martin K. Petersen, Avri Altman

On Fri, Aug 25, 2023 at 10:00:47AM -0700, Bart Van Assche wrote:
> On 8/25/23 02:07, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   6269320850097903b30be8f07a5c61d9f7592393
> > commit: 617bfaa8dd50d6a3ffc8694b4696bf2aa196bd44 [5069/12910] scsi: ufs: Simplify response header parsing
> > config: arm-randconfig-r001-20230825 (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/config)
> > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
> > reproduce: (https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308251634.tuRn4OVv-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >     In file included from include/linux/container_of.h:5,
> >                      from include/linux/list.h:5,
> >                      from include/linux/async.h:12,
> >                      from drivers/ufs/core/ufshcd.c:12:
> > > > include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12"
> >        78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
> >           |                                         ^~~~~~~~~~~~~~
> >     include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
> >        77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
> >           |                                  ^~~~~~~~~~~~~~~
> >     include/ufs/ufs.h:22:1: note: in expansion of macro 'static_assert'
> >        22 | static_assert(sizeof(struct utp_upiu_header) == 12);
> >           | ^~~~~~~~~~~~~
> 
> Can anyone tell me where to find the gcc binaries used by the kernel test

Hi Bart, the gcc binary we use is put at [1]

You may also give a try for the reproduce step [2] which might help to
ease the reproduce. If it has issue to access the url or other issue
during reproduce, you can try to

	export URL=https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64

Then rerun the make.cross command of reproduce step. Kindly let us know if there's
any issue.

[1] https://download.01.org/0day-ci/cross-package/gcc-13.2.0-nolibc/x86_64-gcc-13.2.0-nolibc_arm-linux-gnueabi.tar.xz
[2] https://download.01.org/0day-ci/archive/20230825/202308251634.tuRn4OVv-lkp@intel.com/reproduce

> robot? I cannot reproduce the above build error with
> arm-linux-gnueabi-gcc 13.2.0 from godbolt.org.
> 
> This is the code that I provided as input to godbolt.org:
> 
> #include <stdint.h>
> 
> #define __LITTLE_ENDIAN 1
> 
> typedef uint32_t __be32;
> typedef uint16_t __be16;
> typedef uint8_t __u8;
> 
> struct utp_upiu_header {
> 	union {
> 		struct {
> 			__be32 dword_0;
> 			__be32 dword_1;
> 			__be32 dword_2;
> 		};
> 		struct {
> 			__u8 transaction_code;
> 			__u8 flags;
> 			__u8 lun;
> 			__u8 task_tag;
> #if defined(__BIG_ENDIAN)
> 			__u8 iid: 4;
> 			__u8 command_set_type: 4;
> #elif defined(__LITTLE_ENDIAN)
> 			__u8 command_set_type: 4;
> 			__u8 iid: 4;
> #else
> #error
> #endif
> 			union {
> 				__u8 tm_function;
> 				__u8 query_function;
> 			};
> 			__u8 response;
> 			__u8 status;
> 			__u8 ehs_length;
> 			__u8 device_information;
> 			__be16 data_segment_length;
> 		};
> 	};
> };
> 
> static_assert(sizeof(struct utp_upiu_header) == 12, "");
> 
> Thanks,
> 
> Bart.
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-26  0:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-25  9:07 [linux-next:master 5069/12910] include/linux/build_bug.h:78:41: error: static assertion failed: "sizeof(struct utp_upiu_header) == 12" kernel test robot
2023-08-25 17:00 ` Bart Van Assche
2023-08-26  0:18   ` Philip Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox