From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150E2EB8FA5 for ; Wed, 6 Sep 2023 07:38:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7205D440150; Wed, 6 Sep 2023 03:38:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AA628E0014; Wed, 6 Sep 2023 03:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 571BD440150; Wed, 6 Sep 2023 03:38:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 43D5A8E0014 for ; Wed, 6 Sep 2023 03:38:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F2227C0CFA for ; Wed, 6 Sep 2023 07:38:27 +0000 (UTC) X-FDA: 81205369854.18.229E4EB Received: from out-230.mta1.migadu.com (out-230.mta1.migadu.com [95.215.58.230]) by imf12.hostedemail.com (Postfix) with ESMTP id 10E0040019 for ; Wed, 6 Sep 2023 07:38:25 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=n1x4an6A; spf=pass (imf12.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693985906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CUvdMizjRgte40DYvAujl6KoskdVnrnR+91q+pwocEA=; b=pz0XaCE+UPcgVuTIJcoxk/4WU4AppInGhxmkZkUznGOs7z+etkPkSEJek9VTURjHEnOmt0 Tc0+4L5SaxaVDf4TSIGOQVD3wOE3jzVq1Xiha/i5e37r9NiTfDBjKAwE5ucQ7PLmnHhbUP mhdTiEduNOeYzpyExyFR0gE8GMUBLW8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=n1x4an6A; spf=pass (imf12.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.230 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693985906; a=rsa-sha256; cv=none; b=IRnW2kFVmUgax0Dwmr8twHPWgHD3mYcK5iuh+ljnij9BT3KkPvsK8PgE+nTChyW1NZ3ZOW RyT0fNpfzKPqxPLqcrRsON+VGnThwaTOK7FU6s9Oab98SbY+I9JAdLEd2ouuGvdsvz3iB1 u6bu9rl64l2hAwDxMUb1G16DurqcE8E= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693985904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CUvdMizjRgte40DYvAujl6KoskdVnrnR+91q+pwocEA=; b=n1x4an6ApfoBNWKX0v5gHjkwYkuXU+Mm03Yn/hRC1vS5al/azE0PT255l1MDnzJBaKXcLs mAsPRgDAbCVoqSGnKcLsusxvEYLmDCzHm4jvhzIpGr+ScYmVz6vYCFKysUwHrv1rF+UM+6 aPkGRig0cojqwUWS7EAGRFwO73k49rg= Date: Wed, 6 Sep 2023 15:38:16 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 08/11] hugetlb: batch freeing of vmemmap pages To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton References: <20230905214412.89152-1-mike.kravetz@oracle.com> <20230905214412.89152-9-mike.kravetz@oracle.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230905214412.89152-9-mike.kravetz@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 10E0040019 X-Rspam-User: X-Stat-Signature: rbssd7reciwfur6qghwbiz4h9egm4uak X-Rspamd-Server: rspam01 X-HE-Tag: 1693985905-835749 X-HE-Meta: U2FsdGVkX1/arVR9lw4/VranpLP181Bula6Xj8UYBb5nZc4C8/ATVB0lhTNhWdXjg5zJaiVireHkv/R66AdIV2lYZHZ4yW/69/CIlo0gBlwpiX1pQyQ5NdG9kKtLiTQywVXnV9iGfGH6006BTSjrxBKr9JtB8UslrBLYgXppdbz0eqiHBt4iElouSP83RKGa7qFNUPRrGLhCR7lUu9i9JXQLbVTPqX5sZLrNOajqHgceL+2zrZjGo/RH8zqBl0wT0MVSZq5XIZGy6bJN3SncTeUWE/FcoNMTxgCNkTjydpaKMRvqddPYjjbRaJmM5Nk/ChPagI337JbCBwOUCqK4IdFkpWBNo8YiHOxRKVM+g+zLvi5mb9i13amEige3ULZrYvOP0UxL2MtnI3C0sBq/kiSIf9Z1RBLmdF46KO+9fAhCP2vqE5aAkGGOP/mpUJdKMLTgasGpB5ui87405dKYzFySYdgcoZSUgzy5Rd9joCSKKY7stxkajHxLAQTS4kpKcuYqUTUhpeyTj2mKg/r2Ax0jWopcRr9vRoljPv87lBxZSgyDXf1tgHcjqv5noUYLqw+WMeNGzxzL1Gzex0/evaDROOmZOuceNBCC3ZIJ+iOCp7K1d7PkOwlJ4jjNtSA5UNNITeLoceVm+4ZFy2cSNUfAbuElUJYYwKutfsT88TablxC2tliBXC2bIJaYqSmnvjV+NbYTSk4TfOAAq0o3eZ6z/PwPfNH0rjJccyVhe3FGU4CilPmmLb197uDsWHZWvdJh2qCQzi8oodpR48xB31HVdsMZnTB5MbqRpd3DjrSZ8Ua1cdYLQIvTG63E/x8FjeI6ZU5CsH5b/gRk+a4A3CJN3fxFcpZ8MHrd/nzofNkzP+jEp6YcppB3SBT9BvonVkcOG08RlM4gM495a9SmwGI51oHLhHYUTndOhEhMJz1CDWQKJwPD76XwxkJiOC3kQEVJbwqTcm48xd0vgJJ Eqaaeaq0 ImDHCx6n91N79l0QbSuzOzw6SRoLsK5GfNfnzqVIpdj8XDDMWsL8aDvRz+C47+ZrJEEXMMbJC1iNr13SKI5M2ek+4t261o1cObDvl88syVI3K+JY1gX/jsnrRBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/6 05:44, Mike Kravetz wrote: > Now that batching of hugetlb vmemmap optimization processing is possible, > batch the freeing of vmemmap pages. When freeing vmemmap pages for a > hugetlb page, we add them to a list that is freed after the entire batch > has been processed. > > This enhances the ability to return contiguous ranges of memory to the > low level allocators. > > Signed-off-by: Mike Kravetz > --- > mm/hugetlb_vmemmap.c | 60 ++++++++++++++++++++++++++++---------------- > 1 file changed, 38 insertions(+), 22 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index 79de984919ef..a715712df831 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -306,18 +306,21 @@ static void vmemmap_restore_pte(pte_t *pte, unsigned long addr, > * @end: end address of the vmemmap virtual address range that we want to > * remap. > * @reuse: reuse address. > + * @vmemmap_pages: list to deposit vmemmap pages to be freed. It is callers > + * responsibility to free pages. > * > * Return: %0 on success, negative error code otherwise. > */ > static int vmemmap_remap_free(unsigned long start, unsigned long end, > - unsigned long reuse) > + unsigned long reuse, > + struct list_head *vmemmap_pages) > { > int ret; > - LIST_HEAD(vmemmap_pages); > + LIST_HEAD(freed_pages); IIUC, we could reuse the parameter of @vmemmap_pages directly instead of a temporary variable, could it be dropped? > struct vmemmap_remap_walk walk = { > .remap_pte = vmemmap_remap_pte, > .reuse_addr = reuse, > - .vmemmap_pages = &vmemmap_pages, > + .vmemmap_pages = &freed_pages, > }; > int nid = page_to_nid((struct page *)start); > gfp_t gfp_mask = GFP_KERNEL | __GFP_THISNODE | __GFP_NORETRY | > @@ -335,7 +338,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, > if (walk.reuse_page) { > copy_page(page_to_virt(walk.reuse_page), > (void *)walk.reuse_addr); > - list_add(&walk.reuse_page->lru, &vmemmap_pages); > + list_add(&walk.reuse_page->lru, &freed_pages); > } > > /* > @@ -366,15 +369,14 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, > walk = (struct vmemmap_remap_walk) { > .remap_pte = vmemmap_restore_pte, > .reuse_addr = reuse, > - .vmemmap_pages = &vmemmap_pages, > + .vmemmap_pages = &freed_pages, > }; > > vmemmap_remap_range(reuse, end, &walk); > } > mmap_read_unlock(&init_mm); > > - free_vmemmap_page_list(&vmemmap_pages); > - > + list_splice(&freed_pages, vmemmap_pages); > return ret; > } > > @@ -553,17 +555,9 @@ static bool vmemmap_should_optimize(const struct hstate *h, const struct page *h > return true; > } > > -/** > - * hugetlb_vmemmap_optimize - optimize @head page's vmemmap pages. > - * @h: struct hstate. > - * @head: the head page whose vmemmap pages will be optimized. > - * > - * This function only tries to optimize @head's vmemmap pages and does not > - * guarantee that the optimization will succeed after it returns. The caller > - * can use HPageVmemmapOptimized(@head) to detect if @head's vmemmap pages > - * have been optimized. > - */ > -void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head) > +static void __hugetlb_vmemmap_optimize(const struct hstate *h, > + struct page *head, > + struct list_head *vmemmap_pages) > { > unsigned long vmemmap_start = (unsigned long)head, vmemmap_end; > unsigned long vmemmap_reuse; > @@ -580,21 +574,43 @@ void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head) > > /* > * Remap the vmemmap virtual address range [@vmemmap_start, @vmemmap_end) > - * to the page which @vmemmap_reuse is mapped to, then free the pages > - * which the range [@vmemmap_start, @vmemmap_end] is mapped to. > + * to the page which @vmemmap_reuse is mapped to. Add pages previously > + * mapping the range to vmemmap_pages list so that they can be freed by > + * the caller. > */ > - if (vmemmap_remap_free(vmemmap_start, vmemmap_end, vmemmap_reuse)) > + if (vmemmap_remap_free(vmemmap_start, vmemmap_end, vmemmap_reuse, vmemmap_pages)) > static_branch_dec(&hugetlb_optimize_vmemmap_key); > else > SetHPageVmemmapOptimized(head); > } > > +/** > + * hugetlb_vmemmap_optimize - optimize @head page's vmemmap pages. > + * @h: struct hstate. > + * @head: the head page whose vmemmap pages will be optimized. > + * > + * This function only tries to optimize @head's vmemmap pages and does not > + * guarantee that the optimization will succeed after it returns. The caller > + * can use HPageVmemmapOptimized(@head) to detect if @head's vmemmap pages > + * have been optimized. > + */ > +void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head) > +{ > + LIST_HEAD(vmemmap_pages); > + > + __hugetlb_vmemmap_optimize(h, head, &vmemmap_pages); > + free_vmemmap_page_list(&vmemmap_pages); > +} > + > void hugetlb_vmemmap_optimize_folios(struct hstate *h, struct list_head *folio_list) > { > struct folio *folio; > + LIST_HEAD(vmemmap_pages); > > list_for_each_entry(folio, folio_list, lru) > - hugetlb_vmemmap_optimize(h, &folio->page); > + __hugetlb_vmemmap_optimize(h, &folio->page, &vmemmap_pages); > + > + free_vmemmap_page_list(&vmemmap_pages); > } > > static struct ctl_table hugetlb_vmemmap_sysctls[] = {