From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23287C433E0 for ; Thu, 30 Jul 2020 12:03:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5E9420829 for ; Thu, 30 Jul 2020 12:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UwzAb5zo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5E9420829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5DA5A6B0002; Thu, 30 Jul 2020 08:03:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58A566B0005; Thu, 30 Jul 2020 08:03:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478D56B0006; Thu, 30 Jul 2020 08:03:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id 335776B0002 for ; Thu, 30 Jul 2020 08:03:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CB3FC12F2 for ; Thu, 30 Jul 2020 12:03:13 +0000 (UTC) X-FDA: 77094606666.20.dock62_550c02b26f7b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 8C094180C0611 for ; Thu, 30 Jul 2020 12:03:13 +0000 (UTC) X-HE-Tag: dock62_550c02b26f7b X-Filterd-Recvd-Size: 6154 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jul 2020 12:03:12 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id q4so16535726edv.13 for ; Thu, 30 Jul 2020 05:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kTyIB8a8ynCW3WqaP6UVysZ6xRftgn4zqn+hfslnyfk=; b=UwzAb5zoVB/2SjBmyyK0tLHY6mooRDRvP1GGboYTwuAR8aHTPIErlWnGYl+QMCAnIL yQA5KglMPV1nEtOb7DHGActKRO3l8MWgwOdaNahAYgA3kHgOmBgMXlGd2HI9I8iRrQrJ wJgVaeOvoH9XzlJzskZo1NyVdWeLw8x2PUPy1EZNT20QfesYz3oX5U7qNS1xgX7sfzrF ENVjmOvisgVOKKSpbzThAIbdpGEoAqwPm4q8ioaTNwxJIf0jtmIbYv7mae6ThqRWT497 KWPqBviEq0zDV183wqqQXIByMXeJUlfa7qFmI44NwRQI+wpNK/TIMHfUciugJyaNUJpg VLIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=kTyIB8a8ynCW3WqaP6UVysZ6xRftgn4zqn+hfslnyfk=; b=lTZbjyqDoWvQD2uqyPPtA/IV5D80HdNlohZFUVH3Di+KB21MUGwGdh8PizDIhAS91j OePcJx+3nkwmXLOEfKsWqrJcytVQuW2ZuYKO4Fym3Qx1qBTxLjhd4O5u/VnYEbl2hSKd XLtpeqbGMCbjxqlwQx+ovnbtwTEqXaw+NSSuLWYoZefD7q8PdFxq1v19NSrJgSftks8g 4p8eLZqJDehJ+a2ERB741r/7HfltEuaCh7ESSHV+g0wTFExUQ6Cq+cPEXtfXLkXVOsRe q8sfcFc+6MXZsaW5khxKHEHNLAQGL5yiQcl3sSNNAK0evABxYN6SWTY46foGrRWZuzE/ VRuA== X-Gm-Message-State: AOAM532SNyjJRNOw7LeLHc/vlRxLhCT8ZsH1FrRueNwd1h/7Z1+YI0+W E+sVv3BragzOOJ76S8DxuLM= X-Google-Smtp-Source: ABdhPJz6WS7N0D21c7MBqLBmnP9+Pig+3y1KgatNCRD3IGpud2kNLYc1R2efcFjX5Wl6CLo5SVCOnQ== X-Received: by 2002:aa7:ca4f:: with SMTP id j15mr1460242edt.334.1596110591672; Thu, 30 Jul 2020 05:03:11 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id b18sm5628976ejc.41.2020.07.30.05.03.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2020 05:03:11 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [Linaro-mm-sig] [PATCH] dma-resv: lockdep-prime address_space->i_mmap_rwsem for dma-resv To: Daniel Vetter , DRI Development Cc: linux-xfs@vger.kernel.org, Maarten Lankhorst , linux-rdma@vger.kernel.org, Intel Graphics Development , Dave Chinner , =?UTF-8?Q?Christian_K=c3=b6nig?= , linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, Jason Gunthorpe , Qian Cai , linux-fsdevel@vger.kernel.org, Daniel Vetter , Andrew Morton , linux-media@vger.kernel.org References: <20200728135839.1035515-1-daniel.vetter@ffwll.ch> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 30 Jul 2020 14:03:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728135839.1035515-1-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: 8C094180C0611 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 28.07.20 um 15:58 schrieb Daniel Vetter: > GPU drivers need this in their shrinkers, to be able to throw out > mmap'ed buffers. Note that we also need dma_resv_lock in shrinkers, > but that loop is resolved by trylocking in shrinkers. > > So full hierarchy is now (ignore some of the other branches we already > have primed): > > mmap_read_lock -> dma_resv -> shrinkers -> i_mmap_lock_write > > I hope that's not inconsistent with anything mm or fs does, adding > relevant people. > > Signed-off-by: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian K=C3=B6nig" > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Cc: Dave Chinner > Cc: Qian Cai > Cc: linux-xfs@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org > Cc: Thomas Hellstr=C3=B6m (Intel) > Cc: Andrew Morton > Cc: Jason Gunthorpe > Cc: linux-mm@kvack.org > Cc: linux-rdma@vger.kernel.org > Cc: Maarten Lankhorst Reviewed-by: Christian K=C3=B6nig > --- > drivers/dma-buf/dma-resv.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c > index 0e6675ec1d11..9678162a4ac5 100644 > --- a/drivers/dma-buf/dma-resv.c > +++ b/drivers/dma-buf/dma-resv.c > @@ -104,12 +104,14 @@ static int __init dma_resv_lockdep(void) > struct mm_struct *mm =3D mm_alloc(); > struct ww_acquire_ctx ctx; > struct dma_resv obj; > + struct address_space mapping; > int ret; > =20 > if (!mm) > return -ENOMEM; > =20 > dma_resv_init(&obj); > + address_space_init_once(&mapping); > =20 > mmap_read_lock(mm); > ww_acquire_init(&ctx, &reservation_ww_class); > @@ -117,6 +119,9 @@ static int __init dma_resv_lockdep(void) > if (ret =3D=3D -EDEADLK) > dma_resv_lock_slow(&obj, &ctx); > fs_reclaim_acquire(GFP_KERNEL); > + /* for unmap_mapping_range on trylocked buffer objects in shrinkers *= / > + i_mmap_lock_write(&mapping); > + i_mmap_unlock_write(&mapping); > #ifdef CONFIG_MMU_NOTIFIER > lock_map_acquire(&__mmu_notifier_invalidate_range_start_map); > __dma_fence_might_wait();