From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1858CC25B74 for ; Fri, 24 May 2024 15:20:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AF6E6B008C; Fri, 24 May 2024 11:20:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 460846B0095; Fri, 24 May 2024 11:20:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 300176B0096; Fri, 24 May 2024 11:20:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 150116B008C for ; Fri, 24 May 2024 11:20:13 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B195EA1E04 for ; Fri, 24 May 2024 15:20:12 +0000 (UTC) X-FDA: 82153650264.25.BD1244C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 61A43120018 for ; Fri, 24 May 2024 15:20:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FeDStk13; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716564010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ZIpjSpVhGXFqbeIYTEMQJjeeXWxW1gA9+eSsQ9QaIk=; b=jpqtfFB8ka5Nf9wpGwFhZNSzDZuKNQo9HVyOVKve3cNy9WG7HibVNYHSNuE8sCRD8XIyU8 ARISa42qSpFQ+FHILQQxcXk+2g5sVw97F8kuBfPvJVRwLsMB+TI1tC6v8/GdQWOTELOHS5 gR2vGx8Dz94uJXIwotrPDcUIwDgbpA4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FeDStk13; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716564010; a=rsa-sha256; cv=none; b=GkBM/wlmDYkjELjf63fm2oa0G181AvVtQ+CUg869IPfuA3b7c1UlcufCQEWxex/WNqT40k GJadcJnhyynisuTaxoBXSgdBfremyP7lhiyHIqi3V2rHXoAfBtRVNN1ATS0WR0/SPW5l3X Ri28Apz1GGcVkri0ccDxBO2PoBjpOYg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716564009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1ZIpjSpVhGXFqbeIYTEMQJjeeXWxW1gA9+eSsQ9QaIk=; b=FeDStk13quYHuHiJNMTyetiTSrZBsuxy1sqdh3sL1wGXUtJrjbuXQCpmORwtGQZmbGDsZC vJ/iKg1ofJ++Ov+8AVGXdI8Jd/V87kwzUsOIOGnXza3488aHPtjrDwub9f30kGdIZO1YlJ V5szLHVw2DKlc2VIuLVJkX07VxshNhw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-GSq6Wb7_MPaFRdZ81NEVug-1; Fri, 24 May 2024 11:20:08 -0400 X-MC-Unique: GSq6Wb7_MPaFRdZ81NEVug-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-420fc4241ccso3015075e9.0 for ; Fri, 24 May 2024 08:20:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716564007; x=1717168807; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1ZIpjSpVhGXFqbeIYTEMQJjeeXWxW1gA9+eSsQ9QaIk=; b=s+f5jpgBaucis9Hvq1w7YRxepjRNc3J9OQT/griHkklKUxjwTX6oTXo+24pypEt+Y0 EedD6jhC9RdDUmnUSEmirEyEWr2iUzTj8X35KogsCoNvyZdQY4ZgS1u6AZ235SH/Awzd gzZ+aZDFMxDCE54D8p5Emk3IIrNhqZLBq4qp3NKRhOsc25hEYug/81RhgVbZcODRqMgB M1XxjC9uycCpy3x9X6b+2tWK1xoMyad1ecXSvLkZb+CQ02yho9ONJdRJes0RZZGS5j5b 01prwX0p91OI81FoxNgT+3nXYY3Yp85oOb2HRnGlL522wjNHXXzgzWbxrtLWMkiRvmdQ L+jQ== X-Forwarded-Encrypted: i=1; AJvYcCV4bQsTnCIuiP/vQRuRfrRk9cR+sYGqu4sRHUYYv5Fhym0EyQdTzidQZNRNwoki4RzN5y4w9bnc62UYdKmmZc1iNxE= X-Gm-Message-State: AOJu0YwFLrGjLz0u9VH/Up1dM6htUsmpzP1NJvDneLRHHf0+2pqmcE5X yh/VelQrKegxPs64GAdV16oND4X0pEISHIK2u9kvp1fYh2q0EsjCfLPOQnrBdqGKccnXGhiaJYw 6r/JO8fXsIwN9gAnwNBW/fHJ8M7ePrropAmi9Yfp0WJi3Izx9 X-Received: by 2002:a05:600c:3152:b0:421:757:4d3e with SMTP id 5b1f17b1804b1-42108a40f7emr28519905e9.16.1716564006934; Fri, 24 May 2024 08:20:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0+MT4DE5ofWCxfrSzCht7nuRPo1YsHdujhPfIDVrENkF3v+gPtlH5pDAMVQnnZJrG1araOA== X-Received: by 2002:a05:600c:3152:b0:421:757:4d3e with SMTP id 5b1f17b1804b1-42108a40f7emr28519685e9.16.1716564006451; Fri, 24 May 2024 08:20:06 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4210896f442sm23071615e9.11.2024.05.24.08.20.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 08:20:05 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 17:20:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() To: Donet Tom , "Ritesh Harjani (IBM)" , Andrew Morton Cc: Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Muchun Song References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> <20240523195734.bc03a8822a34b1a97880fb65@linux-foundation.org> <7792c8ba-39e6-47ee-9b43-108270325c15@redhat.com> <87o78vsoav.fsf@gmail.com> <3c6e5e78-aa49-4002-941f-af8fd2b81d10@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3c6e5e78-aa49-4002-941f-af8fd2b81d10@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 4ecqrhmdoqp9utx87meko59qwfanqjwo X-Rspamd-Queue-Id: 61A43120018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1716564010-576376 X-HE-Meta: U2FsdGVkX1/ZCheNfZnL37ltKNRelWDI7NfP/MGrIpS6ivGPmb+JbBIRNmSFWBdOlFI+klrnCgsbbgkCPxtYwPQmGe8fMlvIaaciJxYbJ3cvkeopHLG7tNgf/oaEMoHWi2VmbnzwyyI/4KSkQcIRfSKV9hkzzpNO3vdeqCGLQLwpETvs3Uq08RkiUGL8sI6Q4Kix2AbbIwpoc7RvnUJX8I2gtqp5y6t7Xtm7NqnHY7XbubnUgYN9JmAJigoKw7d0KZhCif4pVZ/fA+Lk7L67fKr40PQamh9exYda6E07kF32mAMrHgeOsPkyvr4dO7xMo60gzVAvffolSYkqAlr9mnO0ZZRrZ/n4jbuu2lKqfCXqqahd7xEeMXkrCOkGSAy4ZJF1BRt/2T1yeWzdUELPzp2nlHU0o2QWhpO6NwSP+9bDw/Y61a6uEDx76086STVzUyS70iGpw/JjzxW6YYyhmax2iUUUdxWaorcarX3EvWveQiUOks1kaAw7qdKRHxnuzR04V7QQiTVoM7tOgyvyKk++VAnExqmFon/ncOLGn3sN7d97K89meU6XhF6FaFgqwesFWhEgk8CaGuLvW1KdIrgTNPqW8A5E+SLzHoBML4UUHd1NtSdj8gPE9l6VRsT8UPbrvT18636cqoOEX91d33DhjgwsSMaRtFIGwRHGojAtjmvVOGl6wfpkpvrx1zHu9UKrtc4Cw0TUzaXqypy1ShnKEgrySJBu7PeyEKtbitNjTO0eu122xEgFtHelS9vxkJoSxtkdVCqNtzVkjclodlZBKGIGb2gaioG+xw+i3l88kpHhtDh7A01hazUQgY4JBeE1Gh0nBRFNLkrzvfxCjpaDQ/EGlQWqIiPt9Np6PjIdSacgNliq8KryXl2tcJNfi2sp7u6iF6cxaFwH9lj2ZKNA4mGZu37lxVSa3D0lkGHfFkLxMGTSWIalZV1qhTTg+AFG1zJKllG5KCuylOd oX3eC3J8 lP2vkNt0x7JIgEE66JMvV2ISdR+5ige7KDqAHJbf4oGrzseoavD4ZpAdWdu/4WO7u3yzsnE1D+J9cHX5GCoNMjMKpmdYRmW97Nz7/RoCv6Zjmbq1gkq3ii713utHWUawL4oGhQ+CQEsNmZPFdfOM4Br2LsN6SfkhdC/Pnd6zAAwX6mrTEWpWJnhBdd7Y4PYxCU4qauC7tTIwUZyV892CeQKJnik6WMwq6rwQ4A+8hd0g5iC2QrGro1hBM0gd6gvtI8sVT0ArJkKA3zjBzV7J90KrMHmCl9dx2p0fZLl3pGJDvyZPWIhoZ90WbegoDmvwsg8t0Et/lcAIxwjtmcWTJa3hwMlzEhMa+bJUUNo4UBYgpz9hmWscKWgHwHFXiSXhnoIB1Lc1fXuGuygvDGBRyWCnntewz/2ogOXRROy4046ohJRjSLO25aVSuxlFr/4Fu9h69GEvhEMxk17xkUQsvzs8dln03gAexb7oiP7hEifaR38iv//OdAYOBYrcVcn5D5osLhl9QeddYwA8MPoe1qoh3Vw1I8W5ARuoiYSY6Bl0L40cNghRtm8cBHPvodNdbpmRIPeCPUQhAX1BNDXXiFIsPcRTeoTqrxGy9lqe5hT2S7lpvpEt/TThwU0VBn08YJO8hP6zQft8fc0pOTOUjHdDhEA9omiu147MvgtJouoGCHKee7NfVB1VRy1XdIidJA8+gjGkdFDx2fUqH7+2Na0ro3fsfT6R4wjKb1o2j33pYbJn6EE8dq+VHaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.05.24 11:31, Donet Tom wrote: > > On 5/24/24 12:31, David Hildenbrand wrote: >> On 24.05.24 08:43, Ritesh Harjani (IBM) wrote: >>> David Hildenbrand writes: >>> >>> dropping stable@vger.kernel.org >>> >>>> On 24.05.24 04:57, Andrew Morton wrote: >>>>> On Thu, 23 May 2024 22:40:25 +0200 David Hildenbrand >>>>> wrote: >>>>> >>>>>>> You have stable@vger.kernel.org in the mail headers, so I assume >>>>>>> you're >>>>>>> proposing this for backporting.  When doing this, please include >>>>>>> >>>>>>> Cc: >>>>>>> >>>>>>> in the changelog footers and also include a Fixes: target.  I'm >>>>>>> assuming the suitable Fixes: target for this patch is 38b43539d64b? >>>>>> >>>>>> This adds a new selfest to make sure what was fixed (and >>>>>> backported to >>>>>> stable) remains fixed. >>>>> >>>>> Sure.  But we should provide -stable maintainers guidance for "how far >>>>> back to go".  There isn't much point in backporting this into kernels >>>>> where it's known to fail! >>>> >>>> I'm probably missing something important. >>>> >>>> 1) It's a test that does not fall into the common stable kernels >>>> categories (see Documentation/process/stable-kernel-rules.rst). >>>> >>>> 2) If it fails in a kernel *it achieved its goal* of highlighting that >>>> something serious is broken. >>>> >>>>> >>>>> I'm still thinking that we want this in kernels which have >>>>> 38b43539d64b? >>>> >>>> To hide that the other kernels are seriously broken and miss that fix? >>>> >>>> Really (1) this shouldn't be backported. I'm not even sure it should be >>>> a selftest (sounds more like a reproducer that we usually attach to >>>> commits, but that's too late). And if people care about backporting it, >>>> (2) you really want this test to succeed everywhere. Especially also to >>>> find kernels *without* 38b43539d64b >>> >>> >>> Sorry about the noise and cc'd to stable. I believe we don't need to >>> backport this test. The idea of adding a selftests was "also" to >>> catch any >>> future bugs like this. >> >> Yes, for that purpose it's fine, but it has quite the "specific >> reproducer taste". Having it as part of something that is prepared to >> run against arbitrary kernels (which selftests frequently are not) to >> detect known problems feels better. >> > I have seen some hugetlbfs directio tests in LTP. If you think > selftest is not the correct place to add this test, we can drop this > test from selftests and add it to LTP. I think LTP might be a better fit to spot such issues in the wild. But I don't have a strong opinion. -- Cheers, David / dhildenb