From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FD5E7717D for ; Mon, 9 Dec 2024 22:10:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B625D6B00BC; Mon, 9 Dec 2024 17:10:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B10FC6B00BE; Mon, 9 Dec 2024 17:10:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98A986B00BF; Mon, 9 Dec 2024 17:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7929B6B00BC for ; Mon, 9 Dec 2024 17:10:17 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1F76D1607A8 for ; Mon, 9 Dec 2024 22:10:17 +0000 (UTC) X-FDA: 82876814034.06.CAF5856 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 98321120015 for ; Mon, 9 Dec 2024 22:09:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QyJ596sh; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733782195; a=rsa-sha256; cv=none; b=nKp1fT1eiTR1N73m9Le9J5DIFfIUsNUbrE4rpMT24fDZAHmXp/x2nWxnHw80xSWBfntrdK euIRQdAxx7M82PmAROXcv5Nk+ZqRFBStDVBtON5h3sV3cFUdd4xOtuH3WBt37HqU7R1Jd1 qcWa+LGCZvG7oolFXbnle1UljHMTHxs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QyJ596sh; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733782195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2JxTfKjhjkpYpIvRQuEb1aEOetGEKhwlUGR290jOn7U=; b=gsqlBprJ6X4s7bBomWpyz+VkqjR+gptMxfDmZf72sqpPl4ukj9QvTOCmEaX3spKy12L96m RswCpionzqffqZGyXOl6VuJICGOGCj20EXjes5te+G+qIj3gSPFxrDoqQcenBei7WhNe42 TWtaaqIX+xZlwhifB9+43BgFOowIcCU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733782212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2JxTfKjhjkpYpIvRQuEb1aEOetGEKhwlUGR290jOn7U=; b=QyJ596shqXHaPCpaYXOEgqsW2x+MK9WRKIhuoNwsa3mw504vt5EfCAv9jad/qJmS52+frL 1p5mm+1W5yGshXYanpP/KX05Ldn4ZIrRnUebqFjwSlM2BcvAcGVSMyH9mtO0ts6CD4RAMl yyML1ETZdWOasiAZi8lp0u8zD1jNpsY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-TLKz1rNHM82tGFnKngmIBA-1; Mon, 09 Dec 2024 17:10:06 -0500 X-MC-Unique: TLKz1rNHM82tGFnKngmIBA-1 X-Mimecast-MFC-AGG-ID: TLKz1rNHM82tGFnKngmIBA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-434f2cb3b4bso16445675e9.0 for ; Mon, 09 Dec 2024 14:10:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733782205; x=1734387005; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2JxTfKjhjkpYpIvRQuEb1aEOetGEKhwlUGR290jOn7U=; b=GA7fbPC5foQwWUx9Jpvw5APl1rFr6o3w6x+Mzl/E9h4rWc80vJVgig7PR61vtKbQWJ 4yQ4VKSmgbJDWO2bjPeOLlEGWx+WjPYkO6ZuCGp4Seh9ixJvNub7Ium6NW4iaEKdViBj Vlj3vtwkt5qqXU3sY3KX8dX1ZJ9ndyOrAHOOmB0hoDx02iVSMVzNUnauPgseIuR/h/wJ KQ47OcBY6SKIH8I8dWL04cjZxpMc0xx7CjRQjGYuYt9d3gsaKJceoTHCAR0Bw9EFqZXd IIZ2ynx1XeFJL3KW5OPj5fFLweVteonCs0tp9URVbyygr/4Xq/qgxrT2QNqDumKTu8e1 BYbg== X-Forwarded-Encrypted: i=1; AJvYcCUN/gj0tEF5BHXWUPOBAe+KldjYNbm33T+AyxymtHB/j86oC9mWVh79+h3o24VKYhslCCbb5+G35A==@kvack.org X-Gm-Message-State: AOJu0Yw5qNN1vrQ+npf/lxF+Rrd/Kn+I2swxd/j8U2un9RT2A6IM1GG0 aLIL0MGqop6hRJcvG3lVWlCJDRep2KEm8reHUZMcU2abOCUS+ymRb83xGd6LEJ0IWvA/t9UmhHl VZ86NyBiCSpQfGRKV1PVLsb5JcDuYwfT3FJ3UjfXWo66ASARF X-Gm-Gg: ASbGnctGFVtJ9h0U0E0KW6Y29/v0NDSK3wq0K504NL9YVJ/UHP0k33Lycs926cCLWWh BMV9iiaOfElQkIrA29caETfY12d1LFhBbsYeBfxOvlur8LTFFH5zYGcmTfsXNPULvTwC0Ad/tmZ 4lDuMF0uAJKp+6cAjyRcjnmAoIklzORkONK7xeoI4HV5q1cRlJyJT1ms8+ApaVMa2WWyKWSt8Nh F7kymxn2D2VwzGijNI4DvVXFp82Fv+azP4UDz+H54pSeRowVcrL2k6+jFmxV/Q6OAggwjytKcVe y2Ady/TXogI23q7FLnPsCp0zgWH4LFHaU4vr4l64F+kXGE221+NeMUHlDAb82dSCJRfBqYons9K HeNgm5g== X-Received: by 2002:a05:600c:4587:b0:434:f396:525e with SMTP id 5b1f17b1804b1-434f39653f2mr56321955e9.9.1733782205072; Mon, 09 Dec 2024 14:10:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IF5F3P7Dwui+9G+EH2upt5CoEWyV9pWe10lUwq+ecfXXQRcZm/ndQOyRS6lhpjhr/j8SU51iA== X-Received: by 2002:a05:600c:4587:b0:434:f396:525e with SMTP id 5b1f17b1804b1-434f39653f2mr56321845e9.9.1733782204634; Mon, 09 Dec 2024 14:10:04 -0800 (PST) Received: from ?IPV6:2003:cb:c71b:2c00:7bfb:29fe:9e6f:2e65? (p200300cbc71b2c007bfb29fe9e6f2e65.dip0.t-ipconnect.de. [2003:cb:c71b:2c00:7bfb:29fe:9e6f:2e65]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f13f735csm84820565e9.16.2024.12.09.14.10.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 14:10:03 -0800 (PST) Message-ID: Date: Mon, 9 Dec 2024 23:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] mm/page_alloc: conditionally split > pageblock_order pages in free_one_page() and move_freepages_block_isolate() To: Zi Yan , Vlastimil Babka Cc: linux-kernel@vger.kernel.org, Johannes Weiner , linux-mm@kvack.org, Andrew Morton , Yu Zhao References: <20241206095951.98007-1-david@redhat.com> <20241206095951.98007-2-david@redhat.com> <37B7A92E-B58F-442D-8501-B07A507F0451@nvidia.com> <0162E372-2B68-494D-8DFA-F3AF0EC6F5E8@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0162E372-2B68-494D-8DFA-F3AF0EC6F5E8@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 24Q2xyE0J_zhmmyVCYj3iMxIZv2h2_TqJ15G5DF0KbE_1733782205 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 98321120015 X-Stat-Signature: norggqawginqrtnshm3m9kjyjq3y5aaa X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733782183-818978 X-HE-Meta: U2FsdGVkX1+kL8Nt1k8IKOo/f8agdkgYK6RO+pDCnx637d1m3pFPwUOloGBEToJGZk/HdI8JWNIHRaSH/2oydEuCKSJJ5gtKoxmU1nsfFFe2aV+fPz/Vk5HjONPFc0/ihHvN4b7xzTzyUFVEUoxlqE+0oUqB6SR5MDDLWP4/WUHMTPDRF7VPPe7pxl5N4F/uS+p216l8bryeATsmJlUCC1XrFsScIIScEEJxLBe9MrV0lt2SvioWx3ZOFc2WHUZ30R1sCWQAR4wPoNWk6VPJ2QqsbtuL5LRo9/GsP5Y5X54ZWaNvh75WDvMGTSagZW0oCikmPNv/qPIj1V1rLI60ktwGCR9gfvOgEp+xzsho5fowR0rvEsFIihzID7YKoCBcp1QNrmtFR8DMp1zaGVUIFKrHzegK1V83hUGF+dBmrrLtgAFKBHDiVjy/+oZtG5HsfD6judPVpdaQDAdc1qS2qVa5ZFshGfAAMkwNfZiSaAHNEvX7R0IdY891YdyXA96t35QT4m19zP7iNImdR7ENGxdow4CSb1/ofJgcwyo/lrlXAuQ69O0CKGbOGYfDmGj/1pr7axPahSauFg9z8GN0mjhyFr0lqnEPSljCtYYxP289XaSrVDxPXD37swYdmGoVspY70O2WDh8Nc/Kcx9GxMnf99/OPgtl9MchekmOJEVHMglDoWwPPIGvHkphKKKmi8OPBE6W0oDJiDwAx6pVGeN5LHfbDJ8ksARHPcpaITFP97w2E+fud6vfuJg5iP7WcjKsU7pmHsTbzRhT2YJvljjONyVSsqVdCbh/UzLFgBFJt5LJChc1KGRifWRtSI22KVXwBLw+gm7nw/CNb59/PYIRyEbmwU6zkE8ZMQ1KMcfTTEOlKYJ2tfE3y+kHBQEKAya11w07eWgCOgMWZv4BzdU5J2tg1ufkN8C4w4jrH6WhmFJ6AdhdksuRMFHjaFetIeGJ9NBJn+uGC9RxAc6M efSvMp7s eGZrio7nCo0gDl16SxhoX+TAhtMvDiXsKW7S+TaQHvC97PFxHrgGboO4dL2aA/MDhhgIO2FHQ9wyw9ASPlY6GPneyLyEbf77IME51tEA6eUxGQh3/XC2TTUHdZEVdjucSYH24iQG1oU1otsyJ9o6swOvkCn6Fda647Iv5GQ3ptRImc5ILUeRBe6fMX4oRlMbrOF/eLJ13chH53YQO3sMKTHWltGwzS4wTWtLsF2S0iI7ZO7/2Wa3xE13VxwTK50mkI71300GUHcxu9Wusii1fxyNRthm4qM7mjTQSkKeyRS0MnGsNAx980PXY8HyFZ7ynDbMrZvafBJqt5bDEtObJ6tQrSTQ3kO0SOl48gCoEG17DD4N852as7IYGuZ4vRwTkoUpx5DB8RuSGhMSH2n9NBWX2WL3TmtFoXHBjKKaG3Lm4h/g4iU9H/C/x5DIHwS6B0kYDi4KLEQfRVfINYsDBsa/p1XDdf/z+zZ0/dJBoPeEf/7LFkbBOLVP8KQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 22:42, Zi Yan wrote: > On 9 Dec 2024, at 16:35, David Hildenbrand wrote: > >> On 09.12.24 20:23, Zi Yan wrote: >>> On 9 Dec 2024, at 14:01, Vlastimil Babka wrote: >>> >>>> On 12/6/24 10:59, David Hildenbrand wrote: >>>>> Let's special-case for the common scenarios that: >>>>> >>>>> (a) We are freeing pages <= pageblock_order >>>>> (b) We are freeing a page <= MAX_PAGE_ORDER and all pageblocks match >>>>> (especially, no mixture of isolated and non-isolated pageblocks) >>>> >>>> Well in many of those cases we could also just adjust the pageblocks... But >>>> perhaps they indeed shouldn't differ in the first place, unless there's an >>>> isolation attempt. >>>> >>>>> When we encounter a > MAX_PAGE_ORDER page, it can only come from >>>>> alloc_contig_range(), and we can process MAX_PAGE_ORDER chunks. >>>>> >>>>> When we encounter a >pageblock_order <= MAX_PAGE_ORDER page, >>>>> check whether all pageblocks match, and if so (common case), don't >>>>> split them up just for the buddy to merge them back. >>>>> >>>>> This makes sure that when we free MAX_PAGE_ORDER chunks to the buddy, >>>>> for example during system startups, memory onlining, or when isolating >>>>> consecutive pageblocks via alloc_contig_range()/memory offlining, that >>>>> we don't unnecessarily split up what we'll immediately merge again, >>>>> because the migratetypes match. >>>>> >>>>> Rename split_large_buddy() to __free_one_page_maybe_split(), to make it >>>>> clearer what's happening, and handle in it only natural buddy orders, >>>>> not the alloc_contig_range(__GFP_COMP) special case: handle that in >>>>> free_one_page() only. >>>>> >>>>> Signed-off-by: David Hildenbrand >>>> >>>> Acked-by: Vlastimil Babka >>> >>>> Hm but noticed something: >>>> >>>>> +static void __free_one_page_maybe_split(struct zone *zone, struct page *page, >>>>> + unsigned long pfn, int order, fpi_t fpi_flags) >>>>> +{ >>>>> + const unsigned long end_pfn = pfn + (1 << order); >>>>> + int mt = get_pfnblock_migratetype(page, pfn); >>>>> + >>>>> + VM_WARN_ON_ONCE(order > MAX_PAGE_ORDER); >>>>> VM_WARN_ON_ONCE(!IS_ALIGNED(pfn, 1 << order)); >>>>> /* Caller removed page from freelist, buddy info cleared! */ >>>>> VM_WARN_ON_ONCE(PageBuddy(page)); >>>>> >>>>> - if (order > pageblock_order) >>>>> - order = pageblock_order; >>>>> - >>>>> - while (pfn != end) { >>>>> - int mt = get_pfnblock_migratetype(page, pfn); >>>>> + /* >>>>> + * With CONFIG_MEMORY_ISOLATION, we might be freeing MAX_ORDER_NR_PAGES >>>>> + * pages that cover pageblocks with different migratetypes; for example >>>>> + * only some migratetypes might be MIGRATE_ISOLATE. In that (unlikely) >>>>> + * case, fallback to freeing individual pageblocks so they get put >>>>> + * onto the right lists. >>>>> + */ >>>>> + if (!IS_ENABLED(CONFIG_MEMORY_ISOLATION) || >>>>> + likely(order <= pageblock_order) || >>>>> + pfnblock_migratetype_equal(pfn + pageblock_nr_pages, end_pfn, mt)) { >>>>> + __free_one_page(page, pfn, zone, order, mt, fpi_flags); >>>>> + return; >>>>> + } >>>>> >>>>> - __free_one_page(page, pfn, zone, order, mt, fpi); >>>>> - pfn += 1 << order; >>>>> + while (pfn != end_pfn) { >>>>> + mt = get_pfnblock_migratetype(page, pfn); >>>>> + __free_one_page(page, pfn, zone, pageblock_order, mt, fpi_flags); >>>>> + pfn += pageblock_nr_pages; >>>>> page = pfn_to_page(pfn); >>>> >>>> This predates your patch, but seems potentially dangerous to attempt >>>> pfn_to_page(end_pfn) with SPARSEMEM and no vmemmap and the end_pfn perhaps >>>> being just outside of the valid range? Should we change that? >>>> >>>> But seems this code was initially introduced as part of Johannes' >>>> migratetype hygiene series. >>> >>> It starts as split_free_page() from commit b2c9e2fbba32 ("mm: make >>> alloc_contig_range work at pageblock granularity”), but harmless since >>> it is only used to split a buddy page. Then commit fd919a85cd55 ("mm: >>> page_isolation: prepare for hygienic freelists") refactored it, which >>> should be fine, since it is still used for the same purpose in page >>> isolation. Then commit e98337d11bbd ("mm/contig_alloc: support __GFP_COMP") >>> used it for gigantic hugetlb. >>> >>> For SPARSEMEM && !SPARSEMEM_VMEMMAP, PFNs are contiguous, vmemmap might not >>> be. The code above using pfn in the loop might be fine. And since order >>> is provided, unless the caller is providing a falsely large order, pfn >>> should be valid. Or am I missing anything? >> >> I think the question is, what happens when we call pfn_to_page() on a PFN that falls into a memory section that is either offline, doesn't have a memmap, or does not exist. >> >> With CONFIG_SPARSEMEM, we do a >> >> struct mem_section *__sec = __pfn_to_section(__pfn) >> __section_mem_map_addr(__sec) + __pfn; >> >> __pfn_to_section() can return NULL, in which case __section_mem_map_addr() would dereference NULL. >> >> I assume it ould happen in corner cases, if we'd exceed NR_SECTION_ROOTS. (IOW, large memory, and we free a page that is at the very end of physical memory). >> >> Likely, we should do the pfn_to_page() before the __free_one_page() call. > > Got it. Both you and Vlastimil gave the same corner case issue. > I agree that doing pfn_to_page() before the __free_one_page() could get rid of > the concern. Thanks you both for the review. I'll resend a v2 tomorrow, including a patch to fix that up first. -- Cheers, David / dhildenb