From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9664BC61D9B for ; Wed, 22 Nov 2023 19:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD726B02ED; Wed, 22 Nov 2023 14:35:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7A166B02F1; Wed, 22 Nov 2023 14:35:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1B476B02F3; Wed, 22 Nov 2023 14:35:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADAE86B02ED for ; Wed, 22 Nov 2023 14:35:25 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7BF76120D23 for ; Wed, 22 Nov 2023 19:35:25 +0000 (UTC) X-FDA: 81486594210.13.14FB6BE Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf18.hostedemail.com (Postfix) with ESMTP id 625731C0025 for ; Wed, 22 Nov 2023 19:35:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=u2TiS0xI; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=HktlyKuM; spf=pass (imf18.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700681723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lx3Gf8Ml5YHZ79DEZBtfhV6TJngHlrEmAjf3G2BUG5I=; b=KJSrO0QSYDmhha4NUydo6W8RChMjUGKQKpRn36xjfG/CWuI3aIiVM2NiX+UH/CpaeHK4/G 9y4gQmpaHMHTTSPi4UMg5djKQnHyYwRx3LHSAGqlAs5zlHercdR2rqXjkptXf8cmTKx/Tt olt2ufKCDHVXTz1pK8fL8kJI3cFv1V0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700681723; a=rsa-sha256; cv=none; b=M1wGbOaCdns0UfCR5Wi3rHVjpCHN7lbUYMas3hTylYSn5iLAcPwDYDvP6PaAUJJs4FJFEn 7EGTHDjUoS6pcXyCzNCQvrLMEpB4e+T4cR7zQYf+2B+6NbLJxCFNag7yGGAJxTdKJnnDEZ pconlottSEobZsCBL1oUW0oFgPhQnDs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=u2TiS0xI; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=HktlyKuM; spf=pass (imf18.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=none Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 983C35C0231; Wed, 22 Nov 2023 14:35:22 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 22 Nov 2023 14:35:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1700681722; x=1700768122; bh=lx 3Gf8Ml5YHZ79DEZBtfhV6TJngHlrEmAjf3G2BUG5I=; b=u2TiS0xIOQsffzBAVU JSTs2mGFfVTuQMlgIJgHNPnrhs78q46sLtXDhRnurDbnCTVctxhViklKISCbXqPJ 4zklquNGsoexd+vDTADrs5yNRWdE8cNDhrKrQPrcT6KxgF80yzbPKqc3Aowq1yJ8 EmU0xsb04QOXaRiCBNSDVlt+k9fXanRUneRaXg4Llmo3gShROyoFwVzU6nAAzkH8 VPvMLjauYd75oxdJ3jmOOLieuJYh8o4TJgz8XRtQ7uh/AQbSS4681JPFeJau9SKu CdMal+gFwVhzjafLGclkZ1iOcuQOb7AmNjZg9/LWbHPI8hSH3qKTzmm4BHs/DOZ4 Wgkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700681722; x=1700768122; bh=lx3Gf8Ml5YHZ7 9DEZBtfhV6TJngHlrEmAjf3G2BUG5I=; b=HktlyKuM6aaLQ6S2eyF6AyJosR+pQ GNgRH40Ywg+gkZwQdn7moY7Y+59ZLJYiZXNuMHoNwYQeMNA+AznC17pC/OVohdY5 VjgrTYOHShDNF32knHfLUxlcUM7NrzSiR1BgduQrFf7RMpQUYSoS6ltoKwZxrj/K bot0k9SLRayF03N1tB7c29RBqOR0UpnXva1ckBwYUDFsBiwgSmdDF7GAoMo+Y24k KBfpTDhZpMIY6HZTVCG+3WfB9BUsk+Mpi9k4E5orXrkaCSgQOD0fkYVjnrhQnGo/ UqA6hynC/XUYcwf7kxAWekWr21Q5GLcWMiQItvhrcbaNMV0G7Wj+tLfNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6E100B60089; Wed, 22 Nov 2023 14:35:21 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1234-gac66594aae-fm-20231122.001-gac66594a MIME-Version: 1.0 Message-Id: In-Reply-To: <20231122182419.30633-2-fancer.lancer@gmail.com> References: <20231122182419.30633-1-fancer.lancer@gmail.com> <20231122182419.30633-2-fancer.lancer@gmail.com> Date: Wed, 22 Nov 2023 20:35:01 +0100 From: "Arnd Bergmann" To: "Serge Semin" , "Thomas Bogendoerfer" , "Andrew Morton" , "Mike Rapoport" , "Matthew Wilcox" , "Tiezhu Yang" , "Huacai Chen" , "Yinglu Yang" , "Jiaxun Yang" Cc: "Alexey Malahov" , "Aleksandar Rikalo" , "Aleksandar Rikalo" , "Dragan Mladjenovic" , "Chao-ying Fu" , "Marc Zyngier" , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Content-Type: text/plain X-Rspamd-Queue-Id: 625731C0025 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: a5sx98dntmbk1rtmeo18pzhkycoqpmjz X-HE-Tag: 1700681723-553461 X-HE-Meta: U2FsdGVkX19HgRfyWMGi+Go5H1D8K1Snejox5si49rEqO9nfTw5sH9RaYzcNyJKhQNTt5J5NTlGkKxZoQFdCiaxoKNXE//h1phWFn81gnlFrVjFsRGQ0Mf+hXnfg4s/X8lhCOGLBq+wof390hwAVxVjGh9m7wbs6+9cPu84EY499VwYuvAVBh0XPuZ8H2wUw1ZhxJHEaFKiTbfFihh0XPH6ccDUNnCyzcy6YG5uPvaZixEJV01Yls3vGmYhIalNuC0D4XaEUYgKaZdPD185WwdhU/rgcUac9MqvRzhNCX0CTqpKFaIAUnrJRGNgtPQMbmkEir6pACUGoZXz/rA4VEtb+m9A1uZVkTak/fhMGAaQ4dZvIjkXzGpH/9pfacOBH9X6QUSMj6k1FV37AXxKxSN8IOpO2FzeEqRt1+v+ZZAvmVYgaR7BtL+fLQ15XKPbdK2DHqMvQZ77DgRbQkbNcdc6689qagFXWb+ZOW1pq6Lf6Z9GzJdpCFcyGoLDIn30iH3+El92uSVQrMmRdDW3GQMj74EzDZ68+9qNou0o9HHyxff3rRWPF2JS/rqMscFa9/dUgC+DBivJtkE/Yah/egYJfA4reqr2UDF6aCh3CrctgTRfhD8ppzOCL6swmqcz+z0AmjV556DLrz0FET9GjATuit5Bz4vj4gx2oHqi8sR5bvhPk/JeXZy+NWpy2Kmv/Ht/vG20BJmwlz5fU9anOhlFZXfRAHpkvDKPnbQljED2u/5mbMv0jXS/SIrgJ3vCMyf3rqJMofi+qfgpoZ+WmUuFKRXIkIooEprvHfM4QQJSWh+4X3DCvw4xCyY2GEPV7uvTJinflFsS00FHmyU/ik3ErClkLCMDWdkgO6XyKAOeyT3CgFjVlaAo5GXXAgSamQmvll8U5gApr0Ic+tt0AEhXZYXdG32pIotxJVezn8wT7TKXqzMZo2jMIFUDyYIT1p8p3q+GorPofWGuNnJB uc3pozo3 gatDW89Z92FD6qm4LmqjHwlCllHoN6P9PS9uVtSoNl7NABUckZLLrBJH94uNG3lPGelF268av2U1juVWklnKhdvrSaiLdqmI5WaKh//YmqC5vymXJL/9WC3oadUmCIdYD0welVKWbgFbiLflsiVKhN41Uo/RqRaSFFJzpewAV0hhb/1WfxAoqg8A4eVWgCbH0C1tswvHEAup2QKh+eG0KutsGj3nqJl1QgYv6kiDf3U2uOFobL14Eb03XHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023, at 19:23, Serge Semin wrote: > dmi_early_remap() has been defined as ioremap_cache() which on MIPS32 gets > to be converted to the VM-based mapping. DMI early remapping is performed > at the setup_arch() stage with no VM available. So calling the > dmi_early_remap() for MIPS32 causes the system to crash at the early boot > time. Fix that by converting dmi_early_remap() to the uncached remapping > which is always available on both 32 and 64-bits MIPS systems. > > Fixes: be8fa1cb444c ("MIPS: Add support for Desktop Management Interface (DMI)") > Signed-off-by: Serge Semin > --- > arch/mips/include/asm/dmi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/dmi.h b/arch/mips/include/asm/dmi.h > index 27415a288adf..525aad1572d1 100644 > --- a/arch/mips/include/asm/dmi.h > +++ b/arch/mips/include/asm/dmi.h > @@ -5,7 +5,7 @@ > #include > #include > > -#define dmi_early_remap(x, l) ioremap_cache(x, l) > +#define dmi_early_remap(x, l) ioremap_uc(x, l) Please don't use ioremap_uc() in new code, we are in the (long) process of removing it from the kernel for everything except x86-32, and it already returns NULL on most of them. Would the normal ioremap() work for you here? It seems to do the same thing as ioremap_uc() on mips and a couple of other architectures that have not yet killed it off. Arnd