From: Ryan Roberts <ryan.roberts@arm.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 07/10] mm: Convert arch_clear_hugepage_flags to take a folio
Date: Wed, 27 Mar 2024 13:02:24 +0000 [thread overview]
Message-ID: <b9944ac1-3919-4bb2-8b65-f3e5c52bc2aa@arm.com> (raw)
In-Reply-To: <20240326171045.410737-8-willy@infradead.org>
Hi Matthew,
On 26/03/2024 17:10, Matthew Wilcox (Oracle) wrote:
> All implementations that aren't no-ops just set a bit in the flags,
> and we want to use the folio flags rather than the page flags for that.
> Rename it to arch_clear_hugetlb_flags() while we're touching it so nobody
> thinks it's used for THP.
>
[...]
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index d748628efc5e..cc420c42a773 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -837,8 +837,8 @@ static inline int is_hugepage_only_range(struct mm_struct *mm,
> #endif
>
> #ifndef arch_clear_hugepage_flags
You need to update this line to the new name. Currently failing to build on
arm64 since it now defines the new arch_clear_hugetlb_flags.
> -static inline void arch_clear_hugepage_flags(struct page *page) { }
> -#define arch_clear_hugepage_flags arch_clear_hugepage_flags
> +static inline void arch_clear_hugetlb_flags(struct folio *folio) { }
> +#define arch_clear_hugetlb_flags arch_clear_hugetlb_flags
> #endif
Thanks,
Ryan
next prev parent reply other threads:[~2024-03-27 13:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 17:10 [PATCH 00/10] Various page->flags cleanups Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 01/10] sh: Remove use of PG_arch_1 on individual pages Matthew Wilcox (Oracle)
2024-03-27 18:45 ` kernel test robot
2024-03-27 18:49 ` Matthew Wilcox
2024-03-26 17:10 ` [PATCH 02/10] xtensa: Remove uses " Matthew Wilcox (Oracle)
2024-03-28 19:36 ` Svetly Todorov
2024-03-28 19:40 ` Matthew Wilcox
2024-03-26 17:10 ` [PATCH 03/10] mm: Make page_ext_get() take a const argument Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 04/10] mm: Make folio_test_idle and folio_test_young " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 05/10] mm: Make is_free_buddy_page() " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 06/10] mm: Make page_mapped() " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 07/10] mm: Convert arch_clear_hugepage_flags to take a folio Matthew Wilcox (Oracle)
2024-03-27 13:02 ` Ryan Roberts [this message]
2024-03-27 14:37 ` Matthew Wilcox
2024-03-27 15:48 ` kernel test robot
2024-03-27 17:01 ` kernel test robot
2024-03-26 17:10 ` [PATCH 08/10] slub: Remove use of page->flags Matthew Wilcox (Oracle)
2024-04-04 18:29 ` David Hildenbrand
2024-03-26 17:10 ` [PATCH 09/10] Remove references to page->flags in documentation Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 10/10] proc: Rewrite stable_page_flags() Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9944ac1-3919-4bb2-8b65-f3e5c52bc2aa@arm.com \
--to=ryan.roberts@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox