From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C77C25B4F for ; Tue, 7 May 2024 11:17:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A3456B00A6; Tue, 7 May 2024 07:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55D226B00A7; Tue, 7 May 2024 07:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441F66B00A8; Tue, 7 May 2024 07:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 274266B00A6 for ; Tue, 7 May 2024 07:17:43 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D87C6121015 for ; Tue, 7 May 2024 11:17:42 +0000 (UTC) X-FDA: 82091349564.23.3158A9D Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf20.hostedemail.com (Postfix) with ESMTP id 5DB421C0012 for ; Tue, 7 May 2024 11:17:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715080660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yHmGTrqD6ivYDAkle4eOw/ARu3UjWr7V79hW6hJV5O0=; b=gQxeJegBbEwWdl88n0aNfoZewyVVSYiqAf+uJKqj3mkD6X8XDmDncR56macpsDbXLEguYj vwcOw9BVQQgn38Lb6rLxSIUdQjG8aWqOPOJroG+jSu813G5u66G9wsfmdMojVNQFHHjnwb 77VJQ7zP05wo6cw5HlvLDAWclBKZo2Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715080660; a=rsa-sha256; cv=none; b=ccTV04K0II39NC4aGk5rROEcS+sdiDHG4bSzbIV84Oo/P3OewMWvw/PZ985GpnH6KKB+Ku l4XUTN3TgUHgyBkz3qczDzT0ICXbYJ91RiQRe0DZ5hiuftz1VXO55mN2ueOSJa1Wc4QxHz OJHqNwAQHDwf3hOImtnIgwrfnyz0im0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf20.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4VYbK66NBsz1yn0M; Tue, 7 May 2024 19:14:50 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 2234B1401DC; Tue, 7 May 2024 19:17:36 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 7 May 2024 19:17:35 +0800 Message-ID: Date: Tue, 7 May 2024 19:17:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next] mm: memcg: use meaningful error code for return value Content-Language: en-US To: Matthew Wilcox CC: , , , , , , , , References: <20240506133643.1124102-1-xiujianfeng@huawei.com> From: xiujianfeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5DB421C0012 X-Stat-Signature: wnbtcpf45i81didh1tuotxpcpp5w4u73 X-Rspam-User: X-HE-Tag: 1715080659-284792 X-HE-Meta: U2FsdGVkX18CZLqefBon7hIjLb837bMJ/1QjS5sELfs0mkjWwL93E5mnL0bfZ6XRDWoX93wrGTUh8CiVefCNmX+Ff7jl9NNpp/qxXWq1LoMsDmy6r9GcNWu/9nhQOlZzXpQD8bC4Jbl/I9ueiXxhEGm3cycZ1BL5aQUiMrlo26lMN4Ygy+O5atrImxHyJziGnASKfgsW8jObR8U/Kiy4kLV52wLeaMQTXZrfohUmepW3dw4RyNLyP5hvfZlWsPskJO+K/PcgbKrhyXHYszRndCTwytAbchGqZe0BVGJIFBv6zdv+Ju1kUrC5mdu6HOK8VD3Zg8tt40xIg23GvDsmihdbOGK+KC9TB+5RzG5hz7edcgw8E3MOWb6/AzxpLCay2D2fboZ/HEZ6d53Mq+6E25dwx9wFuH6cM0YEAxkAmjonAw4t1kyjJH5SGAJYGPTATNTbEAmAbkpIas8+D0Tjf/vjY/JxI/mdNnYXwHLA7n1KCgjkBUVU5OClb8STBwG0dX1OfJl53O/Ryl6P7gZdrksNUxNnbLpl5E85DoQ26jRREr/6yp4jj3w6pwJzOgYu77/VANa7OVZKg+lsDVt2lvwU97kHY0tbY/dMbbTHwrMXB5ic675bZrVSnOXa0yM2COZ8LZMEW/To85QBrxyjuWjHL3yMlNxt5+LC7UDyuyXPTej2GEHEStrSMowWtkE5tZVWHzjAu7d6UvLUQyoR+TrY3l6r9EeEWaZU1np/8Gw7YPC3SuQq/Rc8yyT/vevOnOz8D41KTtC88pRdOwVs/d+hg+Z1jBDY7+IlpDzwEeoe6QPnuU6ax/Sm/CVOjdXe9XxWgXRnofLsTBt/cGMfkMKuidBgFU0e3KYrRCDph9Wh4C446y7+NbQd2rLrm1RJSrudeQ3DzOYUXSvucfX+2pvBu6D281E2DF0IcX8xN93PSTMJXxGbNjuh4YEUDfDlbTmpKqAJvgUJhK26o01 pjZGZrLX T0eqdNaYp28/MCiTmbuHder61NlAUV601ltIRGhPN80jwAZegn0ayvXcwEOFAex4UE0nD8dU/5lDGJRSeRNC42lrIRp8KlAue1QuaBmaBnp/n3EnLPOqdN7mbxPvKBT6ybbfs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/6 21:53, Matthew Wilcox wrote: > On Mon, May 06, 2024 at 01:36:43PM +0000, Xiu Jianfeng wrote: >> alloc_mem_cgroup_per_node_info() returns 1 if failed, use -ENOMEM >> instead, which is more meaningful. > > This should probably be changed to return true/false instead of > an int. > OK, already sent v2.