From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D65C282C1 for ; Fri, 28 Feb 2025 15:49:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C3C66B007B; Fri, 28 Feb 2025 10:49:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 174526B0082; Fri, 28 Feb 2025 10:49:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F08866B0085; Fri, 28 Feb 2025 10:49:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D150F6B007B for ; Fri, 28 Feb 2025 10:49:28 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 88209120DE9 for ; Fri, 28 Feb 2025 15:49:28 +0000 (UTC) X-FDA: 83169788016.02.3B5F5D3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 3739D1C0013 for ; Fri, 28 Feb 2025 15:49:25 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mp65QVT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PwZooPW7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mp65QVT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PwZooPW7; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740757766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X30CzGKpErV/mbzwMYQ0nUzc2buSuGpj1sVMr9Ac3sM=; b=2JHIvE/W1HxB0DrBtsG9Yy37NiMmeriSYBrF65ApYL62mnxloYgYqRIwnx+fwDnbjY8jW8 D7Lm0GqOkY+O0SkMHSn7ahR0/5/zoZWBZU8dAWGOEhEacT2K3jhIf9AT7AvO8NEN0MkDYS 5AnrDDTa7pSJj3cDdJj6FuNWtBoIUo4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740757766; a=rsa-sha256; cv=none; b=L1qlDLvGbLeEpG4GnE0ASvewf6UQy+Q6K5i8MjAxy3d+t5vIFtz+gw0TjAUtu5hvbScDCL LiKxCx3xGjfXS4PGxWHk+pWApeu0kgCkS/9XZa/yE5kIEMLlqBhHeVL1X0Qf0KF8EM/m85 LLoFhFn9YrKQQAUB79PC8cp9IgXUI38= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mp65QVT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PwZooPW7; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="mp65QVT/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PwZooPW7; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7B7EE21179; Fri, 28 Feb 2025 15:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740757764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X30CzGKpErV/mbzwMYQ0nUzc2buSuGpj1sVMr9Ac3sM=; b=mp65QVT/+RW6cASixZ6Jc6/CfrYVjBZP6gFNe98pIHBwMjiW0zW1lkEWBxYHK3Z6QTZgI6 2tWuCGU2dFAzc/twRPgVgL5xH0fglFFcHMuj7U+A/WNykeRMlQP/aszId5ba7joEXSY7IF NO8zOWV9as7kKWteRgt/nJRU8VsoP/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740757764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X30CzGKpErV/mbzwMYQ0nUzc2buSuGpj1sVMr9Ac3sM=; b=PwZooPW7rytxRpZ7sXkWufegZ4Nruk9XQV2mLhPbmuTBz0VwTO+uCU3jeFjAWqUhLxpsR1 D3RRGBhUYZxP8PBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740757764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X30CzGKpErV/mbzwMYQ0nUzc2buSuGpj1sVMr9Ac3sM=; b=mp65QVT/+RW6cASixZ6Jc6/CfrYVjBZP6gFNe98pIHBwMjiW0zW1lkEWBxYHK3Z6QTZgI6 2tWuCGU2dFAzc/twRPgVgL5xH0fglFFcHMuj7U+A/WNykeRMlQP/aszId5ba7joEXSY7IF NO8zOWV9as7kKWteRgt/nJRU8VsoP/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740757764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X30CzGKpErV/mbzwMYQ0nUzc2buSuGpj1sVMr9Ac3sM=; b=PwZooPW7rytxRpZ7sXkWufegZ4Nruk9XQV2mLhPbmuTBz0VwTO+uCU3jeFjAWqUhLxpsR1 D3RRGBhUYZxP8PBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5B6031344A; Fri, 28 Feb 2025 15:49:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pLwAFgTbwWdZUgAAD6G6ig (envelope-from ); Fri, 28 Feb 2025 15:49:24 +0000 Message-ID: Date: Fri, 28 Feb 2025 16:49:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] kunit, slub: Add test_kfree_rcu_wq_destroy use case Content-Language: en-US To: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton Cc: RCU , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Oleksiy Avramchenko , Keith Busch References: <20250228121356.336871-1-urezki@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250228121356.336871-1-urezki@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Stat-Signature: jpw7h9h4q9gug4ssrrnbnbnf1q8cqi17 X-Rspamd-Queue-Id: 3739D1C0013 X-Rspam-User: X-HE-Tag: 1740757765-257242 X-HE-Meta: U2FsdGVkX19WgEbHn+T5afQlJLC5uAddp3Ay8xRYicmAIr/LiO3+7Pwfo6gJbDI98KL6GOMdBb8fk4rswDesIx1luiAsO1QEz7k6rOQD41derAc2VBAhYkoNKgUBOD16igvAQcgx3jYgAk/Ndn0TDeWNtdZVkPwrOqBhk0IA44vQZNazAc/SmVjs0My2mj3Q/HRVVVmb56JbYWD3PmVFBpY/GtmoMWRCPKVGCYFefi4rZsZXsf1Ed6d+x0oV/0SJQtMAxl7QXGMDBqNLW/MhwHYW5vP0uzQAlyhQFUZJPoGz24fHvv+DgW/VxXtowPhvoyiUhPwsp5LSWjqF3xbE+U1CfkCf/Z1KRl8HhVxeHKrulEPShEU7DO7w3vlmvcqMFTMawRRv+xJdUbNSq7PiOkKkrXuC32oq+KYoAPboo67uv2nkMnf1EykSmbsO1/48kwUAjelV2tvbzClsaNF7bfIef0U/dqNMNDPuQNsQdO2KX3sO9+iQqnYi3eFpxMauGfl113tpHbF+smEr3WbwLR3BxQVMEdYNXJaG9ANkpcHb7N1SjSkOJZX3s5CRDK7gXvTssltwgRaLXKjSoR5RrGYMIG9WUapxG9/tru49AMDZHtO4IJ9G1ohgThk1FuIIOb1CfI6mLTiXTLngDu0Tnja0y5TdfL3aMX11n6UsHcwZzRXAxqdgT0ACJB/DbPwMxuvTDOMtIbJRux5MZdWPGuyueFuUR+iYIf4Q0XAAaSWDvzJG4UMJu/nZZfUnlLJ7OOF37UpWTcbIHD2H3qWx3LPozTaRUTQAH3FuUFZ/YKTqmULC4UuJP72t8uOuEHzqgz7JGN3PjOOVj6lk6fChncVfd/QC0GW0EhTWy34rcdtZCVIz0U0zUHQx8IhISX/AhRdDQuIirbDgEH2XIYWHv8vUqciXyNSvkTYJA0SoFPbkDCmc49aYxQ/Gyof/CBe+ZOuaRr78iiSIZgRMqmn jjrDXq6G /MxFfpuYQJkroho8tlpS7XquRrSaZyx0JC/arGkpYiPdmp8fmN21tHox1h+JdSwpEkROEKysJRMqeROyJ+uFlZTYVfDTztYIwIYMe0ORzittWpO0NTJrddJoVW6ob7bcSaswdoJ/FCXxP+zXDWk5G71MqH5w8qwVJb4Xl8H4MKfinCv/rDMcPWHk7Ed8u4W0+7p46HU7uGY5gKg7QvmUwlqfVrETVK5VaOttXbprvwcN7av1U1d3mAFB9Kegi8hxDnbOtBBFkl+/3LTajg8VertV0i9tcRE8Y9FTnLV2ISeP6CtgDjer6Ge9MW5M67sLoDTJR8MBp6QThPiL6kpLnOdm4GYXnmcYfUXtpuw5CPj6EEzpEN4lc5GtPvsHxz80KU8lND22TZJdkXqlVrrWzU1S16yRGkzBNgJtEisLXCjJ318fXo5ga2EzjX0oMucCsoSGwB9YnoGYq+k4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/28/25 13:13, Uladzislau Rezki (Sony) wrote: > Add a test_kfree_rcu_wq_destroy test to verify a kmem_cache_destroy() > from a workqueue context. The problem is that, before destroying any > cache the kvfree_rcu_barrier() is invoked to guarantee that in-flight > freed objects are flushed. > > The _barrier() function queues and flushes its own internal workers > which might conflict with a workqueue type a kmem-cache gets destroyed > from. > > One example is when a WQ_MEM_RECLAIM workqueue is flushing !WQ_MEM_RECLAIM > events which leads to a kernel splat. See the check_flush_dependency() in > the workqueue.c file. > > If this test does not emits any kernel warning, it is passed. Well the workqueue warning doesn't seem to make the test fail. But someone will notice the warning, so that should be enough. We can't instrument warnings in other subsystem's code for slub kunit context anyway. It would have to be a generic kunit's hook for all warns. > Reviewed-by: Keith Busch > Co-developed-by: Vlastimil Babka > Signed-off-by: Uladzislau Rezki (Sony) Pushed to slab/for-next, thanks.