From: David Hildenbrand <david@redhat.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Omar Sandoval <osandov@osandov.com>, Hao Ge <gehao@kylinos.cn>,
Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org,
"Vishal Moola (Oracle)" <vishal.moola@gmail.com>,
linux-mm@kvack.org, linux-debuggers@vger.kernel.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: Re: [PATCH v2] mm: convert page type macros to enum
Date: Thu, 6 Jun 2024 20:42:28 +0200 [thread overview]
Message-ID: <b96b3d41-cf6d-4c5e-bf42-01fa168510a5@redhat.com> (raw)
In-Reply-To: <20240606182630.851750-1-stephen.s.brennan@oracle.com>
On 06.06.24 20:26, Stephen Brennan wrote:
> Changing PG_slab from a page flag to a page type in commit 46df8e73a4a3
> ("mm: free up PG_slab") in has the unintended consequence of removing
> the PG_slab constant from kernel debuginfo. The commit does add the
> value to the vmcoreinfo note, which allows debuggers to find the value
> without hardcoding it. However it's most flexible to continue
> representing the constant with an enum. To that end, convert the page
> type fields into an enum. Debuggers will now be able to detect that
> PG_slab's type has changed from enum pageflags to enum page_type.
>
> Fixes: 46df8e73a4a3 ("mm: free up PG_slab")
>
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
> ---
> v1 -> v2: include PAGE_TYPE_BASE and PAGE_MAPCOUNT_RESERVE
This has a conflict with mm/mm-unstable.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-06 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 18:26 Stephen Brennan
2024-06-06 18:42 ` David Hildenbrand [this message]
2024-06-07 0:06 ` Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96b3d41-cf6d-4c5e-bf42-01fa168510a5@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gehao@kylinos.cn \
--cc=linux-debuggers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=stephen.s.brennan@oracle.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox