From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BFCC83F2F for ; Thu, 29 Aug 2024 15:20:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B4836B007B; Thu, 29 Aug 2024 11:20:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 963406B0083; Thu, 29 Aug 2024 11:20:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B5B86B0085; Thu, 29 Aug 2024 11:20:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 57C0B6B007B for ; Thu, 29 Aug 2024 11:20:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 17BF4A8DA7 for ; Thu, 29 Aug 2024 15:20:40 +0000 (UTC) X-FDA: 82505645040.05.38DDE31 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B2E554002A for ; Thu, 29 Aug 2024 15:20:37 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhZ1ykLr; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724944792; a=rsa-sha256; cv=none; b=jeiqzfb8inXsCwAXQQ6kxfN40C6BoyUDAvPQ1SNIuaSBOp8DHEg3pYrlDG89lvc6pxPFqO y/vG2OZekishcHeApF4uczgJ0Wmtyy1lBPZkwaMqh+E5a+V1Rt9YnjaySzqS+W3Yzfa/6w TDiQo2zv52iupeZ/ut+I5GacPUTzqd8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AhZ1ykLr; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724944792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKd4+NNigxkA+l9Vpyda4flNmEYvHUbCC9r/4wRTavA=; b=lrWNnv/WRiP3ju0KaolcJtXpErux5jeeMRos8u4kxfsgxmqFj5p9mdvKwqzki1beSoVznB 46oRpL5KpY4D3VF2eVpfzvp5vdJVyxdw17SYC/hSO4wEErUYkSnX3KzR0Jsr+ME5G1lVEu IdDbh1Ykh2LmjLDhfP5q8XGiZ+nSpKQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724944837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NKd4+NNigxkA+l9Vpyda4flNmEYvHUbCC9r/4wRTavA=; b=AhZ1ykLrtEln4ztE6w0xjeo1kAO6Ow1EnjIPl9PhgJMgGV3+bNzFOtGkXCk+kfSxLpqXjJ fsPNLBfLNGvZxndK8CJbTE/p5UyfjVn0/GMzjf9y7o+usI7Qeaf2iFIpXor/Ev0cX9GHxi FBbnyQ1ZzGuZYYsGGvY0BgZbVG2elCo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-YnST0p3jN5WD6QbLylhEEQ-1; Thu, 29 Aug 2024 11:20:08 -0400 X-MC-Unique: YnST0p3jN5WD6QbLylhEEQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37187b43662so560537f8f.0 for ; Thu, 29 Aug 2024 08:19:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724944798; x=1725549598; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NKd4+NNigxkA+l9Vpyda4flNmEYvHUbCC9r/4wRTavA=; b=cjMBgWfT0/aXxLIRBtkIYM4yObkwl3mFAmSDTNgFcnNKRghuh09MKCRyd5xo5Zh7x/ WuhzXGCgiyonr3B/YLTfSS+Wz9kBaMRSVCLzvH0XS0dwTKEhazNWrYX0iMlrpJyAx9Wi H+CveMRLs8CqpE0F7Wnk7hsqz3Un3ztTmFW/PHck45SepEz0Jx3a6lid1en7Uo6yiie/ V8LeeJiNtIkuYX00e9JUP3jU3tWrL5ty6bzsa/4E9UApMi+N9VSKoSSUlja8w1LSOa5u QmIeAv6VIRiOuAYhA/C/lCLgYTAHq91pbghUT3QeEmJIMS8HGwOzQW1RvQA0AaTtFsx2 gBJQ== X-Forwarded-Encrypted: i=1; AJvYcCV6lD3rovVsZ2AfmW6ZUF9jluC/iwRR58dqVeE2zfqxkljBqdUR3GThKR2ksYWaz5p5/noFBQD11Q==@kvack.org X-Gm-Message-State: AOJu0YweyKqFWsZraqs+7k3Iabu3eMjHj+3M8YcJLLDhQVGFLTBYaTtV HsaBI6Q4VsxLaMAv8agTWAe0c5MsxHCguvqIdE/pzuoSrJc1PNz+Jz8m4l/I2PENR83GuTUWFLu azCRNUARw6XcYMzWq7y+SJSEl56V/BKG039/mRPi7Xyr9AS5xkEDoR0wDlO0= X-Received: by 2002:adf:fc88:0:b0:371:88f2:93e7 with SMTP id ffacd0b85a97d-3749b544847mr2162131f8f.18.1724944797947; Thu, 29 Aug 2024 08:19:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECmr62xyiEKa3G1ybA5zzcGwz6+fAlJbaVfGfzperEYht192bCEHUK/Bpx9vvk41xJWnc1Yw== X-Received: by 2002:adf:fc88:0:b0:371:88f2:93e7 with SMTP id ffacd0b85a97d-3749b544847mr2162112f8f.18.1724944797134; Thu, 29 Aug 2024 08:19:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:c600:c1d6:7158:f946:f083? (p200300cbc711c600c1d67158f946f083.dip0.t-ipconnect.de. [2003:cb:c711:c600:c1d6:7158:f946:f083]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee4ad73sm1668814f8f.19.2024.08.29.08.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 08:19:56 -0700 (PDT) Message-ID: Date: Thu, 29 Aug 2024 17:19:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5-fix/5] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation fix To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240827114728.3212578-6-wangkefeng.wang@huawei.com> <20240829150500.2599549-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240829150500.2599549-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xxiyp9dfeu88e97ozouzpd1ir51wz5uf X-Rspamd-Queue-Id: B2E554002A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724944837-970289 X-HE-Meta: U2FsdGVkX19ADrBLnrcXHVQOLcJ0JdJhrbH4h4ZH75z2aerUu6QI/3O7ptEYidIcr1TRxRR6i5+TuKBKwztWD+aMgDG3LDKPzdQM4uGrC5D9thLwA9DzpKqUMTm7RWgidn/7zb7O+KWfpU+DLAfPbovIAg6j1nknhRDKFaSQTUNC7imHxFgiRpiF+Oa35FB7Nhs5NIwA4BJD5DXK/G9KzxMOLFr/WL+ZyM1vgDwEEEsREITHyHGJtqKBUl9h2vgVnULGFuYMLoJ+ANslmpyvwm12KnxWZ8h9hKv2AdboGYuWG0kxRDEJsgRolfsLoO6zA4EAQcaRYnuXRBZMOxap2w1DVHXOr813a6fUpBfsx9E1QytINspeCPk02skm0LSzjldiPW7ArvHHodnWGlHzH4BMWrfJBxtgQe0zHn4FUOCw2aHGwFnylktQg2nv9GsA4jA3GzPfScK4aSGbFlS9Sv91qECeB2kadkvSlZY5bCa/czu8WbJMr806rExH+co1KLPdMeNqJZ2qiQ6zZecTx9PayUnZxfl8wnSXJ95ZnMiNv+2+RFAhFcbsipmlDnYR58vH6JfFQAF1goAe1jive1GbHtinbScajleu+yQ3IdZ1P8yHdsXNG16hGNFDzHXLFKsfcTu78Q29zt2TnwscLAMXYUKbAIebJ2QfY6wXDPlT31AGN3HNIo8QN5ctVXsYwFChFWxvWh0N+lU6bMMM9LDUt+NX3T1xLc0v7kDFERxhDARZB2X5U9QoWbYZqvvn7rHbYT0tIOy53ARI2HFTifzRsLJ1CDsaSzaedWYqAQ/ETDg3ZBsPfy9apVsyl3iyK2uWuNJc5yfjFBGgovIGIB5AAkxj6UMr1eWjV9YyPXrNYjEKGRFJjiaYaw5E273OHtO5DKL7wy3QiQo8gVTKYO+V/Q9HyAn1HX4SZDjghu/HouyPhS1Xn8ZY5ZzfMniCuE1vk7socF2n7T83lzu /n0sVC2N F2uBaaovrzcTM4TquCw74G2Id2CpxMtSY6ZkwkbJNZS+Gp038kA9aCQ9rkhJTZrdmDzonKvDYuEyyLGtxus6LCotM0pFHAfvJ6UQpXXvnrcFTmMs4AImIw3KFJuAb6SwxVT9hhuf/b8GZvelCztlFzNQD9xjUV8AwsLon+/WbUSy0E1WpNoYmJ55r1jrgo8xcmk+g0I/IGeeDFfzRZuEZ33s3sikzBLabQ+FVuQ1KoGvYe5aY2U6u3qHwOAImaDl0OlxG9p/liHhRl8Q9o7/S34477eriKdwezHpgPdSKbeSMB2KHWdDfRME9QdsGjgc/z0IHO8UA+4vuxHVi3Biizj8ObKuxvh/tSeh7LgBzL3/VKaJ1vmkXLOg4fKzqHeQiGOi6rL/ERSnKdTxauQiI/TVvWyTb/By3QTsK4WU/REUJUJ0a2BkgpywEAPVUyogKZ23XN5Vt7fd4Nd+cck5GzC35rPzrZU8PuRVniDjoaeGfdQI4BEC3IEv3KiMBKj0VS4Ebebc9XznND/K63F7wK8Ep6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.08.24 17:05, Kefeng Wang wrote: > - Use folio_try_get()/folio_put() unconditionally, per David > - print current pfn when isolate_folio_to_list fails. > - memory hotremove test passed for free/used hugetlb folio > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5f09866d17cf..621ae1015106 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1780,7 +1780,6 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > for (pfn = start_pfn; pfn < end_pfn; pfn++) { > struct page *page; > - bool hugetlb; > > if (!pfn_valid(pfn)) > continue; > @@ -1811,22 +1810,21 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > continue; > } > > - hugetlb = folio_test_hugetlb(folio); > - if (!hugetlb) { > - folio = folio_get_nontail_page(page); > - if (!folio) > - continue; > - } > + if (!folio_try_get(folio)) > + continue; > + > + if (unlikely(page_folio(page) != folio)) > + goto put_folio; > > if (!isolate_folio_to_list(folio, &source)) { > if (__ratelimit(&migrate_rs)) { > - pr_warn("failed to isolate pfn %lx\n", pfn); > + pr_warn("failed to isolate pfn %lx\n", > + page_to_pfn(page)); > dump_page(page, "isolation failed"); > } > } > - > - if (!hugetlb) > - folio_put(folio); > +put_folio: > + folio_put(folio); > } > if (!list_empty(&source)) { > nodemask_t nmask = node_states[N_MEMORY]; LGTM, isolate_hugetlb() would not handle free hugetlb folios either, because of the folio_try_get(). -- Cheers, David / dhildenb