From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA6D7C636CC for ; Wed, 8 Feb 2023 16:07:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384BB6B0074; Wed, 8 Feb 2023 11:07:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 334656B0075; Wed, 8 Feb 2023 11:07:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FBF26B0078; Wed, 8 Feb 2023 11:07:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B5CB6B0074 for ; Wed, 8 Feb 2023 11:07:17 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CEAC71A0E37 for ; Wed, 8 Feb 2023 16:07:16 +0000 (UTC) X-FDA: 80444604072.20.5AD8010 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id 22E264000D for ; Wed, 8 Feb 2023 16:07:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2xDsVBpL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sMxJUWpX; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675872433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3nHphhFdiAEYAVwsvl8jLLgqi2hdj2F6tFyWe+9CmgU=; b=h95NxBmgWReoWEiSWk5cSBjcrmCAoU7Ok8oFuf9XTGUjlYkZsNWg2Wrc1v0BM+0t/Fm9yK j0Z0Mo8/51jVwQCqTZZlw8JOXGTQZJz+2ellzE6zAnIO+e+R04RgrEyBaRKs0inIYtfIhc HNLDaJ4O5DuzSvSY7HQ3wpyKuPR9x9w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2xDsVBpL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sMxJUWpX; dmarc=none; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675872433; a=rsa-sha256; cv=none; b=mGQWi44x5uUxCYw8xk8Xw7Zi1l4XXNjJM9lZ8VI69EuOBAFsgwbhOgVzBarsBpTo1w9PwN GV3gVdecGswQ3r9sNGKkZt/lZskJ7pPldRx/tPP5diqkXMjVauIzDKddzCo3sXO1Dms77F i61vmepmT3F/SPBpz8CeIl1z4i/uE4g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C74181F8B4; Wed, 8 Feb 2023 16:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675872431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3nHphhFdiAEYAVwsvl8jLLgqi2hdj2F6tFyWe+9CmgU=; b=2xDsVBpLDExOGYrQZdLlxIxP0+Tcr8uReuPjEfpdDQPqXtKbhgatsIDnqZ9dwQBzLHfSH4 SaYeZ6trUO4uCwHXlbmoSYiLPGSzZAWLvtjzPbMj5OrdmTDAm0zENOih7PIfIBsWWhSVod BkBLweFA4ysGnd1vLs+1D6xmcQg4v+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675872431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3nHphhFdiAEYAVwsvl8jLLgqi2hdj2F6tFyWe+9CmgU=; b=sMxJUWpXW7eR5tYrqEHXOt20Ututw1n62Ydsoj03RNbE9JEnO33wS1Au296APxVtkd82LF 0RRIQGR9S10K61DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A2BC41358A; Wed, 8 Feb 2023 16:07:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1jkgJ6/I42MhUQAAMHmgww (envelope-from ); Wed, 08 Feb 2023 16:07:11 +0000 Message-ID: Date: Wed, 8 Feb 2023 17:07:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm/page_alloc: reduce fallbacks to (MIGRATE_PCPTYPES - 1) Content-Language: en-US To: Andrew Morton , Yajun Deng Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Mel Gorman , David Hildenbrand , Mike Rapoport , Oscar Salvador References: <20230203100132.1627787-1-yajun.deng@linux.dev> <20230203142324.e5c0652990676ac69a4e5eb1@linux-foundation.org> From: Vlastimil Babka In-Reply-To: <20230203142324.e5c0652990676ac69a4e5eb1@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 22E264000D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: pkx7kznzxcfw5gz894naiytnhxne1dd4 X-HE-Tag: 1675872432-162431 X-HE-Meta: U2FsdGVkX1/fteVenLHaWiax1Gt6G1U5MUwry+pVzJfQbaJYorMk2C0s45oJj9S6fnOujxlAx5e9T5eB2LMCAVRyfZRiS8GG9Ke6q2+mQZe54JO+QLrnL2suNUKepzBhNJ9Ltdseb4U2cyuBa/k6K+yiBWKGcUwgE38EHE3jtxXBY5V60r29PguFNU1WWkit31DyPExJttF+9oFeAQm3WtGSa2wTv8hoDGcst0Su+EsKHMWyXEj6b6ThEd+JvHq0dWeZgFvb4mOLdeL2UoFgUQ046EzT3fGe8qTFSIkxdzj9LS2afMuP11WQeiwngdPL0QGSaI4nDV4yfZ3gmbOhQ/6tQfOZfhPBdksdgJAfeGbIOB0DTWnMdovMTLCGTOQVSpCe3TljRbvkYj5GelUe0wXGSuss1G313hNFK6hX4G/YVlCsZcXiBHJj0j/rAmXEA5ttReuV7HrBHFNhEwlPIhWg3E77R0TKsLK64UjAVrzhObRmlISu09lIuD+9tPthC7+Mg+Cwmam7T4S+itbDHoxo0Qw/A5cwlpoMOvJEPMhqiM0rvesQgCjFASrmFuNf8URJT4zQt3w0k/Bl0FQ/tFTEKXRpLoq85CaUzwkuz/x5clcHZSMS5C0Wjt06zuej3i5uX8vKuDCsT9s1SYyEH0jia0IWsKtVxcnon0z7pfEdHkK1d7LWegSp02qT+cNg8wev8baK9sB4XOIMrKYNdqx0qmO/Oyg8d7MlrqyOM+LpgoRDYkNn+xd/z7hQOWm/ckSgwVqiChHVVm151pCYgv9Xe4VEdnj+/vMyXU6dDLg9FaCuKbto5HyGkTIe9+AEL0YAvU3ghB0LmfCZm6eTVBWWN6/clAX5unK3uRW4n1ed1VqG8Hbecs65fA3DV1jSW5eiW0wdeim3180hY4oQvFsBziEDnO7fG6kdwf1VYWhWtfW/F2yoylBneaFUTkainlCTw1oPeC3UwwhVL8+ E9IqU7Ku 6TUCt8QR7ZvBGgj+pOIYZXsEvupetybFi/WaPVLtqzRLaJ6FWeUnwd8c0pDwhYSF5x4U1nSnwVaFyqNz3lE7wqzwMLtK5euJP/WvQfOvxw8jJKkIFyW0CA/jSHDf4N8T4naJ3rXP+hyAt0hP5T5hfORK+X9LIkNa4vWvPw6kq8NaAgeeS+9DSQhI0Bs2L+AZjmpmtD7s7KR3D+3OrXMEGWvA7czxGyDyamJwFm7LEHlCgKPQ1yoZpI2BbNpU/WUWT6Fwu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/23 23:23, Andrew Morton wrote: > On Fri, 3 Feb 2023 18:01:32 +0800 Yajun Deng wrote: > >> The commit 1dd214b8f21c ("mm: page_alloc: avoid merging non-fallbackable >> pageblocks with others") has removed MIGRATE_CMA and MIGRATE_ISOLATE from >> fallbacks list. so there is no need to add an element at the end of every >> type. >> >> Reduce fallbacks to (MIGRATE_PCPTYPES - 1). Acked-by: Vlastimil Babka > Thanks. `git log' suggests who should be cc'ed when fixing things... > >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -2603,10 +2603,10 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, >> * >> * The other migratetypes do not have fallbacks. >> */ >> -static int fallbacks[MIGRATE_TYPES][3] = { >> - [MIGRATE_UNMOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE, MIGRATE_TYPES }, >> - [MIGRATE_MOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE, MIGRATE_TYPES }, >> - [MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE, MIGRATE_TYPES }, >> +static int fallbacks[MIGRATE_TYPES][MIGRATE_PCPTYPES - 1] = { Why not also reduce the first index size from [MIGRATE_TYPES] to [MIGRATE_PCPTYPES] ? >> + [MIGRATE_UNMOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE }, >> + [MIGRATE_MOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE }, >> + [MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE }, >> }; >> >> #ifdef CONFIG_CMA >> @@ -2865,11 +2865,8 @@ int find_suitable_fallback(struct free_area *area, unsigned int order, >> return -1; >> >> *can_steal = false; >> - for (i = 0;; i++) { >> + for (i = 0; i < MIGRATE_PCPTYPES - 1 ; i++) { >> fallback_mt = fallbacks[migratetype][i]; >> - if (fallback_mt == MIGRATE_TYPES) >> - break; >> - >> if (free_area_empty(area, fallback_mt)) >> continue; >> >> -- >> 2.25.1