RE: [PATCH v20 00/15] EDAC: Scrub: introduce generic EDAC RAS control feature driver + CXL/ACPI-RAS2 drivers

[Shiju Jose <shiju.jose@huawei.com>]

>-----Original Message-----
>From: Daniel Ferguson <danielf@os.amperecomputing.com>
>Sent: 06 March 2025 18:18
>To: Shiju Jose <shiju.jose@huawei.com>; linux-edac@vger.kernel.org; linux-
>cxl@vger.kernel.org; linux-acpi@vger.kernel.org; linux-mm@kvack.org; linux-
>kernel@vger.kernel.org
>Cc: linux-doc@vger.kernel.org; bp@alien8.de; tony.luck@intel.com;
>rafael@kernel.org; lenb@kernel.org; mchehab@kernel.org;
>dan.j.williams@intel.com; dave@stgolabs.net; Jonathan Cameron
><jonathan.cameron@huawei.com>; dave.jiang@intel.com;
>alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com;
>david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com;
>Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com;
>Jon.Grimm@amd.com; dave.hansen@linux.intel.com;
>naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com;
>somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com;
>duenwen@google.com; gthelen@google.com;
>wschwartz@amperecomputing.com; dferguson@amperecomputing.com;
>wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei
><tanxiaofei@huawei.com>; Zengtao (B) <prime.zeng@hisilicon.com>; Roberto
>Sassu <roberto.sassu@huawei.com>; kangkang.shen@futurewei.com;
>wanghuiqiang <wanghuiqiang@huawei.com>; Linuxarm
><linuxarm@huawei.com>
>Subject: Re: [PATCH v20 00/15] EDAC: Scrub: introduce generic EDAC RAS
>control feature driver + CXL/ACPI-RAS2 drivers
>
>>  +--------------+-----------+-----------+-----------+-----------+
>>  |              |           |           |           |           |
>>  | Setting      | Supported | Supported | No        | No        |
>>  | scrub rate   |           |           |           |           |
>>  |              |           |           |           |           |
>>  +--------------+-----------+-----------+-----------+-----------+
>>  |              |           |           |           |           |
>>  | Unit for     | Not       | in hours  | No        | No        |
>>  | scrub rate   | Defined   |           |           |           |
>>  |              |           |           |           |           |
>
>It is our opinion that the Unit for scrub rate should be unit agnostic
>(implementation defined), and definitely not specified in Hours. We believe that
>the spirit of the RAS2 scrub rate was intended to be implementation defined.
>
>It takes our hardware less than a few seconds to scrub a ton of memory.
Hi Daniel, 

The table illustrates the unit for the scrub rate of the ACPI RAS2 scrub feature as "Not Defined" according to the ACPI 6.5 specification, and for the CXL scrub feature, it is defined as "in hours" according to the CXL spec rev 3.2.

Currently, the RAS2 driver converts the scrub rate set in seconds via the EDAC scrub sysfs to hours and passes it to the firmware in the  field: Configure Scrub Parameters (INPUT) - Bits [15:8]: Requested scrub rate of Table 5.87: Parameter Block Structure for PATROL_SCRUB.

Did you mean that the RAS2 driver needs to pass the scrub rate in seconds to the firmware?  then I think the max scrub rate supported is limited to 256 seconds?

Thanks,
Shiju