From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFA5C49EA1 for ; Tue, 30 Jul 2024 10:31:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDE136B008C; Tue, 30 Jul 2024 06:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8E406B0092; Tue, 30 Jul 2024 06:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2EF26B0093; Tue, 30 Jul 2024 06:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B50666B008C for ; Tue, 30 Jul 2024 06:31:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 37C73160208 for ; Tue, 30 Jul 2024 10:31:56 +0000 (UTC) X-FDA: 82396053432.23.05DDC85 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id F322C120006 for ; Tue, 30 Jul 2024 10:31:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WNA70EIU; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722335459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ci0iG1lAcu2p9+9CLXyArY1oHRh4kJ5aB+Pxmrq8+tY=; b=bsDFfixsaBQYICE9SPIDQbEtfeaLyy9ofNJwFJHbVNvbk+jiDG5df8GYd3AGy7j1d35PY3 6jNav7Wj64jdkgppj+iLkXzG3z1+lKS6R+ZxAsgtG8k+GfCRynNQNsgCs6xxQthDtkhnAJ Ju8JF9JBM+sAAu75sfBSefSuuETQlHw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722335459; a=rsa-sha256; cv=none; b=TmcKbQmTTEnh8H6owIzbqgCdWtqRqQqZKStoTJTaW1fsYMe8/6H4tvVOZY5oWdMqsOAmkQ ve6EO0cMbZCBuOYqpvhtxw74L9E0evLcYx4VyJ0W3P+lLXSXJLztljvO2r/m/zKZgH4pJl pWryfMR1/0IVBYxHLYEO9RSFwbay+mE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WNA70EIU; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722335513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ci0iG1lAcu2p9+9CLXyArY1oHRh4kJ5aB+Pxmrq8+tY=; b=WNA70EIU+wD3/HdRuuxPrZZVJjAFoQqc9RdJB9He5PTioVijLwuiqQcU1yKv50ojT2DmQG Crk0/mvL7jhC/ro+1GQQ3T3rbd1DJViC1LpqpQx8xeCcN2c/GTpdLegnUc87cbwOQjQ4cf YQAxBBk6beIA/bVItS0Qy61tAOHuxRY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-eICW7TjMNEeJ4dZHLzDjcg-1; Tue, 30 Jul 2024 06:31:51 -0400 X-MC-Unique: eICW7TjMNEeJ4dZHLzDjcg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4280645e3e0so24385705e9.1 for ; Tue, 30 Jul 2024 03:31:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722335510; x=1722940310; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ci0iG1lAcu2p9+9CLXyArY1oHRh4kJ5aB+Pxmrq8+tY=; b=E2QVlC5ict/ew7/Fcar3gNhk97uD0KsjpQrsn8TXb9AwxU29ZVRIUhvHEHhgZVkBr4 MZ//6NBWJTc9ZVk9L2qy+6/bDRo80nrXCkmzclJ1PVD5ae9JBc1MO/ulIz1KRKk7OvSx W81YPvIEbd77TIl+y/dNmXFRbDQsjLRYtAuuijkEcdA1QTWMQC4oyC5lWXTJqVr3tgha nYGKSEH5plxx/QkK1y+c4d/Afb/vJ6iDsgX0yZ+wcOctADCH131tB+n4NBIdligYKIHC Vwgk/066IVHtaOhPwqaDfoOjlkLl+R2IytOPtc+1sJbu3LZHkWKmTpEoXx3XDPwpw8sk 80Jw== X-Forwarded-Encrypted: i=1; AJvYcCWF2T8vEF9wNoacAFdC/gPjVvWFBCRL9focGttgiqNhoMo6w39LgzztQI6Kmh4urrr4sStvUrJBZN5mKKq1TN1Op3I= X-Gm-Message-State: AOJu0YzZPuFS1FDO+O9WUsp+tMqFoeiAdHtCWlojmc7q6S+3luzkTCdl H9j8F0/8rjNbAgYy4LXdRiYLG2bSHr7N4oG/8Ilhz5TIp/XyXkfo/evmA/DUs6DVXFyuoOXjruM BnTFe6nTsg7gn6Im1ua6vwamFmxiQunr2yhbmExIcnHCcPO1y X-Received: by 2002:a05:600c:4f0c:b0:426:629f:154e with SMTP id 5b1f17b1804b1-42811dd10d7mr61496425e9.30.1722335510379; Tue, 30 Jul 2024 03:31:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNzizWY98lU9wfvsT4pqCV3MiP2Pw3v+gC5jUqsqpGhfWDrsBYW7L4vlA8+sXZOhRhePavEQ== X-Received: by 2002:a05:600c:4f0c:b0:426:629f:154e with SMTP id 5b1f17b1804b1-42811dd10d7mr61496245e9.30.1722335509925; Tue, 30 Jul 2024 03:31:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:4e00:31ad:5274:e21c:b59? (p200300cbc7064e0031ad5274e21c0b59.dip0.t-ipconnect.de. [2003:cb:c706:4e00:31ad:5274:e21c:b59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4281e3a93d2sm58947615e9.31.2024.07.30.03.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 03:31:49 -0700 (PDT) Message-ID: Date: Tue, 30 Jul 2024 12:31:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-5-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240725011647.1306045-5-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F322C120006 X-Stat-Signature: 35oski1hdzsqbm7mry3ceopr4khhajxt X-HE-Tag: 1722335513-874849 X-HE-Meta: U2FsdGVkX1+OsHAwfsQRXS8HA6MdKEbKnGBMH79FCKyzsLrsqC0XIqk962PQ5/xluKv928fCFeQDRlDA1aeNEfcCtVKvY+yINLhcNlCv34iQDYc+fBNiA+uQRNBmjqG28damsaEsvJEAhQuTlYMBK/xIcYBnblViU/qEunUjHd+BLmxK21+vN1CMajbB4bYlBPcU1b+3rJ34s393GeEumLtEfii1SIq13DGOc5I4NbvKSg/BNUR+mTyKZUwospMI2sVjl0N5ybYFgHs4/FOZM85JnAEXlP2K10C4f72co2/kWCuScort9FQR7LreMQU7tJkMWLC9s4yMTJgNfXe9fuqD9C/vS56R5AeUJ89BLzooADRzt2OIGMa3TX+lTO8DIB6XH8/fFSlcwIDYuwpWBslUJwsOB+2PnkPTs1a96lA8olafpcYUkZMjmt1gu5p82vg5uI6bmSSrmXnQtNjiLNYTbl4Ecpg9d4h0wygrj/edPrYgOjRpqZocNUa3w5PQtYPPcDatPeI/m1QBaGfIRsdfaO2sdtSEAJJRXzeli2aCuaAjbkOSvWrrtrugL4W1xfBMdM8rvSqnxpTdHrXYMYGvUZnEm//8o4qv/Qppd+tKuk5byIs+lpqu6uarx3NcYe64+0LFvpVswoaWqNpawCwwPqPq3LioBfK7TFCRRtQn0LD7PeeX1rXYMM6MoWlIwC/+FA3SZKBqeVZbs3VBSFHexL6u0KsHX8U8YBPt/E3fJFMlxXjdmVoAI8UTefHe8qWu1mgOEN2Uaav4aCmo34qq+kmoBONwaYU1qkSJlshTFIxhumSs8zyusEYvStUU3gABTz/X0CQFCnY1u70XN2Qh2h43Fac8z4NJi5apq2YqtAq9kjCMmbiot3phbqjUIHqYz88ypMsQrqmTbCVv5HE7hYQWqF6IfKgrqkM7otNrkGvK+43i0HMavhuc3ml+WPGUVpcujPad1gKkF25 qIr8Xn1p Wtp90VO+lT50hySC9Sqiw73cJTl4KwDJaygmi8la19dUiwWjjGJ4JTgKdS04UYWAXx6RIXIFmEfFynjOACue5fsBanVKgCrn3pzmyZWZYbGRQ/mWfUOxrY4ySTp7SvolCdomqkqSHAq4PFL3yhciTERhS4CiG1/uxktWY00tbv1cNwwuS5NoDl6lS3NaxDjUl9duoakC8Sbc5L9UNwHWi2Nt+ILYt0O/OG++Gm3OaVMCrRb+L0Zyt3UJ3oTQMQpGcmu2xg1lXq4mSJf4aZE5TBLiw8ssHNgZHBFzRbRk216A5XCoj2Es1QljuYhW+qvEv1Lde2AMK1MMBMeo5cjfi6W+qhYCBM6rp1XoXOfoYOLmporO6vUxPpS3z6bxkhFXLh9YH3cpjhn78xJDquWqE7nUgty1sE/h0X7kXcLwrYgDICYqm+GSJ4IyHJAtJFHHEAhAhoAYlAfHSUNzWODtRLK9Ec1+gIULK53DuKmbDUq4dj1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.030002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.07.24 03:16, Kefeng Wang wrote: > Move isolate_hugetlb() after grab a reference, and use the > isolate_folio_to_list() to unify hugetlb/LRU/non-LRU folio > isolation, which cleanup code a bit and save a few calls to > compound_head(). Will this work with free hugetlb folios that have a refcount of 0 and get_page_unless_zero() would fail? -- Cheers, David / dhildenb