From: Dave Hansen <dave.hansen@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: alexander.h.duyck@intel.com, pavel.tatashin@microsoft.com,
mhocko@suse.com, akpm@linux-foundation.org, mingo@kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use
Date: Tue, 4 Sep 2018 12:27:48 -0700 [thread overview]
Message-ID: <b9344b71-3ae9-95c0-ccc2-ec3db37ccf9f@intel.com> (raw)
In-Reply-To: <20180904183345.4416.76515.stgit@localhost.localdomain>
On 09/04/2018 11:33 AM, Alexander Duyck wrote:
> +++ b/mm/page_alloc.c
> @@ -1231,7 +1231,7 @@ void __meminit reserve_bootmem_region(phys_addr_t start, phys_addr_t end)
> /* Avoid false-positive PageTail() */
> INIT_LIST_HEAD(&page->lru);
>
> - SetPageReserved(page);
> + __SetPageReserved(page);
> }
> }
> }
> @@ -5518,7 +5518,7 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
> page = pfn_to_page(pfn);
> __init_single_page(page, pfn, zone, nid);
> if (context == MEMMAP_HOTPLUG)
> - SetPageReserved(page);
> + __SetPageReserved(page);
Comments needed, please. SetPageReserved() is opaque enough by itself,
but having to discern between it and an __ variant is even less fun.
next prev parent reply other threads:[~2018-09-04 19:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 18:33 [PATCH 0/2] Address issues slowing memory init Alexander Duyck
2018-09-04 18:33 ` [PATCH 1/2] mm: Move page struct poisoning from CONFIG_DEBUG_VM to CONFIG_DEBUG_VM_PGFLAGS Alexander Duyck
2018-09-04 19:25 ` Dave Hansen
2018-09-04 19:54 ` Alexander Duyck
2018-09-04 20:07 ` Pasha Tatashin
2018-09-04 21:13 ` Alexander Duyck
2018-09-04 21:44 ` Pasha Tatashin
2018-09-05 6:10 ` Michal Hocko
2018-09-05 15:32 ` Alexander Duyck
2018-09-06 5:38 ` Michal Hocko
2018-09-04 18:33 ` [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use Alexander Duyck
2018-09-04 19:27 ` Dave Hansen [this message]
2018-09-05 6:24 ` Michal Hocko
2018-09-05 20:18 ` Alexander Duyck
2018-09-05 20:22 ` Pasha Tatashin
2018-09-05 20:35 ` Alexander Duyck
2018-09-06 5:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9344b71-3ae9-95c0-ccc2-ec3db37ccf9f@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pavel.tatashin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox