From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0070AC197A0 for ; Thu, 16 Nov 2023 23:10:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F297280013; Thu, 16 Nov 2023 18:10:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59BD9280011; Thu, 16 Nov 2023 18:10:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 415E8280013; Thu, 16 Nov 2023 18:10:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 331BF280011 for ; Thu, 16 Nov 2023 18:10:24 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 00DC91A0D72 for ; Thu, 16 Nov 2023 23:10:23 +0000 (UTC) X-FDA: 81465363168.30.C734F02 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A9A4140008 for ; Thu, 16 Nov 2023 23:10:21 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DfjLaTzv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700176221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MKeibb6KnKnaA+iE0iv1obj46zXM3TXwKHeMWH8DpE=; b=Qmv8kBv6jN6OdNb8WUTb307h12Yqpaq91hIsfdB3irOhjFVWrFVKTfVVpdjPl1z/fRZ/Ky Xe24BMyV0xokLQ8HYkiy/eZfpOgW4rGgzVe6UCmKja3XdoBc7US0g2GJLzm/xKsQCwMXPB c6svAzlf8TEy3++ZZ5LR0/HVO2/GqjM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DfjLaTzv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700176221; a=rsa-sha256; cv=none; b=BAV1TomQXQmJQ5WwP+qW7yLM6fzfifcHMKe21n1YMvcb57iU4KbQV/+WRMZsoy6nf2xo8Z ocpHZGE6jcUB5DXItPhnyr1VoCPTs7uXra+iAojfEKgow77VLKuRXex9dk/DAFhNUDxbZU 4GLZlAAPUPqjd83R/NVNwWjP3Sx0DLk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700176221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+MKeibb6KnKnaA+iE0iv1obj46zXM3TXwKHeMWH8DpE=; b=DfjLaTzv0NAA4jpq46ym4d7zMrpijcOBLT8tVeHok2ghgkdh2EDDKgw1qf1Xe77E7m6ZVG G7b6k5dCzp9Sp5+eVZD+NChEMGC1m5o1aR8WYQxKzsuEK2pNglzJT0pHvClyZbIfNRT4uz pbnEURPbgZIxxRWwBIZNicEaTHJsVRA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-gGNXbCCBOmWwonLsC6JWVQ-1; Thu, 16 Nov 2023 18:10:19 -0500 X-MC-Unique: gGNXbCCBOmWwonLsC6JWVQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4083a670d25so8844225e9.0 for ; Thu, 16 Nov 2023 15:10:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700176218; x=1700781018; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+MKeibb6KnKnaA+iE0iv1obj46zXM3TXwKHeMWH8DpE=; b=wuGU1vvREXGB2/wqaPjtVX1SqrPYHo51iqA3KNxALnPmui3dhDKqWeraf44UIq65Rf j7nJXs97EupCuP4XmdOE9ajSJLZVdOSyemVi3vSL9tZxQ6BrBhoUA7d9zu4l4p100TSN iHx2NKYXb7ntwcYgm4e8ho9j1DTNg+BNjt1E8aHh6QHmwfGoXRMqSfWj3WEC9rNZRo8z AEsmvUQN0LhYvVruzfw9Ejt916kPFaT/j2JsOOaEtVdXV52awYdckWx0IY5TF7E/8zmC q/ICnWDJxOuiKmI3YpyPNGDb9Ek244fOntWJEBtnSkX7Hw1x9kvDuw1NG5JjFQpQNeR9 Cp+w== X-Gm-Message-State: AOJu0YxEWQIMJjUKYlY2a1aHVPXp8X21PGXD4tzPx7WZoft/Hyi5On/G ltD8RWM0cGmD4zH9Bwn92RR256g05omFNIzUBrwG3qNcUa2E0r4hh95XSU4g+/fN1H6Gos9KQWS ZDp219AE38FE= X-Received: by 2002:a5d:64cd:0:b0:32d:8830:ee2 with SMTP id f13-20020a5d64cd000000b0032d88300ee2mr16315191wri.43.1700176218353; Thu, 16 Nov 2023 15:10:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQ5ev20kMVvuY/jGfQ6WXoGS09jmwNDwDquYUYfg5EhOSnq0pu0DG+aLWEXCkaL3A/isVylQ== X-Received: by 2002:a5d:64cd:0:b0:32d:8830:ee2 with SMTP id f13-20020a5d64cd000000b0032d88300ee2mr16315180wri.43.1700176217987; Thu, 16 Nov 2023 15:10:17 -0800 (PST) Received: from ?IPV6:2003:cb:c714:e000:d929:2324:97c7:112c? (p200300cbc714e000d929232497c7112c.dip0.t-ipconnect.de. [2003:cb:c714:e000:d929:2324:97c7:112c]) by smtp.gmail.com with ESMTPSA id d5-20020adfef85000000b0032fb46812c2sm573718wro.12.2023.11.16.15.10.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 15:10:17 -0800 (PST) Message-ID: Date: Fri, 17 Nov 2023 00:10:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/pagemap: Fix ioctl(PAGEMAP_SCAN) on vma check To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Muhammad Usama Anjum , Andrew Morton , Andrei Vagin , syzbot+e94c5aaf7890901ebf9b@syzkaller.appspotmail.com References: <20231116201547.536857-1-peterx@redhat.com> <20231116201547.536857-2-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231116201547.536857-2-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A9A4140008 X-Stat-Signature: uzjy3izjabeqd3o4r6x6hfww3geyp5x5 X-Rspam-User: X-HE-Tag: 1700176221-571408 X-HE-Meta: U2FsdGVkX196o76KGdfp1ryqpDlQusqxyk8TBAsHmxs/EJfHW5sv7z3UWtgbR8THwd09odFSCiBKprv/CAj8FYGANlZre4NLOY7vrevYQ13SXmwN3QSzNfxzzrLbDz3oJXqxbz/nRmOMDKOww5klGZD+jEplEexOV9NJEHFZt4uxFDXWdV0eglVXfcPwy1G0363c4clfvqCdnq1uVOVNImdrqS3I/YIM5BIS9wspP7orX+o83O27kV+7fwfYPB9E+cIm00EbQuIS9QarGbc7ZNq0CW64v3ZrkCmqsWtuhNuG5GEtUX1UYb8h8zgklX6NRX5MWPrG60KMtZcsQ19uiBisE7cmEBeDys5fTdyT2hKOIqoHy0OE9Vi7eRmSEGNsZWz8gFHpzgnRA+Wzj2WgKRwCCLo9aoPXhcSdZ+BYWYDGL1plzDi2TIXG5SnQPVCRvHpZWGd8o9i/HzR6XUDyPpBWtvdz0VLhgw0SFpEW/CYgkC1Ndvu6nVq4BHpjiTkwq9rx9MKXjZX2cwBUaBmHTGcnwfmQXSS+ukmN+WChQ7hJR+Ult2U4IaVmy6wTX0C43dUyqvwKCK+VJOwgiY7jih4i3IeSGJY8gzn+wOhPeubYXfvPHKqtEI9rWZ0wa1xrJ61Nudrm1y7Hz46BL9bmfyh/FgaB8xvKPEkpLEd0UDHP9ffWamC9g810AYBEEtKjgTichDH5qqDkBWz4iKl2QdYFQqQYnNMSpwsNHUoiZ4Ia9nwLHmpjWf58zSuPswITIXy/2LS8XRMw6YEZ190an0sv7uXZuDojJ+yQzllmGIjCwyP3d0EoDx54BYQd3Ggv0BXhSH5IjD+3k1L8ddSGwrQbYHLhc5NM+oDmvkAlrTt5qEmTuOzhwUPLtjZ2eo2a9+c/ZIsfMVTy+Sk+6JRU+0HcQ3PtfQ70p+qdPcKG5Vkcma4fLPu2gLv83kzchcm5Hbn5/H+P8tMlg5oBriu W+8F7bMN 1uSibil7IpFhX83Rx+A1Ar5upCFDzHQ+A04T60Wh93FfLRK634HQ1vJvIe6UBO5SZWVBlkBXZhc5TF3WSesqqWvKQ8B1rjYkppU2dJRlITw89uSlGaa4Y6ul8x5WLVaTPsvXnFB6o0KQT2zSgW4WakyMsuHQuRRqcDLSLSj5MacP68/5e4gR8VJ3zUrKgYnIe59SiRkIj6yhOdrbBN5/Qh4ld6Eyt8mSGLAcXETHTh2vbt5gb993JK5kF/MOsmvxQhk5ciDKJmsIFKplmnHEEzPCUANUDrM0Fi3eoFY773fKovYHnSN8gQy8FiOB7OPAxw8CXLBjvhGyhaOiSeL7TgUF+GSQTsQu7YMdRckDxqsREwJW27HS1fek+o4AoAGlfxXCQB2ZhS+shlW/tE4z3Wbe96lOAKo0X5Tm89gixIZB2aZL1ItRuwvc+RaMrCF8JwABh7NvAS7LzNG5ZNtTX5biz8Tn6ClysfPJ6pHo6oFnOXyWcHZys0HpFcO6nIF/L2QJ15Ed35C1etBukO6ElJS19QgpqJDF+6KBRTF63XA+zuSw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.11.23 21:15, Peter Xu wrote: > The new ioctl(PAGEMAP_SCAN) relies on vma wr-protect capability provided by > userfault, however in the vma test it didn't explicitly require the vma to > have wr-protect function enabled, even if PM_SCAN_WP_MATCHING flag is set. > > It means the pagemap code can now apply uffd-wp bit to a page in the vma > even if not registered to userfaultfd at all. > > Then in whatever way as long as the pte got written and page fault > resolved, we'll apply the write bit even if uffd-wp bit is set. We'll see > a pte that has both UFFD_WP and WRITE bit set. Anything later that looks > up the pte for uffd-wp bit will trigger the warning: > > WARNING: CPU: 1 PID: 5071 at arch/x86/include/asm/pgtable.h:403 pte_uffd_wp arch/x86/include/asm/pgtable.h:403 [inline] > > Fix it by doing proper check over the vma attributes when > PM_SCAN_WP_MATCHING is specified. > > Fixes: 52526ca7fdb9 ("fs/proc/task_mmu: implement IOCTL to get and optionally clear info about PTEs") > Reported-by: syzbot+e94c5aaf7890901ebf9b@syzkaller.appspotmail.com > Signed-off-by: Peter Xu > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb