From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59137C433EF for ; Wed, 2 Mar 2022 20:17:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B71438D0002; Wed, 2 Mar 2022 15:17:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B21938D0001; Wed, 2 Mar 2022 15:17:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C1618D0002; Wed, 2 Mar 2022 15:17:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 8C20D8D0001 for ; Wed, 2 Mar 2022 15:17:42 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 404B28249980 for ; Wed, 2 Mar 2022 20:17:42 +0000 (UTC) X-FDA: 79200556764.29.A40427F Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 930C3140009 for ; Wed, 2 Mar 2022 20:17:41 +0000 (UTC) Received: by mail-qt1-f182.google.com with SMTP id t28so2725570qtc.7 for ; Wed, 02 Mar 2022 12:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=hcnRInHyT7AqsJ1AJbefJWd13NGYBwYyXEFZcHJATbY=; b=j0T2nJV0lnpbMZflp0bT2kBk63Dknl3cqydm9aqeygJbgE3IkKBjdC82QQ8nkvKXbY NTvZqdF1iUMksdrNCokctJXUXPglExlbh8OwW8bnSqP+Z5+mqofO2fM1lCDvMUXxGr8q xJfABQHw/+Fj79Nvn+cXKLnUfnvrzJznQGygzwYAnclvshXNEzUkwI0DUJPQsgO+yAih 9BQ8yITfMIsOTTI4XrpgRXP9vAjgqh0UYxXUUNO4XOSPfbmiMCLJQwLQV83+Ke43m27C rjY2pw2TRMJbNg5phgYc2OcZYX9eI/JYFwmYmd9rlGscr1n/IZrZDojs5okmwwRsdvgY CQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=hcnRInHyT7AqsJ1AJbefJWd13NGYBwYyXEFZcHJATbY=; b=ustIn+be0HGJn7OAARL3OeD/vBrGWaigWnD77emKMxqU/uv2X48NBHaQUjFC7CXktj wULA5qWXVZ2gnGR6mnwwS4/WBroShyhwTwYD8uGEd37OL3zXKwYOUIHSw8n7EfpsLAKX Y7TawL7m2PZCZkAYCXMalBZyxAG7i+kuC4WXhqSIAhjAFTRL+EqnUhdP0cmwU44z+3JC TgaNl82XK12jrkPlFqzXeS7dkAPTLrNWL3BTSbGMeNc9gr/j2U8tJby218NFxL/kdXpS cTVnZ+iDE9vas/Es9yuu7L6e7Q2DQAJXxDgOXIUHgFFWlSATtGrE3QF8WI4tGtoONA6m 46WA== X-Gm-Message-State: AOAM533eQYLLAgB49G3osRnbZaVjTNniU+dreTjVnttullzaHjF9Ur9H tmSD/wmRW/XV5F1ZAtro0CR+3g== X-Google-Smtp-Source: ABdhPJzwcHKRnLlbYa+DzMb5ldu29lVAc6Rg9+D/8Np1y8eHDZDZijeZOmxUYc5MWOGbFELaKiEoOQ== X-Received: by 2002:a05:622a:1046:b0:2de:4c2b:96c8 with SMTP id f6-20020a05622a104600b002de4c2b96c8mr24656420qte.141.1646252260655; Wed, 02 Mar 2022 12:17:40 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id y18-20020a05622a165200b002dda08f1371sm2317qtj.0.2022.03.02.12.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 12:17:39 -0800 (PST) Date: Wed, 2 Mar 2022 12:17:30 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Linus Torvalds cc: Xavier Roche , Linux Kernel Mailing List , Hugh Dickins , Andrew Morton , Jean Delvare , Linux-MM Subject: Re: [PATCH v3] tmpfs: support for file creation time In-Reply-To: Message-ID: References: <20220211213628.GA1919658@xavier-xps> <20220211213628.GA1919658@xavier-xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: q65zrze917fwi4jqrer8xmkekf5nfpw9 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=j0T2nJV0; spf=pass (imf09.hostedemail.com: domain of hughd@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Queue-Id: 930C3140009 X-HE-Tag: 1646252261-91699 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Mar 2022, Linus Torvalds wrote: > On Mon, Feb 28, 2022 at 12:43 AM Xavier Roche wrote: > > > > Various filesystems (including ext4) now support file creation time. > > This patch adds such support for tmpfs-based filesystems. Please ignore this patch for now: I presume Xavier did not understand the "from akpm to Linus in next merge window" flow, and thought he had to resend the patch to you. > > What's the odd huge-page noise in this patch? That was one of the fixups I added, which akpm is holding in a -fix patch to be merged in, and maybe he'll include my comment from it: 3. Using shmem_getattr() on other file types than regular requires that shmem_is_huge() check type, to stop incorrect HPAGE_PMD_SIZE blksize. (shmem_getattr() was only on regular files before: Xavier's patch added it to directories etc, to provide btime for them too; but shmem_getattr() can also include a dubious adjustment to blksize.) > > Other oddities: > > Reply-To: b954973a-b8d1-cab8-63bd-6ea8063de3@google.com > > WHAT? No comment from me. > > And finally - if we really want to treat btime as a first-class entity > and expect things like tmpfs to support it, then we should just bite > the bullet and put it in 'struct inode' along with the other times. I've no objection if someone does that later. I've no investment in btime myself (my instinctive reaction was, is this thing worth another 16 bytes of inode space?), but Xavier thought it worth doing, and Andrew worth taking, so go with the flow. Ah, Andrew has replied meanwhile, I hope I'm not contradicting! Hugh