From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184B3C5B543 for ; Wed, 4 Jun 2025 13:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9C636B05FB; Wed, 4 Jun 2025 09:31:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A74016B05FD; Wed, 4 Jun 2025 09:31:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98B0A6B05FE; Wed, 4 Jun 2025 09:31:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7BB2A6B05FB for ; Wed, 4 Jun 2025 09:31:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B9C5816FF for ; Wed, 4 Jun 2025 13:31:59 +0000 (UTC) X-FDA: 83517806358.18.640AF10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id A5920100004 for ; Wed, 4 Jun 2025 13:31:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I0ZpeLf+; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749043916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0ak6P4hoXZV0IlX+BuzhQGv8bbw0xx57RHIQQN6xpI=; b=0aTn14wDh4jGAwnotLlKZobNk6oKaslGpcJSrfu19VvVb4mTsSE4Rn+LXJWSB4iyi3B/4s 9JpPoI+9CS9SVVXG9z7Fioxs57ys8EyVemjjEMEfkxYFGD80ShXe+cZQAvSjr4KflVte+I ousBRwFIe+z/EpdnZD1psc1+Ns3uboY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I0ZpeLf+; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749043916; a=rsa-sha256; cv=none; b=fHHkFOZjwKHaPM5eqULW38L4xAbU3cK6aHQlMRNQnKi50aRGiqsT58sRwzE2qoRIr2uNLY jJOaKEIZnz/qZhJ2akN9dCBCeq3eRQPO6NUlcZZn736iUgROJtAH9zF9sjg55ECSwexJYd VPA1c7nO4leUtEBdRPU9CYd83J7mLCE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749043914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g0ak6P4hoXZV0IlX+BuzhQGv8bbw0xx57RHIQQN6xpI=; b=I0ZpeLf+qFCmgMGKDEdwNX5X6lRmciek5p7by19eYyUay92z1nqoHSDqhTBcOutSCRUKRQ +H19pDjB/MZD26e0hwxoZqGOfzfFL65poPuCJa5VPBWRtbqJVcY7SkvAI2im/clPzba3RI 7R+orqwO0tZj41ivfC/7mQeRjoY60GQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-IjXzxBN4P12rk5qQqMP0bg-1; Wed, 04 Jun 2025 09:31:52 -0400 X-MC-Unique: IjXzxBN4P12rk5qQqMP0bg-1 X-Mimecast-MFC-AGG-ID: IjXzxBN4P12rk5qQqMP0bg_1749043910 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a1f6c5f4f2so2514420f8f.2 for ; Wed, 04 Jun 2025 06:31:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749043910; x=1749648710; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=g0ak6P4hoXZV0IlX+BuzhQGv8bbw0xx57RHIQQN6xpI=; b=Tz8hOqBTiYEpIv2CB8yfcDQKTT+FujyNwcnFhwDkoThEFet71CxziKm81F9ANwHsP8 clWUthbhdf9kIxsZmWIfcakeA2tA8LurW0eSSfE3C/IPitAHjSuMlLaLBh8GnCe0hHu/ 0F9mTGQ247LvDk9CMMc8/1l9oTlmuHkaipnl8GQh93NSg9UoRjtKaWIz4EAdR3cFmrk/ aj8gzKejuE7v0updjXhJNi1NrAOh0AZLPJAwwWoN7zAIS/FMjjpIti47wlwMAnyzKOGa X6vS9vpWWObrPtLKF4K1HE5hrHF++AfvPnx0qX/HHjA1KQjMujawdQLLsyPamVt4NuQI ZLlg== X-Forwarded-Encrypted: i=1; AJvYcCW2WsoKFOuJFQJbAmmJnUmzv/ODrJVavjOInOLLvHX2MLgJT5831VhzSKr7/nFx7n62XzOtZhBnzg==@kvack.org X-Gm-Message-State: AOJu0YxzL4M3/mB4jEi8/McxXNH1yqXT9RydmdiIniTPPKKtTQnbDqPD hk5LLNuPrlcqF1w6or5FQEywaa0QXGzW1XTLC1OxvUu/utIycjwF8BzYgHAwo5GL2uFafg5tKUk WgnIIMACthb6v3iWKJXtfeVLFyPCWlIuKBbXGT7AByAFcaJ/vTabb X-Gm-Gg: ASbGncvDyDYr6g7O7NyVyLf9fcsQLSiR/WEwOK6pgy3HJJ1oiU881/15CHo9+Sw2RW5 jemTAJ+LzL8wE3r1xYmatwB+oDUm2I7EZBCt5e/5853+n56Uqvp0IzUiQgvneqJdVJODGqqaaZ/ imFr8GlDr/f/LPB8BQr5iG2IyJlTiYVAuVtAzDj572nf5HpvFe3UKY/zROiyI4QIH2oKAiU9q5I YWOhi55iZs6quX/6xC85RnZ4ym7EzpJTZm2Nw3URDu0aomjRcSe0tTK6G5sNulG0Lx6NlRgw729 OdkRdoIC4eXKwM0m/Vt/aMYpkFljbxWkiKXl7c9T6XEeibWK3leWj+rXd2FuIKhwJVMYD+PIKwR OF6N2fpnpPH8Ix2LNRFP/Pysp/hvilBaZmLa4MaHanijsjy4G6g== X-Received: by 2002:a05:6000:420f:b0:3a4:c75c:efd5 with SMTP id ffacd0b85a97d-3a51d96e747mr2414336f8f.46.1749043909856; Wed, 04 Jun 2025 06:31:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGuM2gMUpQSJdpex6F6doEYF6luunnpKyBL6ysGIZNUcXOZj9kxWx4CEbjV1uSXlRCdGrEK/g== X-Received: by 2002:a05:6000:420f:b0:3a4:c75c:efd5 with SMTP id ffacd0b85a97d-3a51d96e747mr2414289f8f.46.1749043909452; Wed, 04 Jun 2025 06:31:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe6c91fsm21855003f8f.35.2025.06.04.06.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 06:31:49 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 15:31:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER_CEIL. To: Zi Yan , Anshuman Khandual Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, isaacmanjarres@google.com, jyescas@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, masahiroy@kernel.org, mhocko@suse.com, minchan@kernel.org, rppt@kernel.org, surenb@google.com, tjmercier@google.com, vbabka@suse.cz References: <20250603154843.1565239-1-ziy@nvidia.com> <957DB2F9-9C7E-486E-95EA-1E6574F82D4B@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <957DB2F9-9C7E-486E-95EA-1E6574F82D4B@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bp7iDryVGuQT3qcETedrSWIAHlMESKJNdvQAcVv4Tys_1749043910 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: qxap3s5386rk5y7otwtuxjt6enu6d9gg X-Rspamd-Queue-Id: A5920100004 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749043915-709773 X-HE-Meta: U2FsdGVkX1/VSL90ieDwBLJ9/iDUhtlx1/nfc9qTn5vAzrxJSPJyQdPS6gDOosIzSjEtGKAjnec1Fbb4FUatiQ4w1Ub4f2eemLEo0dDa5oxK7aYMY0YjAEiVrVkY9vB+5R0dWuCUojrk6GGyXRKrI6uwOR0qJHKUSxkzwE4ugKM5RJIgzGWoZ/hf+VBof4VMckFeSSH+H2i+BVmJQxprlF+TQW/585sjxvtsRkwX1i+lzlGc5eJutzgbfofFvSJ1ep07KtX9whV/ZaFzlBfD1vN9+salvz2WZm9NhD5auySq0wiqYgoa5hpVeGewGEulwhC7K1xKTYqcpnAq7YhSGpVQHOBiZAD2zdmKNeitVPr99rI+ubi6D9goHe3fq5nW74vfId9IjQYCKxN/48Qnal5zSobkdEVuxWY9JmoI4sJAztPkJpbiEBI0a3ftYBojagdcbK3RQMHWOQerN7VbSVA5OsiCWlOHRBCKL7Mr6BJ62jbXn2WHDp44z1gavDznidYkT2DCY1Lwmtgs5u4a0DCYjGrUE3g4bkcz1mE2ed2+Uh5mOaga9/rtb4dtE+y58i1OyedRYASCc4U2+8LcaI+80VIFIUEF29QXAmwL9iXvDgt3EMLGEatuwF/Wg14tKmQm2MfJ5pkhM6TSx5H7To+Q0vCXnqclEJUP7by54DA/e1kfYnBgKEaP9X5198JAnkpL5Bk3EfZ2mW9LYtK/WJEwQTRqTDmb24udtpzvrlXhZhfiXulwlWBLiAsJ/D1pm5LCWiXdPDTWSOmX35BW7Ah7BbbhofmgOfbCh1fgeqmY5y5ZSdMVh3bHJ/KXRvAElzgBOPqufIb6+DUOJ3WbehtfmR6O9hKs/ocYSQsfuv3hb86mxKFqsclFQg5SIL5NTp9WYoHCGz8DqCZmMGAp3dKH0LMB7z31vlZp8PmB9ulb+YpnzNu2C0ly9q4X6i5keYMdsf4KVMaLhWgEd2h zeNI9N1H LarQwndUTmLekEOLO3MstrUHFTsVngDzlDA8H/clT1JQmf25u1idO2IMte82JIliQD8tyGWrTxkYUvcZlGTDsSW3NIRmYoA7dLbPDS8xoMt7ayTIqRL3gMFLFZW0n6pOcwcphM5/Y21HvrsD/vQO5z4diqyHbQ+nz4P/ntLlZSBhhjp9NBYVr1XkJmenjzbN9s3DX+rwHkFRF1o+GOdM122KEmqsDnCHfBXJ5EMvLJaoZBhr2XmPpj1YfcWiLpxFb69UpRefOjiHA64nXCxs5W6wepi88coPvC6tWUgBjJP1sTTGzkroTHd0c58woGtwF5SNYUbhHxETeiZxNRNYLw39Eel6VRAqWg+GI6G8xIMbUC/tOzfr3FNphlG8tCCORzCOk2Q+jyQUHVnHXp2zhQmasYLWmymb+PeaDaAAu2waa6zYeKly2OMiYNpIwmneRIW6uClAJPNxXOqljjFV8rxSDROP+g1OUnQP9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 15:26, Zi Yan wrote: > On 4 Jun 2025, at 0:36, Anshuman Khandual wrote: > >> On 6/3/25 21:18, Zi Yan wrote: >>> The config is in fact an additional upper limit of pageblock_order, so >>> rename it to avoid confusion. >> >> Agreed. This new config has been similar to existing 'pageblock_order' >> that might cause confusion. Hence renaming makes sense. But instead of >> PAGE_BLOCK_ORDER_CEIL should it be rather PAGE_BLOCK_ORDER_MAX ? > > Or PAGE_BLOCK_MAX_ORDER? Would also work for me. > >> >>> >>> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order") >> >> Does it really need a "Fixes: " tag given there is no problem to fix ? > > I have no strong opinion on this one. Probably we want this to go into this release. No need for a Fixes: I assume. -- Cheers, David / dhildenb