From: David Hildenbrand <david@redhat.com>
To: Zi Yan <ziy@nvidia.com>, Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
isaacmanjarres@google.com, jyescas@google.com,
kaleshsingh@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, lorenzo.stoakes@oracle.com,
masahiroy@kernel.org, mhocko@suse.com, minchan@kernel.org,
rppt@kernel.org, surenb@google.com, tjmercier@google.com,
vbabka@suse.cz
Subject: Re: [PATCH] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER_CEIL.
Date: Wed, 4 Jun 2025 15:31:47 +0200 [thread overview]
Message-ID: <b92484b6-c028-4969-8efb-aff747c38f83@redhat.com> (raw)
In-Reply-To: <957DB2F9-9C7E-486E-95EA-1E6574F82D4B@nvidia.com>
On 04.06.25 15:26, Zi Yan wrote:
> On 4 Jun 2025, at 0:36, Anshuman Khandual wrote:
>
>> On 6/3/25 21:18, Zi Yan wrote:
>>> The config is in fact an additional upper limit of pageblock_order, so
>>> rename it to avoid confusion.
>>
>> Agreed. This new config has been similar to existing 'pageblock_order'
>> that might cause confusion. Hence renaming makes sense. But instead of
>> PAGE_BLOCK_ORDER_CEIL should it be rather PAGE_BLOCK_ORDER_MAX ?
>
> Or PAGE_BLOCK_MAX_ORDER?
Would also work for me.
>
>>
>>>
>>> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
>>
>> Does it really need a "Fixes: " tag given there is no problem to fix ?
>
> I have no strong opinion on this one.
Probably we want this to go into this release. No need for a Fixes: I
assume.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-06-04 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 15:48 Zi Yan
2025-06-03 20:46 ` David Hildenbrand
2025-06-04 4:29 ` Juan Yescas
2025-06-04 4:36 ` Anshuman Khandual
2025-06-04 13:26 ` Zi Yan
2025-06-04 13:31 ` David Hildenbrand [this message]
2025-06-04 13:36 ` Zi Yan
2025-06-04 12:43 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92484b6-c028-4969-8efb-aff747c38f83@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=isaacmanjarres@google.com \
--cc=jyescas@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=masahiroy@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tjmercier@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox