From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF0FC433EF for ; Tue, 12 Oct 2021 14:13:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 68B3760EFE for ; Tue, 12 Oct 2021 14:13:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 68B3760EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C38046B0071; Tue, 12 Oct 2021 10:13:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC18B900002; Tue, 12 Oct 2021 10:13:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A137A6B0073; Tue, 12 Oct 2021 10:13:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 92BCA6B0071 for ; Tue, 12 Oct 2021 10:13:36 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2B7711810780C for ; Tue, 12 Oct 2021 14:13:36 +0000 (UTC) X-FDA: 78687978432.34.270A724 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf13.hostedemail.com (Postfix) with ESMTP id B913F10360A1 for ; Tue, 12 Oct 2021 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634048015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BzTrRfXXNk8+PLvonfcHlML3JOVXOT6Q8/EMkco8wbY=; b=cBByThrrnAx8WOGUenhiJhoN74tVjE692iUz0mOnoXDuciyMQ9ofIh8I5LIHd6NP4rHVUk SpjqukgZnU61OJw200pSmQAVyAtAlJQtbPnXZaYORIAzQxucmBjPenoE/Zus0r8Uz0ik4M 4s6haU2bFhvCtdDFmUJiap779dkhjPw= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-phliUMlxP0Cxlnd0KIJveA-1; Tue, 12 Oct 2021 10:13:33 -0400 X-MC-Unique: phliUMlxP0Cxlnd0KIJveA-1 Received: by mail-wr1-f70.google.com with SMTP id y12-20020a056000168c00b00160da4de2c7so12742031wrd.5 for ; Tue, 12 Oct 2021 07:13:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BzTrRfXXNk8+PLvonfcHlML3JOVXOT6Q8/EMkco8wbY=; b=zaWl47WJQbkMkBhx9WMbjNsJfANSEOksbSuArlyKwK0Luqkwza49QBvKT+QoYyB1Kl XJ9cQurje8SbUF5WztDoF+mwF6R4aD6JFQIyL0n+lapXAdlv6svZ9PfaHoofcETHzfCS l8w6smPPwiDFQm1zuGLwZ/Csq4dZmDToWEf8lUh48iKoJnIjme+dpbew9fZy4md1FsGQ Cr6T0FxyKOXRP6r0cQK3QNvWBZcYAYTnlRYeoh8jrXpLIbA8xG0xcWzs3am0eb8hiJX7 GDmQp3osRVuW+xvOEMcrAk0gixkl9jB3HK/UT7PKLp8ugG07w93SaCyU5me0CyjPXF73 o0Aw== X-Gm-Message-State: AOAM531gmfoksQ7VVDL9zrNOhP98N6fGplNoR8btIKPlfA32CmnpjRyx jEhr5ig/wt7UeJoTPDHqC65u+16l9Oz/XI/spG4LIDTwOUHWxlGJbsQCi6CM4W046jdkx+COE5u G1/KyLfH/dEo= X-Received: by 2002:adf:9b97:: with SMTP id d23mr31775902wrc.53.1634048012832; Tue, 12 Oct 2021 07:13:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDOcPDg93RfEOergksAHpsDa13Q8GcPCVdb5DKzHu8nWEQyeen+YOwraUjsQmj973pkAC+qw== X-Received: by 2002:adf:9b97:: with SMTP id d23mr31775866wrc.53.1634048012603; Tue, 12 Oct 2021 07:13:32 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6a12.dip0.t-ipconnect.de. [91.12.106.18]) by smtp.gmail.com with ESMTPSA id b19sm2797722wmb.1.2021.10.12.07.13.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Oct 2021 07:13:31 -0700 (PDT) Subject: Re: [PATCH v2 2/2] mm: use pidfd_get_task() To: Christian Brauner , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Vlastimil Babka , Suren Baghdasaryan , Matthew Bobrowski , Alexander Duyck , Jan Kara , Christian Brauner , Minchan Kim References: <20211011133245.1703103-1-brauner@kernel.org> <20211011133245.1703103-3-brauner@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Tue, 12 Oct 2021 16:13:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211011133245.1703103-3-brauner@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B913F10360A1 X-Stat-Signature: 9z9mxy9ah8mbtqrfjx7hun7r9nojq8qk Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cBByThrr; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1634048015-196501 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.10.21 15:32, Christian Brauner wrote: > From: Christian Brauner > > Instead of duplicating the same code in two places use the newly added > pidfd_get_task() helper. This fixes an (unimportant for now) bug where > PIDTYPE_PID is used whereas PIDTYPE_TGID should have been used. What would have been the effect of the BUG? Is it worth Fixes: or better even separating out the fix? > > Link: https://lore.kernel.org/r/20211004125050.1153693-3-christian.brauner@ubuntu.com > Cc: Vlastimil Babka > Cc: Suren Baghdasaryan > Cc: Matthew Bobrowski > Cc: Alexander Duyck > Cc: David Hildenbrand > Cc: Jan Kara > Cc: Minchan Kim > Reviewed-by: Matthew Bobrowski > Signed-off-by: Christian Brauner > --- > /* v2 */ > unchanged Acked-by: David Hildenbrand -- Thanks, David / dhildenb